aleksandr.urakov added a comment.
Ping!
Can you review this, please? I have just implemented the UDT types completion
for PDB symbol files and I am preparing a patch for that, but it makes no sense
without the part implemented in this one :)
https://reviews.llvm.org/D49018
asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.
Except for minor formatting LGTM
Comment at: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp:7
+
+ return;
+}
Please remove the return
==
aleksandr.urakov marked an inline comment as done.
aleksandr.urakov added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h:26
+//--
+/// Converts a location inform
aleksandr.urakov updated this revision to Diff 155154.
aleksandr.urakov added a comment.
Thanks a lot, I have updated the patch!
I also have added a test case for a non-zeroth frame (it became possible after
https://reviews.llvm.org/D49111).
If it's all right, can you commit this for me, please
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM if you don't want to consider my remaining suggestion for this patch.
Thanks for the extra tests.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:52
lemo added a comment.
Thanks Adrian for the thorough review.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:52
ASSERT_GT(parser->GetData().size(), 0UL);
+auto result = parser->Initialize();
+if (expect_failure)
amccarth wrote:
> lemo
teemperor added a comment.
@jingham I thought the same at first, but giving an error `command.empty()`
turns out to be a problem. The command string contains the arguments (but not
the command name itself). So when calling for example `bt` we would hit this
error (as there are no args, so `com
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Thanks.
https://reviews.llvm.org/D48865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
jingham added a comment.
Yeah, you are right about that. The command string presented to commands never
contained the command name, that always got stripped off. But I don't think
that ever left the command string to be nullptr... So you are right, that was
just dead code.
https://reviews.
Author: lemo
Date: Thu Jul 12 10:27:18 2018
New Revision: 336918
URL: http://llvm.org/viewvc/llvm-project?rev=336918&view=rev
Log:
Restructure the minidump loading path and add early & explicit consistency
checks
Corrupted minidumps was leading to unpredictable behavior.
This change adds explic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336918: Restructure the minidump loading path and add early
& explicit consistency… (authored by lemo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
Author: stella.stamenova
Date: Thu Jul 12 14:27:56 2018
New Revision: 336948
URL: http://llvm.org/viewvc/llvm-project?rev=336948&view=rev
Log:
[process] Update the documentation for ReadMemory and DoReadMemory to include
the error parameter
Summary: The current documentation does not include the
teemperor accepted this revision.
teemperor added a comment.
Davide also approved it offline (thx).
https://reviews.llvm.org/D49207
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: teemperor
Date: Thu Jul 12 15:28:52 2018
New Revision: 336955
URL: http://llvm.org/viewvc/llvm-project?rev=336955&view=rev
Log:
Get rid of the C-string parameter in DoExecute
Summary:
This patch gets rid of the C-string parameter in the
RawCommandObject::DoExecute function,
making the co
This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336955: Get rid of the C-string parameter in DoExecute
(authored by teemperor, committed by ).
Herald added a subscriber
Author: jmolenda
Date: Thu Jul 12 15:45:41 2018
New Revision: 336956
URL: http://llvm.org/viewvc/llvm-project?rev=336956&view=rev
Log:
Remove incorrect thread-pc-values clearing
from ProcessGDBRemote::UpdateThreadIDsFromStopReplyThreadsValue.
Patch by Venkata Ramanaiah.
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336956: Remove incorrect thread-pc-values clearing (authored
by jmolenda, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48868?vs=154947&id=1
shafik created this revision.
shafik added reviewers: jingham, friss, jasonmolenda.
Herald added subscribers: christof, mgorny.
Herald added a reviewer: EricWF.
Add formattors for libc++ std::optional and tests to verify the new formattors.
https://reviews.llvm.org/D49271
Files:
lldb.xcodepro
Author: stella.stamenova
Date: Thu Jul 12 16:02:33 2018
New Revision: 336960
URL: http://llvm.org/viewvc/llvm-project?rev=336960&view=rev
Log:
[lldbsuite] The test inside TestOverloadedFunctions.py has the wrong class name
Summary: It looks like the test file was copied from TestCPPStaticMethods.
davide added a comment.
Some comments. Jonas looked at many formatters recently so he's in a good
position to take a look.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/Makefile:9
+CXXFLAGS += -std=c++17
+#CFLAGS
jingham requested changes to this revision.
jingham added a comment.
It seems a little odd to choose to represent this as an array with 0 elements.
I think I would be confused by that. You can maybe choose a better name like
"value" for your cloned object. But it looks like it is also possibl
Sure, I will do it Monday if someone hasn’t done it already.
> On Jul 12, 2018, at 9:22 PM, Aleksandr Urakov via Phabricator
> wrote:
>
> aleksandr.urakov updated this revision to Diff 155154.
> aleksandr.urakov added a comment.
>
> Thanks a lot, I have updated the patch!
>
> I also have add
asmith added a subscriber: aleksandr.urakov.
asmith added a comment.
Sure, I will do it Monday if someone hasn’t done it already.
https://reviews.llvm.org/D49018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
xiaobai created this revision.
xiaobai added reviewers: zturner, labath, sas.
Herald added a subscriber: mgorny.
There is currently a way to skip the debugserver build. See how the CMake
variables SKIP_DEBUGSERVER and LLDB_CODESIGN_IDENTITY are used if you're
interested in that.
I'd like the opti
24 matches
Mail list logo
