ramana-nvr updated this revision to Diff 154947.
ramana-nvr added a comment.
For now, leaving the m_thread_pcs.clear() in UpdateThreadIDList() unchanged as
it is not causing any problems.
https://reviews.llvm.org/D48868
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: s
jdenny created this revision.
jdenny added a reviewer: probinson.
Herald added a subscriber: JDevlieghere.
See https://reviews.llvm.org/D47106 for details.
https://reviews.llvm.org/D49192
Files:
lldb/lit/SymbolFile/DWARF/find-basic-function.cpp
Index: lldb/lit/SymbolFile/DWARF/find-basic-fu
Author: teemperor
Date: Wed Jul 11 10:18:01 2018
New Revision: 336824
URL: http://llvm.org/viewvc/llvm-project?rev=336824&view=rev
Log:
Allow specifying an exit code for the 'quit' command
Summary:
This patch adds the possibility to specify an exit code when calling quit.
We accept any int, even
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336824: Allow specifying an exit code for the
'quit' command (authored by teemperor, committed by ).
Herald added a subscr
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D49192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
lemo created this revision.
lemo added reviewers: amccarth, labath.
lemo added a project: LLDB.
Herald added a subscriber: mgrang.
Corrupted minidumps was leading to unpredictable behavior.
This change adds explicit consistency checks for the minidump early on. The
checks are not comprehensive b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336846: [FileCheck] Add -allow-deprecated-dag-overlap to
failing lldb tests (authored by jdenny, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
looks good.
https://reviews.llvm.org/D48868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
amccarth added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:23
#include
+#include
+#include
Why add ``? It looks like your new map is just a vector.
Comment at: source/Plugins/Process/minidump/MinidumpPar
lemo added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:23
#include
+#include
+#include
amccarth wrote:
> Why add ``? It looks like your new map is just a vector.
Good catch
Comment at: source/Plugins/Pro
lemo updated this revision to Diff 155069.
lemo marked 9 inline comments as done.
lemo added a comment.
Incorporating CR feedback
https://reviews.llvm.org/D49202
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/MinidumpParser.h
source/Plugins/Proce
amccarth added a comment.
Also, I'm not seeing tests for the other consistency checks you're adding (like
whether there are any streams or whether the streams overlap). Is it difficult
to create such malformed minidumps?
Comment at: unittests/Process/minidump/MinidumpParserT
amccarth added inline comments.
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:172
+
+ // Do we support the minidump's architecture?
+ ArchSpec arch = GetArchitecture();
lemo wrote:
> amccarth wrote:
> > Should the architecture check be in the
lemo added a comment.
Regarding test for the other checks, I'll try to fabricate a few invalid
minidumps (although it would obviously provide limited coverage)
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:52
ASSERT_GT(parser->GetData().size(), 0UL);
+
Author: stella.stamenova
Date: Wed Jul 11 15:47:35 2018
New Revision: 336865
URL: http://llvm.org/viewvc/llvm-project?rev=336865&view=rev
Log:
[windows] Fix out-of-memory failure in some of the tests
Summary: When ReadProcessMemory fails, bytes_read is sometimes set to a large
garbage value. In
lemo updated this revision to Diff 155076.
lemo added a comment.
Adding a few ill-formed minidumps for testing the new checks
https://reviews.llvm.org/D49202
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/MinidumpParser.h
source/Plugins/Process/m
lemo updated this revision to Diff 155080.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D49202
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/MinidumpParser.h
source/Plugins/Process/minidump/MinidumpTypes.cpp
source/Plugins/Process
teemperor created this revision.
teemperor added a reviewer: davide.
This patch gets rid of the C-string parameter in the
RawCommandObject::DoExecute function,
making the code simpler and less memory unsafe.
There seems to be a assumption in some command objects that this parameter
could be a n
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I think the CommandObjectRegex check that you took out wasn't something devious
or clever, but was just an incomplete (and so buggy) version of the check:
if (command && command[0]
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Ack'ed by Jim offline.
https://reviews.llvm.org/D49155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: davide
Date: Wed Jul 11 17:31:04 2018
New Revision: 336872
URL: http://llvm.org/viewvc/llvm-project?rev=336872&view=rev
Log:
[IRInterpreter] Fix misevaluation of interpretation expressions with `urem`.
Scalar::MakeUnsigned was implemented incorrectly so it didn't
really change the sign of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336872: [IRInterpreter] Fix misevaluation of interpretation
expressions with `urem`. (authored by davide, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
I do not have commit access to LLDB. Could someone please commit the below
changes?
On Thu, Jul 12, 2018 at 2:32 AM, Jason Molenda via Phabricator <
revi...@reviews.llvm.org> wrote:
> jasonmolenda accepted this revision.
> jasonmolenda added a comment.
> This revision is now accepted and ready to
Author: echristo
Date: Wed Jul 11 20:52:45 2018
New Revision: 336884
URL: http://llvm.org/viewvc/llvm-project?rev=336884&view=rev
Log:
Remove unused variable m_header as it hasn't been used since it was
added in 2016.
Modified:
lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp
Author: echristo
Date: Wed Jul 11 20:52:46 2018
New Revision: 336885
URL: http://llvm.org/viewvc/llvm-project?rev=336885&view=rev
Log:
Remove the unused m_signal member variable, but leave the code that gets it out
of the json.
Modified:
lldb/trunk/unittests/tools/lldb-server/tests/MessageOb
ramana-nvr updated this revision to Diff 155114.
ramana-nvr added a comment.
The error messages now refer to the thread ID instead of the thread index.
https://reviews.llvm.org/D48865
Files:
source/Commands/CommandObjectThread.cpp
Index: source/Commands/CommandObjectThread.cpp
=
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py:22
@skipIfDarwin # pexpect is known to be unreliable on Darwin
@skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread
races
def test_ll
27 matches
Mail list logo
