labath added a comment.
How are you planning on testing this? Most of the DWARFIndex functionality is
tested in terms of lldb-test, but I think this function is not reachable from
there. Maybe you could write a specific dotest-test which targets this?
https://reviews.llvm.org/D48596
___
JDevlieghere updated this revision to Diff 153027.
JDevlieghere added a comment.
- Add test case for debug_names variant.
https://reviews.llvm.org/D48596
Files:
packages/Python/lldbsuite/test/lang/objc/forward-decl/TestForwardDecl.py
source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
labath accepted this revision.
labath added a comment.
looks good to me
https://reviews.llvm.org/D48596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
labath added reviewers: clayborg, lemo, sas, davide.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
The data structure is optimized for the case where the UUID size is <=
20 bytes (standard length emitted by the GNU linkers), but la
labath created this revision.
labath added reviewers: clayborg, jingham.
To successfully open a core file, we need to have LLVM built with
support for the relevant target. Right now, if one does not have the
appropriate targets configured, the tests will fail.
This patch uses the GetBuildConfigur
labath created this revision.
labath added reviewers: aprantl, zturner.
This test makes sure we are able to read the shorter build-ids which are
generated by lld.
To make this work, I've extended lldb-test to print the UUID of the
loaded object file. I've renamed the lldb-test subcommand from
"mo
Ping.
On Tue, 19 Jun 2018 at 16:04, Pavel Labath wrote:
>
> A test?
>
> It looks like it should be possible to test this in a similar way to
> other CommandCompletion tests
> (unittests/Interpreter/TestCompletion.cpp).
> On Mon, 18 Jun 2018 at 21:16, Raphael Isemann via lldb-commits
> wrote:
> >
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D48596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg added inline comments.
Comment at: source/Interpreter/OptionValueUUID.cpp:82
+ llvm::SmallVector uuid_bytes;
+ UUID::DecodeUUIDBytesFromString(s, uuid_bytes);
for (size_t i = 0; i < num_modules; ++i) {
Probably should have a return value
kubamracek added a comment.
friendly ping :)
https://reviews.llvm.org/D44603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl added a comment.
SGTM
https://reviews.llvm.org/D48646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kastiglione created this revision.
kastiglione added reviewers: clayborg, granata.enrico.
This change fixes one issue with `lldb.command`, and also reduces the
implementation.
The fix: a command function's docstring was not shown when running `help
`. This is because the docstring attached the
kastiglione updated this revision to Diff 153114.
kastiglione added a comment.
Update a comment
https://reviews.llvm.org/D48658
Files:
scripts/Python/python-extensions.swig
Index: scripts/Python/python-extensions.swig
===
--- s
granata.enrico added a comment.
Thanks for doing this work.
I stopped working on lldb a couple years ago, so I removed myself as a
reviewer. Greg will take good care of you I'm sure.
https://reviews.llvm.org/D48658
___
lldb-commits mailing list
ll
kastiglione added a subscriber: granata.enrico.
kastiglione added a comment.
Thanks @granata.enrico, sorry for the disruption, I noticed previous comments
after I had submitted this.
https://reviews.llvm.org/D48658
___
lldb-commits mailing list
lld
teemperor created this revision.
teemperor added a reviewer: davide.
This patch adds the possibility to specify an exit code when calling quit.
We accept any int, even though it depends on the user what happens if the int is
out of the range of what the operating system supports as exit codes.
Fi
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This won't at all do what users expect in cases where the driver program
doesn't cooperate. For instance, when run under Xcode, the lldb process can
have many debuggers running co
teemperor updated this revision to Diff 153126.
teemperor added a comment.
- We now also handle the case where a guarded mutex is manually unlocked from a
nested call.
- Refactoring based on review comments.
https://reviews.llvm.org/D48463
Files:
include/lldb/Core/Debugger.h
include/lldb/H
teemperor updated this revision to Diff 153129.
teemperor edited the summary of this revision.
teemperor added a comment.
- Fixed that we only pass a nullptr as a debugger to the real editline object
(which now fixes the deadlock in the code completion patch).
https://reviews.llvm.org/D48463
F
teemperor marked 2 inline comments as done.
teemperor added a comment.
@labath Thanks for the explanation! Well in theory we could poke more holes in
our guard from some nested function, but this only fixes the deadlock symptom.
PrintAsync would still be blocking whenever the mutex is hold by so
teemperor created this revision.
teemperor added a reviewer: labath.
https://reviews.llvm.org/D48665
Files:
unittests/Interpreter/TestCompletion.cpp
Index: unittests/Interpreter/TestCompletion.cpp
===
--- unittests/Interpreter/Te
Author: jdevlieghere
Date: Wed Jun 27 12:58:39 2018
New Revision: 335776
URL: http://llvm.org/viewvc/llvm-project?rev=335776&view=rev
Log:
[SymbolFile] Implement GetCompleteObjCClass for .debug_names
When running the test suite with .debug_names a bunch of tests were
failing because GetCompleteOb
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335776: [SymbolFile] Implement GetCompleteObjCClass for
.debug_names (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48596?vs=153027&id=153161#toc
Reposito
smeenai added a comment.
This is definitely trivial enough to just go through post-commit review :) (As
in, just commit it directly without going through Phabricator.)
Repository:
rL LLVM
https://reviews.llvm.org/D48620
___
lldb-commits mailing
clayborg requested changes to this revision.
clayborg added a comment.
This change seems fine to me. It allows each debugger to have a different exit
status and each debugger can grab one. Seems like this should belong in
lldb_private::CommandInterpreter and lldb::SBCommandInterpreter instead of
clayborg added a comment.
Can we add a test for this to ensure all functionality that we want? I recently
made changes to the cmdtemplate.py. Maybe we can integrate some more
functionality that auto registers a class somehow?
https://reviews.llvm.org/D48658
_
kastiglione added a comment.
@clayborg I'll dig into how `python-extensions.swig` gets tested, and add
something accordingly.
I have only briefly looked at `cmdtemplate.py`. I can look into adding similar
registration behavior to it. For what it's worth, I prefer functions to classes
for defin
ramana-nvr created this revision.
ramana-nvr added reviewers: davide, lldb-commits.
ramana-nvr added a project: LLDB.
https://reviews.llvm.org/D48704
Files:
source/Target/ExecutionContext.cpp
Index: source/Target/ExecutionContext.cpp
===
ramana-nvr updated this revision to Diff 153258.
ramana-nvr added a comment.
Created the patch with more context.
https://reviews.llvm.org/D48704
Files:
source/Target/ExecutionContext.cpp
Index: source/Target/ExecutionContext.cpp
=
29 matches
Mail list logo
