[Lldb-commits] [lldb] r335612 - Represent invalid UUIDs as UUIDs with length zero

Author: labath Date: Tue Jun 26 08:12:20 2018 New Revision: 335612 URL: http://llvm.org/viewvc/llvm-project?rev=335612&view=rev Log: Represent invalid UUIDs as UUIDs with length zero Summary: During the previous attempt to generalize the UUID class, it was suggested that we represent invalid UUID

[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

This revision was automatically updated to reflect the committed changes. Closed by commit rL335612: Represent invalid UUIDs as UUIDs with length zero (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48479?vs=152699

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, clayborg. When running the test suite with .debug_names a bunch of tests were failing. Part of that is solved by implementing the missing GetCompleteObjCClass in DebugNamesDWARFIndex. Repository: rL LLVM http

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:157 +if (entry.tag() != DW_TAG_structure_type && +entry.tag() != DW_TAG_class_type) + continue; Wait.. we accept both structs and classes in LLDB?

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The function is looking for the complete objective C type. The code needs to be modified to return the complete type only if one is found, else just one of the other incomplete v

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere added a comment. In https://reviews.llvm.org/D48596#1143666, @clayborg wrote: > The function is looking for the complete objective C type. The code needs to > be modified to return the complete type only if one is found, else just one > of the other incomplete versions is needed, n

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:157 +if (entry.tag() != DW_TAG_structure_type && +entry.tag() != DW_TAG_class_type) + continue; aprantl wrote: > Wait.. we accept both struct

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere updated this revision to Diff 152912. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Feedback Greg https://reviews.llvm.org/D48596 Files: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp source/Plugins/SymbolFile/DWARF/DebugNamesDWARFInde

[Lldb-commits] [lldb] r335659 - Reverting r335656, SWIG doesn't like "enum class".

Author: jingham Date: Tue Jun 26 13:40:29 2018 New Revision: 335659 URL: http://llvm.org/viewvc/llvm-project?rev=335659&view=rev Log: Reverting r335656, SWIG doesn't like "enum class". Modified: lldb/trunk/include/lldb/lldb-enumerations.h Modified: lldb/trunk/include/lldb/lldb-enumerations.h

[Lldb-commits] [lldb] r335688 - This is not a debug info sensitive test.

Author: jingham Date: Tue Jun 26 16:31:44 2018 New Revision: 335688 URL: http://llvm.org/viewvc/llvm-project?rev=335688&view=rev Log: This is not a debug info sensitive test. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py Modified: lldb/tr

[Lldb-commits] [lldb] r335689 - The Process class ivar ivar was changed to a weak pointer, but was still _sp.

Author: jingham Date: Tue Jun 26 16:38:58 2018 New Revision: 335689 URL: http://llvm.org/viewvc/llvm-project?rev=335689&view=rev Log: The Process class ivar ivar was changed to a weak pointer, but was still _sp. Fix that to _wp. Modified: lldb/trunk/include/lldb/Target/Process.h lldb/trun

Re: [Lldb-commits] Adding a test for split-dwarf

We just use reviews.llvm.org and CC lldb-commits. -- adrian > On Jun 25, 2018, at 9:09 PM, Puyan Lotfi via lldb-commits > wrote: > > This is a first draft. Just trying to do some basic breakpoint and line > number checks on a split dwarf compiled binary for now. >

[Lldb-commits] [lldb] r335690 - Use the API's to get the TargetSP.

Author: jingham Date: Tue Jun 26 16:54:50 2018 New Revision: 335690 URL: http://llvm.org/viewvc/llvm-project?rev=335690&view=rev Log: Use the API's to get the TargetSP. Modified: lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows.cpp Modified: lldb/trunk/source/Plugins/Process/W

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

kastiglione created this revision. kastiglione added a reviewer: xiaobai. Fix a "Manay" in SBSymbolContext.i https://reviews.llvm.org/D48620 Files: scripts/interface/SBSymbolContext.i Index: scripts/interface/SBSymbolContext.i

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Woohoo! https://reviews.llvm.org/D48620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] r335709 - Fix a single typo in SBSymbolContext

Author: kastiglione Date: Tue Jun 26 23:46:09 2018 New Revision: 335709 URL: http://llvm.org/viewvc/llvm-project?rev=335709&view=rev Log: Fix a single typo in SBSymbolContext Summary: Fix a "Manay" in SBSymbolContext.i Reviewers: xiaobai Reviewed By: xiaobai Subscribers: lldb-commits Differen

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL335709: Fix a single typo in SBSymbolContext (authored by kastiglione, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48620 Files: lldb/trunk/