labath added inline comments.
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:317
void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) {
if (m_die_array.size() > 1) {
+llvm::sys::ScopedWriter lock(m_extractdies_mutex);
You're accessi
labath added inline comments.
Comment at: include/lldb/Core/Module.h:779
+ //--
+ void SetUUID(const lldb_private::UUID &uuid);
+
amccarth wrote:
> Was there no SetUUID before because the UUID was
Author: labath
Date: Tue May 1 03:09:53 2018
New Revision: 331250
URL: http://llvm.org/viewvc/llvm-project?rev=331250&view=rev
Log:
Split TestGlobalVariables into two and xfail one of them for arm64 linux
Displaying of global pointer variables is not working on arm64 linux
(pr37301).
I've moved
labath added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py:42
+# Test that static initialized variables can be inspected without
process.
+self.expect("target variable g_ptr", VARIABLES_DI
aprantl added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py:63-65
+self.runCmd("frame variable --show-types --scope --show-globals
--no-args")
self.expect(
"frame variable --sh
Author: adrian
Date: Tue May 1 08:38:01 2018
New Revision: 331270
URL: http://llvm.org/viewvc/llvm-project?rev=331270&view=rev
Log:
Remove redundant command.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
Modified:
lldb/trunk/packages/Py
labath created this revision.
labath added reviewers: davide, zturner, asmith, JDevlieghere, clayborg.
Herald added subscribers: aprantl, mgorny.
Herald added a reviewer: alexshap.
lldb-test already had the ability to dump all symbol information in a
module. This is interesting, but it can be too
Author: jdevlieghere
Date: Tue May 1 09:19:48 2018
New Revision: 331277
URL: http://llvm.org/viewvc/llvm-project?rev=331277&view=rev
Log:
[lit] Replace generator expressions in lit.site.cfg
The lit site configuration for the test suite can contain generator
expressions such as $ that need to be
Good catch
> On May 1, 2018, at 1:19 AM, Pavel Labath via Phabricator
> wrote:
>
> labath added inline comments.
>
>
>
> Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:317
> void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) {
> if (m_die_array.size
clayborg added a subscriber: jankratochvil.
clayborg added a comment.
Good catch
Repository:
rL LLVM
https://reviews.llvm.org/D40470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
zturner added inline comments.
Comment at: lit/CMakeLists.txt:32
+if(TARGET lld)
+ list(APPEND LLDB_TEST_DEPS lld)
+ set(LLDB_HAVE_LLD 1)
Note that this depends on lld having had its own `CMakeLists.txt` file
processed before LLDB's. I think this happens by a
On Wed, Apr 25, 2018 at 9:19 AM Adrian Prantl wrote:
>
> On Apr 25, 2018, at 9:08 AM, Zachary Turner wrote:
>
> But is there a reason why that is more valuable with LLDB than it is with
> LLVM? In LLVM when a test fails it stops and doesn't run subsequent run
> lines. So you have the same issu
Author: jdevlieghere
Date: Tue May 1 10:08:09 2018
New Revision: 331285
URL: http://llvm.org/viewvc/llvm-project?rev=331285&view=rev
Log:
Revert "[lit] Replace generator expressions in lit.site.cfg"
Using GENERATE breaks generators that support multiple configurations,
e.g. MSVC. Reverting for n
lemo updated this revision to Diff 144751.
lemo marked 5 inline comments as done.
https://reviews.llvm.org/D46292
Files:
include/lldb/Core/Module.h
include/lldb/Core/ModuleSpec.h
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
packages/Python/ll
lemo added a comment.
Thanks for the feedback. I uploaded a new revision (incorporating some of the
feedback, including an ELF test case)
Comment at: include/lldb/Core/Module.h:779
+ //--
+ void SetUUID(const ll
labath added inline comments.
Comment at: include/lldb/Core/Module.h:779
+ //--
+ void SetUUID(const lldb_private::UUID &uuid);
+
lemo wrote:
> labath wrote:
> > amccarth wrote:
> > > Was there no
lemo added inline comments.
Comment at: include/lldb/Core/Module.h:779
+ //--
+ void SetUUID(const lldb_private::UUID &uuid);
+
labath wrote:
> lemo wrote:
> > labath wrote:
> > > amccarth wrote:
>
lemo updated this revision to Diff 144790.
https://reviews.llvm.org/D46292
Files:
include/lldb/Core/Module.h
include/lldb/Core/ModuleSpec.h
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
packages/Python/lldbsuite/test/functionalities/postmortem
JDevlieghere created this revision.
JDevlieghere added reviewers: stella.stamenova, zturner, davide.
Herald added subscribers: jkorous, mgorny.
Because we can't expand generator expressions for the lit tests, we need to set
the path to the debugserver in the `_STR` variable so it's expanded prope
JDevlieghere added inline comments.
Comment at: test/CMakeLists.txt:129
if(LLDB_BUILD_FRAMEWORK)
list(APPEND LLDB_TEST_COMMON_ARGS --framework $)
endif()
We'll have to do the same thing here, but the debugserver is more pressing as
it's keeping GreenDragon
stella.stamenova added inline comments.
Comment at: test/CMakeLists.txt:138
if(CMAKE_HOST_APPLE)
- list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH})
+ if (DEBUGSERVER_PATH STREQUAL "$")
+list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})
Author: jmolenda
Date: Tue May 1 15:49:01 2018
New Revision: 331315
URL: http://llvm.org/viewvc/llvm-project?rev=331315&view=rev
Log:
Fix the .experimental. settings feature so that we don't return an error
if an experimental setting has been removed/is missing.
Add tests for the .experimental.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331315: Fix the .experimental. settings feature so that we
don't return an error (authored by jmolenda, committed by ).
C
JDevlieghere added inline comments.
Comment at: test/CMakeLists.txt:138
if(CMAKE_HOST_APPLE)
- list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH})
+ if (DEBUGSERVER_PATH STREQUAL "$")
+list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})
stella.stamenova added inline comments.
Comment at: test/CMakeLists.txt:138
if(CMAKE_HOST_APPLE)
- list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH})
+ if (DEBUGSERVER_PATH STREQUAL "$")
+list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})
Author: rsmith
Date: Tue May 1 19:43:22 2018
New Revision: 331323
URL: http://llvm.org/viewvc/llvm-project?rev=331323&view=rev
Log:
Update lldb to match clang r331244 (addition of char8_t).
Also fix misclassification of char16_t and char32_t: these are unsigned types,
not signed types.
Modified
alur updated this revision to Diff 144834.
alur edited the summary of this revision.
alur added a comment.
Since there was some changes to the file during the last couple of days I've
updated the patches to be against HEAD again.
https://reviews.llvm.org/D45628
Files:
packages/Python/lldbsui
27 matches
Mail list logo
