[Lldb-commits] [PATCH] D45703: Use a utility function to speed up "process load image" for POSIX Platforms

labath added inline comments. Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:1166 + // The dlopen succeeded! + if (token != 0x0) +return process->AddImageToken(token); jingham wrote: > labath wrote: > > Use LLDB_INVALID_IMAGE_TOKEN here? > That

[Lldb-commits] [lldb] r330247 - Report more precise error message when attach fails

Author: labath Date: Wed Apr 18 04:56:21 2018 New Revision: 330247 URL: http://llvm.org/viewvc/llvm-project?rev=330247&view=rev Log: Report more precise error message when attach fails Summary: If the remote stub sends a specific error message instead of just a E?? code, we can use this to displa

[Lldb-commits] [PATCH] D45573: Report more precise error message when attach fails

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL330247: Report more precise error message when attach fails (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg accepted this revision. clayborg added a comment. Very nice! https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Some minor comments, almost ready to go. Do you have commit access or you need somebody to push this on your behalf? Comment at: packages/Python/lldbsuite/test/li

[Lldb-commits] [lldb] r330275 - [LIT] Have lit run the lldb test suite

Author: jdevlieghere Date: Wed Apr 18 10:08:49 2018 New Revision: 330275 URL: http://llvm.org/viewvc/llvm-project?rev=330275&view=rev Log: [LIT] Have lit run the lldb test suite This is the first in what will hopefully become a series of patches to replace the driver logic in dotest.py with LIT.

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rL330275: [LIT] Have lit run the lldb test suite (authored by JDevlieghere, committed by ). Herald added a subscriber: jkorous. Changed prior to commit: https://reviews.llvm.org/D45333?vs=142028&id=142958

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

lemo updated this revision to Diff 142960. https://reviews.llvm.org/D45700 Files: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py source/Commands/CommandObjectTarge

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

lemo marked an inline comment as done. lemo added a comment. In https://reviews.llvm.org/D45700#1070491, @amccarth wrote: > LGTM, but consider highlighting the side effect to `target` when the factory > makes a Placeholder module. Good observation: taking a step back, the factory introduces to

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 142962. https://reviews.llvm.org/D45628 Files: packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile packages/Python/lldbsuite/test/linux/compressed-debug-info/TestCompressedDebugInfo.py packages/Python/lldbsuite/test/linux/compressed-debug-

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur marked 3 inline comments as done. alur added a comment. Thank you, I do need someone to push this on my behalf. https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

lemo added subscribers: amccarth, clayborg, labath, zturner. lemo marked an inline comment as done. lemo added a comment. Greg/Pavel, does the latest revision look good to you? Thanks! https://reviews.llvm.org/D45700 ___ lldb-commits mailing list ll

Re: [Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

Greg/Pavel, does the latest revision look good to you? Thanks! On Wed, Apr 18, 2018 at 10:31 AM, Leonard Mosescu via Phabricator < revi...@reviews.llvm.org> wrote: > lemo marked an inline comment as done. > lemo added a comment. > > In https://reviews.llvm.org/D45700#1070491, @amccarth wrote: > >

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

amccarth accepted this revision. amccarth added a comment. I actually preferred the factory solution. What I intended to express is that the modification of the target doesn't seems like it should be inside the PlaceholderModule class, so whether you use a factory or not doesn't really address

[Lldb-commits] [lldb] r330302 - Improve LLDB's handling of non-local minidumps

Author: lemo Date: Wed Apr 18 16:10:46 2018 New Revision: 330302 URL: http://llvm.org/viewvc/llvm-project?rev=330302&view=rev Log: Improve LLDB's handling of non-local minidumps Normally, LLDB is creating a high-fidelity representation of a live process, including a list of modules and sections,

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

This revision was automatically updated to reflect the committed changes. Closed by commit rL330302: Improve LLDB's handling of non-local minidumps (authored by lemo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45700?vs=142960&id=1

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

clayborg added a comment. LGTM Repository: rL LLVM https://reviews.llvm.org/D45700 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits