[Lldb-commits] [lldb] r328693 - gdb-remote: Fix checksum verification for messages with escape chars

Author: labath Date: Wed Mar 28 03:19:10 2018 New Revision: 328693 URL: http://llvm.org/viewvc/llvm-project?rev=328693&view=rev Log: gdb-remote: Fix checksum verification for messages with escape chars Summary: We've had a mismatch in the checksum computation between the sender and receiver. The

[Lldb-commits] [PATCH] D44922: gdb-remote: Fix checksum verification for messages with escape chars

This revision was automatically updated to reflect the committed changes. Closed by commit rL328693: gdb-remote: Fix checksum verification for messages with escape chars (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [lldb] r328715 - Explicitly import subprocess

Author: jingham Date: Wed Mar 28 10:06:23 2018 New Revision: 328715 URL: http://llvm.org/viewvc/llvm-project?rev=328715&view=rev Log: Explicitly import subprocess For some reason on one of our bots subprocess wasn't already imported. Do so explicitly. Modified: lldb/trunk/packages/Python/ll

[Lldb-commits] [lldb] r328721 - Revert r328715. Wasn't wrong, just not the issue.

Author: jingham Date: Wed Mar 28 11:05:43 2018 New Revision: 328721 URL: http://llvm.org/viewvc/llvm-project?rev=328721&view=rev Log: Revert r328715. Wasn't wrong, just not the issue. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py Modified: lldb

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

kbaladurin created this revision. kbaladurin added a reviewer: clayborg. kbaladurin added a project: LLDB. Herald added subscribers: llvm-commits, kristof.beyls, arichardson, emaste. ObjectFileELF assumes that code section has ".text" name. There is an exception for kalimba toolchain that can use

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This needs a testcase. Repository: rL LLVM https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

clayborg added a comment. Quick test case where we have an ELF file with a .text section and with another executable section with something in it that we can set breakpoints in. Easiest to make an ELF file that fits the bill, and then run obj2yaml on it. You check that into a test case director

[Lldb-commits] [PATCH] D45011: Prevent double release of mach ports

friss created this revision. friss added a reviewer: jasonmolenda. When a MIG routine returns KERN_FAILURE, the demux function will release any OOL resources like ports. In this case, task_port and thread_port will be released twice, potentially resulting in use after free of the ports. I don't

[Lldb-commits] [PATCH] D45011: Prevent double release of mach ports

jingham added a comment. Yes, this is one of the required MIG functions, but it isn't the flavor we register to receive callbacks on (we pass EXCEPTION_DEFAULT to task_set_exception_ports), so this function should never get called. That makes it doubly hard to test! https://reviews.llvm.org/

[Lldb-commits] [PATCH] D45011: Prevent double release of mach ports

davide added a comment. I'm not particularly worried about testing double-free behavior, FWIW. Ideally we should, but, I really understand it's a PITA. I think we might get this for free when testing msan/asan (or just running under valgrind), assuming there was already coverage for this path. (

[Lldb-commits] [PATCH] D45011: Prevent double release of mach ports

jingham added a comment. Because of the mysteries of MIG, all the flavors of catch_exception_raise have to be defined, but you register for a particular flavor when you set the task exception ports. This isn't the flavor we register. So this function is necessary but never used. https://rev

[Lldb-commits] [PATCH] D45011: Prevent double release of mach ports

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. valgrind/asan/msan aren't going to help - this is a pretty obscure stuff. We could verify by hand that we're not leaking a port if this code was actually executed via lsmp(1) on m

[Lldb-commits] [lldb] r328761 - Prevent double release of mach ports

Author: friss Date: Wed Mar 28 20:49:41 2018 New Revision: 328761 URL: http://llvm.org/viewvc/llvm-project?rev=328761&view=rev Log: Prevent double release of mach ports Summary: When a MIG routine returns KERN_FAILURE, the demux function will release any OOL resources like ports. In this case, t

[Lldb-commits] [PATCH] D45011: Prevent double release of mach ports

This revision was automatically updated to reflect the committed changes. Closed by commit rL328761: Prevent double release of mach ports (authored by friss, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45011 Files: lldb/trunk/source