[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

2018-03-11 Thread Johan Engelen via Phabricator via lldb-commits
johanengelen added inline comments. Comment at: source/Plugins/Language/D/DLanguage.cpp:108 + +auto fun0=lib2->getFun("d_initialize"); +(*fun0)(); timotheecour wrote: > johanengelen wrote: > > Would it help to initialize druntime using a static module con

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

2018-03-11 Thread Johan Engelen via Phabricator via lldb-commits
johanengelen added a comment. In https://reviews.llvm.org/D44321#1034141, @timotheecour wrote: > > It's a little more complicated for D because it's an out-of-tree compiler > > so it poses interesting challenges. > > the demangling itself is thoroughly tested in > https://github.com/dlang/drunt

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

2018-03-11 Thread Johan Engelen via Phabricator via lldb-commits
johanengelen added a comment. In https://reviews.llvm.org/D44321#1034168, @johanengelen wrote: > extern "C" char* lldbd_demangle(size_t length, const char* mangled) { > if (mangled == "_D3fooFZv") // pseudo code > return "void foo()"; > else > return mangled; > } >

[Lldb-commits] [PATCH] D40473: DWZ 08/11: Adjust existing code for the DWZ support.

2018-03-11 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 137962. jankratochvil added a comment. bugfix https://reviews.llvm.org/D40473 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp sour

[Lldb-commits] [PATCH] D40466: DWZ 01/11: DWARFUnit split out of DWARFCompileUnit

2018-03-11 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 137961. jankratochvil added a comment. bugfix https://reviews.llvm.org/D40466 Files: source/Plugins/SymbolFile/DWARF/CMakeLists.txt source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h source/

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

2018-03-11 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 137963. jankratochvil added a comment. > I have implemented dwz category like gmodules but even when checkDWZSupport > makes configuration.skipCategories.append("dwz") the DWZ-variants of tests > are still being run. I will investigate it more. This i

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

2018-03-11 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. ping: Are there more comments how to make this whole patchset accepted upstream? Thanks. https://reviews.llvm.org/D40474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/