labath added a comment.
Pretty close, just a couple of style issues.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:62
if (!valobj_backend_sp)
-return false;
+return NULL;
nullptr.
Comment at: source/Plu
For the record, our bots don't run any of the lldb-mi tests. I don't know
if it is an issue with pexpect, the way we are using, or genuine issues,
but I found pretty much all of lldb-mi tests flaky, and it's code too hairy
to understand what is going on.
On Mon, 5 Mar 2018 at 20:19, Vedant Kumar
JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, jasonmolenda, labath.
Herald added a subscriber: llvm-commits.
The OS plugins might have updated the thread list after a core file has
been loaded. The physical thread in the core file may no longer be the
one that should b
labath added a comment.
I don't know much about OS plugins, but I don't see a reason why this would be
mach-specific (so yes, it should probably be done for elf cores as well). Oh,
and we also have windows minidumps, but I'm not sure if it should be up to you
to update all of these (I'm saying
Author: labath
Date: Tue Mar 6 03:54:41 2018
New Revision: 326775
URL: http://llvm.org/viewvc/llvm-project?rev=326775&view=rev
Log:
[LLDB][PPC64] Fixed issues with expedited registers
Summary:
- reg_nums were missing the end marker entry
- marked FP test to be skipped for ppc64
Reviewers: labat
alexandreyy updated this revision to Diff 137153.
alexandreyy added a comment.
Changed NULL pointer
https://reviews.llvm.org/D44015
Files:
source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
Index: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
===
Author: labath
Date: Tue Mar 6 04:46:05 2018
New Revision: 326777
URL: http://llvm.org/viewvc/llvm-project?rev=326777&view=rev
Log:
HostThreadPosix::Cancel: remove android-specific implementation
Noone is calling this function on android, so we can just use the
generic llvm_unreachable "implemen
labath added a comment.
Since the android part wasn't obviously NFC, I figured I should be the one to
do it. And since the pthread_cancel is not available on android, I've had to
add the #else clause as well, which should fix the unreachable warning as well.
So I guess you could say this got co
labath added a comment.
I agree we should move things to the cpp file when possible, and this is
possible. I'm going to update the patch before committing. Thanks for the
review.
https://reviews.llvm.org/D44074
___
lldb-commits mailing list
lldb-c
labath added a comment.
In https://reviews.llvm.org/D42955#1027142, @clayborg wrote:
> Again, we need any objects coming out of the ObjectFile to have the correct
> sections. Not sure how we would accomplish that with a solution where the
> dSYM file uses it own useless sections.
I think we h
Author: labath
Date: Tue Mar 6 05:53:26 2018
New Revision: 326791
URL: http://llvm.org/viewvc/llvm-project?rev=326791&view=rev
Log:
ObjectFileMachO: split CreateSections mega-function into more manageable chunks
Summary:
In an effort to understand the function's operation, I've split it into log
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326791: ObjectFileMachO: split CreateSections mega-function
into more manageable chunks (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
clayborg added a comment.
Change looks fine to me.
> What's the best/easiest way to test this?
You can just run:
(lldb) process save-core /tmp/test.core"
This will allow you to take any process and save a core file for it from lldb.
Then you could obj2yaml it and check that part in. This is
JDevlieghere planned changes to this revision.
JDevlieghere added a comment.
Alright, sounds good. Thank you both for the help!
Repository:
rL LLVM
https://reviews.llvm.org/D44139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
alexandreyy added a comment.
Thanks, @labath @clayborg .
@labath Could you please commit this patch?
https://reviews.llvm.org/D44015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
Author: labath
Date: Tue Mar 6 07:56:20 2018
New Revision: 326805
URL: http://llvm.org/viewvc/llvm-project?rev=326805&view=rev
Log:
Rewrite TestTargetSymbolsBuildidCase to be more focused
Summary:
The test was failing in remote debugging scenario with windows as a host
as cmd.exe is not able to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326805: Rewrite TestTargetSymbolsBuildidCase to be more
focused (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42914?vs=
labath added a comment.
Ok, as of r326805 it should be very easy to write a test for this. You can look
at the test in that commit for inspiration.
Btw, do you happen to know why we have two copies of the section merging code?
While working on that patch I noticed an issue that is caused (in pa
labath created this revision.
labath added reviewers: fjricci, jankratochvil.
Herald added subscribers: arichardson, emaste.
Besides being superfluous, this double merging was actually wrong and
causing some sections to be added twice. The reason for that was that
the code assumes sectoin IDs are
labath created this revision.
labath added a reviewer: aprantl.
Herald added subscribers: mehdi_amini, ki.stfu.
The changes here fall into several categories.
- some tests were redirecting inferior stdout/err to a file. For these I make
sure we use an absolute path for the file. I also create a
asmith created this revision.
asmith added reviewers: zturner, lldb-commits, rnk.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44164
Files:
lit/SymbolFile/PDB/enums-layout.test
source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
Index: source/Plugins/
asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.
- Remove unused code
- Adding `break` statement conditionally
- Ignore empty strings in FindTypeByName
Repository:
rL LLVM
https://reviews.llvm.org/D44165
Files:
sou
asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44166
Files:
source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
Index: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
===
clayborg added a comment.
Test?
Repository:
rL LLVM
https://reviews.llvm.org/D44166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.
- Complete element type of PDBSymbolTypeArray.
- Add a test to check types of multi-dimensional array and pointers with CVR.
Repository:
rL LLVM
https://reviews.llvm.org
zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:499
auto type_list = GetTypeList();
-type_list->Insert(result);
+if (type_list)
+ type_lis
Author: adrian
Date: Tue Mar 6 15:25:04 2018
New Revision: 326847
URL: http://llvm.org/viewvc/llvm-project?rev=326847&view=rev
Log:
Add test for lldb-mi interpreter
Test that "lldb-mi --interpreter" can interpret "target list" CLI command.
Patch by Alex Polyakov!
Differential Revision: https:/
Author: jmolenda
Date: Tue Mar 6 15:33:02 2018
New Revision: 326849
URL: http://llvm.org/viewvc/llvm-project?rev=326849&view=rev
Log:
the thread id is easier to read in base16.
Modified:
lldb/trunk/tools/darwin-threads/examine-threads.c
Modified: lldb/trunk/tools/darwin-threads/examine-thre
asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44182
Files:
source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
Index: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
=
asmith marked an inline comment as done.
asmith added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:499
auto type_list = GetTypeList();
-type_list->Insert(result);
+if (type_list)
+ type_list->Insert(result);
zturn
asmith updated this revision to Diff 137324.
asmith added a comment.
Add test
https://reviews.llvm.org/D44166
Files:
lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp
lit/SymbolFile/PDB/typedefs.test
source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
Index: source/Plugins/SymbolFile/PDB/PDBASTP
Lgtm
On Tue, Mar 6, 2018 at 9:14 PM Aaron Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> asmith updated this revision to Diff 137324.
> asmith added a comment.
>
> Add test
>
>
> https://reviews.llvm.org/D44166
>
> Files:
> lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp
> lit/Symbol
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326875: [SymbolFilePDB] Add missing Char16 and Char32 types
in a few places (authored by asmith, committed by ).
Changed
33 matches
Mail list logo
