[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-03-04 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In https://reviews.llvm.org/D32167#1024546, @labath wrote: > I personally don't think having a new debug info flavour is a good idea. > Tests written specifically to test this functionality will be easier to > maintain and debug when they break. And keeping adding

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-03-04 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. In https://reviews.llvm.org/D32167#1026762, @jankratochvil wrote: > In https://reviews.llvm.org/D32167#1024546, @labath wrote: > > > I personally don't think having a new debug info flavour is a good idea. > > Tests written specifically to test this functionality will be

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-03-04 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In https://reviews.llvm.org/D32167#1026779, @davide wrote: > Do you have a way of reproducing? It just happens for me each time - on Fedora 27 x86_64 on 16-core (32HT) 2-node NUMA machine having env var `MAKEFLAGS=-j32` (and `tuned-adm throughput-performance` if

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-03-04 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. In https://reviews.llvm.org/D32167#1026780, @jankratochvil wrote: > In https://reviews.llvm.org/D32167#1026779, @davide wrote: > > > Do you have a way of reproducing? > > > It just happens for me each time - on Fedora 27 x86_64 on 16-core (32HT) > 2-node NUMA machine havi

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-03-04 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In https://reviews.llvm.org/D32167#1026781, @davide wrote: > Any chance you're interested in working on that? Yes, it is in the shortterm or rather midterm plan. https://reviews.llvm.org/D32167 ___ lldb-commits mail

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

2018-03-04 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide. An Obj-C array type _NSCallStackArray is used in NSException backtraces. This patch adds a synthetic frontend for _NSCallStackArray, which now correctly returns frame PCs. https://reviews.llvm.org/D440

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

2018-03-04 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added a comment. The changes for _NSCallStackArray are at https://reviews.llvm.org/D44081. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

2018-03-04 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Host/posix/HostThreadPosix.cpp:44 if (IsJoinable()) { #ifndef __ANDROID__ #ifndef __FreeBSD__ xiaobai wrote: > labath wrote: > > xiaobai wrote: > > > aprantl wrote: > > > > What about: > > > > ``` > > > > #ifd

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

2018-03-04 Thread Alex Langford via Phabricator via lldb-commits
xiaobai added inline comments. Comment at: source/Host/posix/HostThreadPosix.cpp:44 if (IsJoinable()) { #ifndef __ANDROID__ #ifndef __FreeBSD__ labath wrote: > xiaobai wrote: > > labath wrote: > > > xiaobai wrote: > > > > aprantl wrote: > > > > > What about:

[Lldb-commits] [PATCH] D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel

2018-03-04 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Host/posix/HostThreadPosix.cpp:44 if (IsJoinable()) { #ifndef __ANDROID__ #ifndef __FreeBSD__ xiaobai wrote: > labath wrote: > > xiaobai wrote: > > > labath wrote: > > > > xiaobai wrote: > > > > > aprantl wrot