[Lldb-commits] [PATCH] D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL323064: [modules] Fix missing includes/typo in LLDB's includes. [NFC] (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D42355: Cleanup #include "DWARFCompileUnit.h"

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. Herald added subscribers: JDevlieghere, aprantl. Cleanup needless+missing `#include "DWARFCompileUnit.h"` for split of DWARFCompileUnit to DWARFUnit as discussed in https://reviews.llvm.org/D40466. https://rev

[Lldb-commits] [lldb] r323069 - Clean up #include "DWARFCompileUnit.h"

Author: jankratochvil Date: Sun Jan 21 10:03:17 2018 New Revision: 323069 URL: http://llvm.org/viewvc/llvm-project?rev=323069&view=rev Log: Clean up #include "DWARFCompileUnit.h" Clean up needless+missing #include "DWARFCompileUnit.h" for split of DWARFCompileUnit to DWARFUnit as discussed in D40

[Lldb-commits] [PATCH] D42355: Cleanup #include "DWARFCompileUnit.h"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323069: Clean up #include "DWARFCompileUnit.h" (authored by jankratochvil, committed by ). Herald added a subscriber: llvm

[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString

davide added a comment. I'll be happy to review all your patch set tomorrow, Raphael. Do you mind to add me as reviewer so I don't lose track of your work? https://reviews.llvm.org/D42348 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Trivial fixes like this don't need to be reviewed, you can just commit them. Thanks for your work btw! https://reviews.llvm.org/D42345 ___ ll

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

zturner added a comment. Same as with the last one. For obviously correct bug fixes like this, just commit them. As an aside, `make_unique` will make this a bit shorter so it fits on one line. e.g. `auto reg_interface = llvm::make_unique(arch);` https://reviews.llvm.org/D42347 _

[Lldb-commits] [PATCH] D42336: Fix memory leaks in TestArm64InstEmulation

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D42336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rL323075: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [lldb] r323075 - Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex

Author: teemperor Date: Sun Jan 21 22:56:09 2018 New Revision: 323075 URL: http://llvm.org/viewvc/llvm-project?rev=323075&view=rev Log: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex Summary: This fixes a clang warning. Reviewers: zturner Reviewed By: zturner Subscribers: ztu

[Lldb-commits] [lldb] r323076 - Fix memory leaks in TestArm64InstEmulation

Author: teemperor Date: Sun Jan 21 23:22:13 2018 New Revision: 323076 URL: http://llvm.org/viewvc/llvm-project?rev=323076&view=rev Log: Fix memory leaks in TestArm64InstEmulation Summary: We never delete the created instances, so those test fail with the memory sanitizer. Reviewers: jasonmolend

[Lldb-commits] [PATCH] D42336: Fix memory leaks in TestArm64InstEmulation

This revision was automatically updated to reflect the committed changes. Closed by commit rL323076: Fix memory leaks in TestArm64InstEmulation (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42336?vs=130777&id=