Author: labath
Date: Mon Dec 18 01:44:29 2017
New Revision: 320961
URL: http://llvm.org/viewvc/llvm-project?rev=320961&view=rev
Log:
NPL: Clean up handling of inferior exit
Summary:
lldb-server was sending the "exit" packet (W??) twice. This happened
because it was handling both the pre-exit (PTR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320961: NPL: Clean up handling of inferior exit (authored by
labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41069
Files:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessL
Author: labath
Date: Mon Dec 18 02:51:03 2017
New Revision: 320967
URL: http://llvm.org/viewvc/llvm-project?rev=320967&view=rev
Log:
Add LLVMObject dependency to our ObjectFileELF plugin
Modified:
lldb/trunk/source/Plugins/ObjectFile/ELF/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Obj
Author: labath
Date: Mon Dec 18 02:50:59 2017
New Revision: 320966
URL: http://llvm.org/viewvc/llvm-project?rev=320966&view=rev
Log:
Reduce x86 register context boilerplate.
Summary:
The x86 FPR struct was defined as a struct containing a union between
two members: XSAVE and FXSAVE. This patch ma
labath added inline comments.
Comment at: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3496
+
+ auto Decompressor = llvm::object::Decompressor::create(
+ section->GetName().GetStringRef(),
tzik wrote:
> This adds new dependency to LLVM Object
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320966: Reduce x86 register context boilerplate. (authored
by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41245
Files:
lldb/trunk/source/Plugins/Process/Linux/NativeRegiste
Author: labath
Date: Mon Dec 18 03:05:28 2017
New Revision: 320969
URL: http://llvm.org/viewvc/llvm-project?rev=320969&view=rev
Log:
Fix FreeBSD build broken by r320966
Modified:
lldb/trunk/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.cpp
Modified:
lldb/trunk/sourc
Author: labath
Date: Mon Dec 18 06:31:44 2017
New Revision: 320985
URL: http://llvm.org/viewvc/llvm-project?rev=320985&view=rev
Log:
Fix regression in jModulesInfo packet handling
The recent UUID cleanups exposed a bug in the parsing code for the
jModulesInfo response, which was passing wrong val
Author: labath
Date: Mon Dec 18 06:31:39 2017
New Revision: 320984
URL: http://llvm.org/viewvc/llvm-project?rev=320984&view=rev
Log:
llgs: Propagate the environment when launching the inferior from command line
Summary:
We were failing to propagate the environment when lldb-server was
started wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320984: llgs: Propagate the environment when launching the
inferior from command line (authored by labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41070?vs=126367&id=127349#to
labath created this revision.
labath added reviewers: jasonmolenda, clayborg.
Herald added a subscriber: JDevlieghere.
Make sure we propagate environment when starting debugserver with a pre-loaded
inferior. AFAIK, RNBRunLoopLaunchInferior is only called in pre-loaded inferior
scenario, so we can
labath updated this revision to Diff 127358.
labath added a comment.
re-clang-format the patch
https://reviews.llvm.org/D41352
Files:
tools/debugserver/source/debugserver.cpp
unittests/tools/lldb-server/tests/LLGSTest.cpp
Index: unittests/tools/lldb-server/tests/LLGSTest.cpp
=
labath created this revision.
labath added reviewers: zturner, davide, jingham, clayborg.
Herald added subscribers: mgorny, emaste.
There was some confusion in the code about how to represent process
environment. Most of the code (ab)used the Args class for this purpose,
but some of it used a more
zturner added inline comments.
Comment at: include/lldb/Utility/Environment.h:70-72
+ std::pair insert(llvm::StringRef KeyEqValue) {
+return insert(KeyEqValue.split('='));
+ }
Why'd you decide to go with inserting an entire pre-formatted key value pair in
labath marked an inline comment as done.
labath added inline comments.
Comment at: include/lldb/Utility/Environment.h:70-72
+ std::pair insert(llvm::StringRef KeyEqValue) {
+return insert(KeyEqValue.split('='));
+ }
zturner wrote:
> Why'd you decide to go w
labath updated this revision to Diff 127384.
labath added a comment.
re-clang-format the patch
https://reviews.llvm.org/D41359
Files:
include/lldb/API/SBLaunchInfo.h
include/lldb/Host/Host.h
include/lldb/Interpreter/Args.h
include/lldb/Target/Platform.h
include/lldb/Target/ProcessInfo
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:393
// try really hard not to use a regex match.
- bool is_regex = false;
- if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) {
-// Trying to compile an invalid regex
I agree that's better long term, but this code was already there, and the
patch makes things strictly better than before (literally just fixes a
crash in existing code). So I think we can agree that this should be
fixed, but as it's a bigger change I don't think it should hold up fixing a
crash.
clayborg added a comment.
We already have an option for this named "--forward-env". It might be better to
fix this by adding the "--forward-env" argument to the debugserver launch
during testing? When we launch through LLDB, it forwards all environment
variables manually. Maybe we add a "--forw
labath added a comment.
In https://reviews.llvm.org/D41352#958549, @clayborg wrote:
> We already have an option for this named "--forward-env". It might be better
> to fix this by adding the "--forward-env" argument to the debugserver launch
> during testing? When we launch through LLDB, it for
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
ok as long as we don't want to return const reference when returning
Environment values in getters and setters.
Comment at: include/lldb/Target/Platform.h:636
- virtu
ok, good starting point then. We can submit another patch to add the find types
by regex functionality.
Greg
> On Dec 18, 2017, at 9:54 AM, Zachary Turner wrote:
>
> I agree that's better long term, but this code was already there, and the
> patch makes things strictly better than before (lit
clayborg added a comment.
I am ok either way, but I do want to make sure Jason gets input before we do
anything. He might be out for a few weeks over the break, so there might be a
delay.
https://reviews.llvm.org/D41352
___
lldb-commits mailing li
Author: dim
Date: Mon Dec 18 11:46:56 2017
New Revision: 321016
URL: http://llvm.org/viewvc/llvm-project?rev=321016&view=rev
Log:
Fix more inconsistent line endings. NFC.
Modified:
lldb/trunk/www/build.html
lldb/trunk/www/test.html
Modified: lldb/trunk/www/build.html
URL:
http://llvm.or
labath added inline comments.
Comment at: include/lldb/Target/Platform.h:636
- virtual size_t GetEnvironment(StringList &environment);
+ virtual Environment GetEnvironment();
clayborg wrote:
> Do we want to return by value? Not a const reference?
This objec
Author: jmolenda
Date: Mon Dec 18 17:41:47 2017
New Revision: 321051
URL: http://llvm.org/viewvc/llvm-project?rev=321051&view=rev
Log:
Tweak to the debugserver entitlements setup in the xcode project
file. For macos builds specifically, use the macosx entitlements
files; for all other builds, use
jasonmolenda added a comment.
I guess I don't have an opinion on this one. The correct way to pass
environment variables to the inferior is through
SBLaunchInfo::SetEnvironmentEntries or in cmd line lldb, process launch -v
ENV=val. A test that assumes an environment variable set in lldb will
asmith added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:393
// try really hard not to use a regex match.
- bool is_regex = false;
- if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) {
-// Trying to compile an invalid regex co
28 matches
Mail list logo
