Re: [Lldb-commits] [lldb] r319597 - Fix warning in DynamicLoaderDarwinKernel.cpp, NFC

2017-12-02 Thread Davide Italiano via lldb-commits
On Fri, Dec 1, 2017 at 3:53 PM, Vedant Kumar via lldb-commits wrote: > Author: vedantk > Date: Fri Dec 1 15:53:01 2017 > New Revision: 319597 > > URL: http://llvm.org/viewvc/llvm-project?rev=319597&view=rev > Log: > Fix warning in DynamicLoaderDarwinKernel.cpp, NFC > > Modified: > > lldb/tru

Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-02 Thread Davide Italiano via lldb-commits
Maybe we should remove this feature altogether? On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits wrote: > Author: jingham > Date: Fri Dec 1 16:11:18 2017 > New Revision: 319598 > > URL: http://llvm.org/viewvc/llvm-project?rev=319598&view=rev > Log: > Don't use llvm::EnablePrettyStackT

[Lldb-commits] [PATCH] D40757: Disable warnings related to anonymous types

2017-12-02 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, I stumbled upon the same issue :) An alternative would be that of naming (as you suggested), but if this is consistent, no worries. https://reviews.llvm.org/D40757 __

Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-02 Thread Zachary Turner via lldb-commits
I'm curious why it's not working as it's supposed to work on these platforms. When it does work, it's quite helpful On Sat, Dec 2, 2017 at 12:24 PM Davide Italiano wrote: > Maybe we should remove this feature altogether? > > On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits > wrote:

[Lldb-commits] [PATCH] D40466: DWZ 03/12: DWARFCompileUnit split to DWARFCompileUnitData

2017-12-02 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:216 + DWARFCompileUnitData *m_data; + jankratochvil wrote: > clayborg wrote: > > jankratochvil wrote: > > > clayborg wrote: > > > > Is there a reason this is a

Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-02 Thread Zachary Turner via lldb-commits
That said, it does seem to make more sense as something you would do in the main lldb executable, and not in library code. On Sat, Dec 2, 2017 at 12:26 PM Zachary Turner wrote: > I'm curious why it's not working as it's supposed to work on these > platforms. When it does work, it's quite helpfu