On Fri, Dec 1, 2017 at 3:53 PM, Vedant Kumar via lldb-commits
wrote:
> Author: vedantk
> Date: Fri Dec 1 15:53:01 2017
> New Revision: 319597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319597&view=rev
> Log:
> Fix warning in DynamicLoaderDarwinKernel.cpp, NFC
>
> Modified:
>
> lldb/tru
Maybe we should remove this feature altogether?
On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits
wrote:
> Author: jingham
> Date: Fri Dec 1 16:11:18 2017
> New Revision: 319598
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319598&view=rev
> Log:
> Don't use llvm::EnablePrettyStackT
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM, I stumbled upon the same issue :)
An alternative would be that of naming (as you suggested), but if this is
consistent, no worries.
https://reviews.llvm.org/D40757
__
I'm curious why it's not working as it's supposed to work on these
platforms. When it does work, it's quite helpful
On Sat, Dec 2, 2017 at 12:24 PM Davide Italiano
wrote:
> Maybe we should remove this feature altogether?
>
> On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits
> wrote:
jankratochvil added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:216
+ DWARFCompileUnitData *m_data;
+
jankratochvil wrote:
> clayborg wrote:
> > jankratochvil wrote:
> > > clayborg wrote:
> > > > Is there a reason this is a
That said, it does seem to make more sense as something you would do in the
main lldb executable, and not in library code.
On Sat, Dec 2, 2017 at 12:26 PM Zachary Turner wrote:
> I'm curious why it's not working as it's supposed to work on these
> platforms. When it does work, it's quite helpfu