[Lldb-commits] [PATCH] D40311: elf-core: Split up parsing code into os-specific functions

2017-11-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:735 /// (see ELFNote structure) /// 3) A Thread Context in a core file usually described by 3 NOTE entries. ///a) NT_PRSTATUS - Register context krytarowski wrot

[Lldb-commits] [PATCH] D40311: elf-core: Split up parsing code into os-specific functions

2017-11-22 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 123898. labath added a comment. Update comments. https://reviews.llvm.org/D40311 Files: source/Plugins/Process/elf-core/ProcessElfCore.cpp source/Plugins/Process/elf-core/ProcessElfCore.h source/Plugins/Process/elf-core/ThreadElfCore.cpp source/Plugi

[Lldb-commits] [PATCH] D40311: elf-core: Split up parsing code into os-specific functions

2017-11-22 Thread Mark Kettenis via Phabricator via lldb-commits
kettenis added a comment. Looks like a good improvement to me. https://reviews.llvm.org/D40311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40022: Remove extra minuses from command option

2017-11-22 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 123942. tatyana-krasnukha retitled this revision from "Corrected two typos and removed unused variable" to "Remove extra minuses from command option". tatyana-krasnukha edited the summary of this revision. tatyana-krasnukha added a comment. Things t

[Lldb-commits] [PATCH] D40022: Remove extra minuses from command option

2017-11-22 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 123953. tatyana-krasnukha added a comment. Made diff with full paths (studying to use arcanist)... Repository: rL LLVM https://reviews.llvm.org/D40022 Files: source/Commands/CommandObjectTarget.cpp Index: source/Commands/CommandObjectTarget

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

2017-11-22 Thread Nelson Elhage via Phabricator via lldb-commits
nelhage updated this revision to Diff 124018. nelhage added a comment. Add a test case. Verified that it passes on my machine and fails with this patch reverted. https://reviews.llvm.org/D40283 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsuite/test/expression_command/i

[Lldb-commits] [lldb] r318886 - Run clang-format on source/Host/common/Symbols.cpp

2017-11-22 Thread Stephane Sezer via lldb-commits
Author: sas Date: Wed Nov 22 15:56:32 2017 New Revision: 318886 URL: http://llvm.org/viewvc/llvm-project?rev=318886&view=rev Log: Run clang-format on source/Host/common/Symbols.cpp I saw a bunch of style errors so this fixes them. Modified: lldb/trunk/source/Host/common/Symbols.cpp Modified

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

2017-11-22 Thread Nelson Elhage via Phabricator via lldb-commits
nelhage updated this revision to Diff 124019. nelhage added a comment. Remove accidentally-added flycheck file. https://reviews.llvm.org/D40283 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsuite/test/expression_command/issue_35310/ packages/Python/lldbsuite/test/expres