labath added a comment.
In https://reviews.llvm.org/D40133#927655, @krytarowski wrote:
> I'm just thinking whether change code like `CoreRegset::PPC_VMX` to
> `CoreRegset::PPC::VMX`. I'm planning to add `CoreRegset::X86_64::XSAVE` in
> future.
That's an interesting idea, but I don't see how w
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:58
+enum class CoreRegset : uint8_t { GPR, FPR, PPC_VMX, PPC_VSX };
+
Seems weird to have PPC_VMX and PPC_VSX define in a CoreRegSet? Do these need
to be specific for
It would be great if we could eventually just use llvm-tblgen to generate
all these register definitions.
On Fri, Nov 17, 2017 at 9:54 AM Greg Clayton via Phabricator via
lldb-commits wrote:
> clayborg added inline comments.
>
>
>
> Comment at: source/Plugins/Process/elf-core/el
Author: alexshap
Date: Fri Nov 17 12:50:54 2017
New Revision: 318554
URL: http://llvm.org/viewvc/llvm-project?rev=318554&view=rev
Log:
[lldb] Ensure that dwo/dwp are not double-indexed
DWO/DWP should not be indexed directly.
Instead, the corresponding base file should be used.
This diff adds an a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318554: [lldb] Ensure that dwo/dwp are not double-indexed
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D39825?vs=122389&id=123403#toc
Repository:
rL LLVM
https://reviews
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:58
+enum class CoreRegset : uint8_t { GPR, FPR, PPC_VMX, PPC_VSX };
+
clayborg wrote:
> Seems weird to have PPC_VMX and PPC_VSX define in a CoreRegSet? Do these need
> t
A few notes on this change.
> On Oct 27, 2017, at 2:22 PM, Davide Italiano via lldb-commits
> wrote:
>
> Author: davide
> Date: Fri Oct 27 14:22:57 2017
> New Revision: 316800
>
> URL: http://llvm.org/viewvc/llvm-project?rev=316800&view=rev
> Log:
> [CMake] Build clang as dependency when using
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:58
+enum class CoreRegset : uint8_t { GPR, FPR, PPC_VMX, PPC_VSX };
+
labath wrote:
> clayborg wrote:
> > Seems weird to have PPC_VMX and PPC_VSX define in a CoreRegSet
The issue with the generator expressions is that they are expanded in
only in specific target properties, and here we need them to be
expanded in configure_lit_site_cfg. If you know the right incantation
to make that happen, then please let me know.
Deriving the c++ compiler name is a bit tricky,
Author: davide
Date: Fri Nov 17 16:34:09 2017
New Revision: 318576
URL: http://llvm.org/viewvc/llvm-project?rev=318576&view=rev
Log:
[Core] Garbage collect dead code untouched in years. NFCI.
This sketching can be resurrected if anybody needs it, although
I doubt is relevant these days.
Modified
Author: davide
Date: Fri Nov 17 16:35:27 2017
New Revision: 318577
URL: http://llvm.org/viewvc/llvm-project?rev=318577&view=rev
Log:
[ABI/SysV] Remove more dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp
Modified: lldb/trunk/source/Plugins/ABI/SysV-x86
Author: davide
Date: Fri Nov 17 16:52:29 2017
New Revision: 318579
URL: http://llvm.org/viewvc/llvm-project?rev=318579&view=rev
Log:
[Module] Throw away some more commented code. NFCI.
Modified:
lldb/trunk/source/Core/Module.cpp
Modified: lldb/trunk/source/Core/Module.cpp
URL:
http://llvm.o
Author: davide
Date: Fri Nov 17 16:54:31 2017
New Revision: 318580
URL: http://llvm.org/viewvc/llvm-project?rev=318580&view=rev
Log:
[ABI] Remove dead code that was copy-pasted all around. NFCI.
Modified:
lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp
lldb/trunk/source/Plugins/ABI
13 matches
Mail list logo
