labath marked an inline comment as done.
labath added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:62
+
+ m_bool_type =
m_backend.GetCompilerType().GetBasicTypeFromAST(eBasicTypeBool);
+ m_elements.assign(size, ValueObjectSP());
-
Author: labath
Date: Tue Nov 14 03:15:03 2017
New Revision: 318145
URL: http://llvm.org/viewvc/llvm-project?rev=318145&view=rev
Log:
Add a data formatter for libc++ std::bitset
Reviewers: jingham, EricWF
Subscribers: mgorny, lldb-commits
Differential Revision: https://reviews.llvm.org/D39966
A
This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL318145: Add a data formatter for libc++ std::bitset
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D39966?vs=122685&id=122808#toc
Repos
tatyana-krasnukha created this revision.
Herald added a subscriber: ki.stfu.
+ clang-format
Repository:
rL LLVM
https://reviews.llvm.org/D40022
Files:
include/lldb/Core/Architecture.h
source/Commands/CommandObjectTarget.cpp
source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
tatyana-krasnukha added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:2589
"Write file contents to the memory.", false, true),
-m_pc_option(LLDB_OPT_SET_1, false, "--set-pc-to-entry", 'p',
"Set PC to the e
Propose to enable libxml2 support for Windows. I've built sources from
https://git.gnome.org/browse/libxml2 and successfully used lldb with it (in
part of parsing target.xml in ProcessGDBRemote).
LLDBConfig.cmake.LibXml.patch
Description: LLDBConfig.cmake.LibXml.patch
__
clayborg added a comment.
I believe we normally just clang format the changes. This is done with:
svn diff --diff-cmd=diff -x-U0 |
$llvm_src/llvm/tools/clang/tools/clang-format/clang-format-diff.py -i -binary
$llvm_build/bin/clang-format
git diff -U0 HEAD^ |
$llvm_src/llvm/tools/clang/tool
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Before working on a file for a diff you will submit, clang format it first, and
then check it in. No need for review on clang format only changes.
So please clang format first an
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please clang format and check in without any changes to the functionality and
then make a patch that only has your functional changes.
Repository:
rL LLVM
https://reviews.llv
clayborg accepted this revision.
clayborg added a comment.
The "--set-pc-to-entry" change is fine. No need for review when removing unused
variables or clang formatting, but it would be nice to do those commits
separately.
Repository:
rL LLVM
https://reviews.llvm.org/D40022
_
Author: dhinton
Date: Tue Nov 14 10:19:41 2017
New Revision: 318164
URL: http://llvm.org/viewvc/llvm-project?rev=318164&view=rev
Log:
Add check for self-assignment. NFC
Differential Revision: https://reviews.llvm.org/D39578
Modified:
lldb/trunk/source/Core/RegisterValue.cpp
lldb/trunk/s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318164: Add check for self-assignment. NFC (authored by
dhinton).
Repository:
rL LLVM
https://reviews.llvm.org/D39578
Files:
lldb/trunk/source/Core/RegisterValue.cpp
lldb/trunk/source/Core/Value.
alexandreyy updated this revision to Diff 122872.
alexandreyy added a comment.
Fixed backtrace issue.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmortem/elf-co
alexandreyy added a comment.
In https://reviews.llvm.org/D39681#920349, @labath wrote:
> I'm not sure what's the problem with backtracing without more info, but the
> nice thing about core files is that you can open a ppc and x86 one side by
> side and see how for do you get before things start
alexandreyy updated this revision to Diff 122879.
alexandreyy added a comment.
Removed issue note from commit message.
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
No namespace here?
https://reviews.llvm.org/D39681
___
alexandreyy added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
krytarowski wrote:
> No namespace here?
I think these constants are used for multiple O
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
alexandreyy wrote:
> krytarowski wrote:
> > No namespace here?
> I think these constant
alexandreyy added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
krytarowski wrote:
> alexandreyy wrote:
> > krytarowski wrote:
> > > No namespace here?
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14
+/// Core files PT_NOTE segment descriptor types
+enum {
+ NT_PRSTATUS = 1,
alexandreyy wrote:
> krytarowski wrote:
> > alexandreyy wrote:
> > > krytarowski wrote:
Author: jmolenda
Date: Tue Nov 14 15:15:35 2017
New Revision: 318218
URL: http://llvm.org/viewvc/llvm-project?rev=318218&view=rev
Log:
Update xcode project file to track ArchSpec.cpp
move and LibCxxBitset.cpp addition.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/
Author: jmolenda
Date: Tue Nov 14 19:18:24 2017
New Revision: 318260
URL: http://llvm.org/viewvc/llvm-project?rev=318260&view=rev
Log:
Two small fixes to handle arm64 fpu register contexts in
a Mach-O file load command correctly, patch by Ryan
Mansfield.
Modified:
lldb/trunk/source/Plugin
Author: jmolenda
Date: Tue Nov 14 19:41:47 2017
New Revision: 318262
URL: http://llvm.org/viewvc/llvm-project?rev=318262&view=rev
Log:
Roll back r318260 because it is causing the windows bot to
break. The alignas(__uint128_t) is not recognized with MSVC
it looks like. Zachary, is there a similar
tatyana-krasnukha updated this revision to Diff 122966.
tatyana-krasnukha added a comment.
Sorry for wrong formatting, I've removed it.
What I've actually done:
- grouped cases returning WriteMemoryPrivate in the top of function;
- moved last comment to code it relates;
- change other comment ac
tatyana-krasnukha updated this revision to Diff 122967.
tatyana-krasnukha added a comment.
Removed clang-format changes.
Repository:
rL LLVM
https://reviews.llvm.org/D39969
Files:
source/Symbol/ObjectFile.cpp
Index: source/Symbol/ObjectFile.cpp
===
tatyana-krasnukha added a comment.
I have not commit access, that is why I've decided to group all typos in one
patch...
Repository:
rL LLVM
https://reviews.llvm.org/D40022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
26 matches
Mail list logo
