[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

2017-10-09 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added inline comments. Comment at: source/Host/common/Symbols.cpp:288-294 + // FIXME: at the moment llvm-dwp doesn't output build ids, + // nor does binutils dwp. Thus in the case of DWPs + // we skip uuids check. This needs to b

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

2017-10-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Looks good. Would be nice to add support for byte sizes of 3, 5 and 7 to the unchecked version as noted in inline comments, or remove the function if no one is using this function. Just a few quick fixes and this will be good to go. Comment at: sourc

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

2017-10-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: source/Host/common/Symbols.cpp:288-294 + // FIXME: at the moment llvm-dwp doesn't output build ids, + // nor does binutils dwp. Thus in the case of DWPs + // we skip uuids check. This needs to be f

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

2017-10-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Sorry for the delay, I was out on vacation for a week. Repository: rL LLVM https://reviews.llvm.org/D38323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

2017-10-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. (sorry for the delay, I was out on vacation for a week) Repository: rL LLVM https://reviews.llvm.org/D38568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] r315221 - Update ABISysV_arm64::RegisterIsVolatile to accept registers prefixed with r

2017-10-09 Thread Stephane Sezer via lldb-commits
Author: sas Date: Mon Oct 9 10:49:32 2017 New Revision: 315221 URL: http://llvm.org/viewvc/llvm-project?rev=315221&view=rev Log: Update ABISysV_arm64::RegisterIsVolatile to accept registers prefixed with r Summary: While the specification says that the 64bit registers are prefixed with `x`, it s

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

2017-10-09 Thread Alexander Shaposhnikov via Phabricator via lldb-commits
alexshap updated this revision to Diff 118250. alexshap added a comment. Ignore the UUID comparison if the UUID field is not valid (in this case the interface seems to be a bit cleaner (module_spec is the single source of truth (without extra parameters)) Repository: rL LLVM https://reviews

[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

2017-10-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM https://reviews.llvm.org/D38568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv