[Lldb-commits] [lldb] r307009 - Use llvm::sys::RetryAfterSignal instead of a manual while errno!=EINTR loop

Author: labath Date: Mon Jul 3 02:25:55 2017 New Revision: 307009 URL: http://llvm.org/viewvc/llvm-project?rev=307009&view=rev Log: Use llvm::sys::RetryAfterSignal instead of a manual while errno!=EINTR loop Reviewers: zturner, eugene, krytarowski Subscribers: emaste, mgorny, lldb-commits Diff

[Lldb-commits] [lldb] r307018 - Fix typo/unbreak windows build broken by r307009

Author: labath Date: Mon Jul 3 04:01:49 2017 New Revision: 307018 URL: http://llvm.org/viewvc/llvm-project?rev=307018&view=rev Log: Fix typo/unbreak windows build broken by r307009 Modified: lldb/trunk/source/Host/common/File.cpp Modified: lldb/trunk/source/Host/common/File.cpp URL: http:/

[Lldb-commits] [PATCH] D34929: respect target.x86-disassembly-flavor when using `memory read`

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good Repository: rL LLVM https://reviews.llvm.org/D34929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

labath added a reviewer: emaste. labath added a comment. +ed as freebsd owner ArrayRef cannot be returned from a function as they don't own the underlying data. The more traditional way of using SmallVector is to "return" it as a by-ref `SmallVectorImpl` argument, as that avoids the need to har

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

labath added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:112 + if (wpid != pid || !WIFSTOPPED(wstatus)) { +std::error_code EC(errno, std::generic_category()); +LLDB_LOG( krytarowski wrote: > I can imagine that in so

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

labath updated this revision to Diff 105065. labath marked 9 inline comments as done. labath added a comment. Address review comments https://reviews.llvm.org/D33778 Files: include/lldb/Host/common/NativeProcessProtocol.h source/Host/common/NativeProcessProtocol.cpp source/Plugins/Process

[Lldb-commits] [PATCH] D34911: Enable parsing C++ names generated by lambda functions.

labath added a reviewer: eugene. labath added a comment. Adding eugene, as he wrote that piece of code. Seems reasonable at a first glance though. https://reviews.llvm.org/D34911 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

[Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

This revision was automatically updated to reflect the committed changes. Closed by commit rL307009: Use llvm::sys::RetryAfterSignal instead of a manual while errno!=EINTR loop (authored by labath). Changed prior to commit: https://reviews.llvm.org/D33831?vs=101212&id=105067#toc Repository:

[Lldb-commits] [lldb] r307030 - Fixing warnings for unused variables and copy ellision

Author: ravitheja Date: Mon Jul 3 08:07:36 2017 New Revision: 307030 URL: http://llvm.org/viewvc/llvm-project?rev=307030&view=rev Log: Fixing warnings for unused variables and copy ellision Summary: The std::move was preventing copy ellision when compiled with clang, the patch fixes the warning

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

krytarowski added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:85 + int wstatus; + ::pid_t wpid = llvm::sys::RetryAfterSignal(-1, ::waitpid, pid, &wstatus, 0); + assert(wpid == pid); We can set BSD specific: `-1` -> `WAIT_

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

labath marked 6 inline comments as done. labath added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:85 + int wstatus; + ::pid_t wpid = llvm::sys::RetryAfterSignal(-1, ::waitpid, pid, &wstatus, 0); + assert(wpid == pid); kry

[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3203 +error.SetError(response.GetError(), eErrorTypeGeneric); + LLDB_LOG(log, "Target does not support Tracing , error {0}", error.AsCString()); } else

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

labath updated this revision to Diff 105095. labath marked 2 inline comments as done. labath added a comment. remove extra pid check https://reviews.llvm.org/D33778 Files: include/lldb/Host/common/NativeProcessProtocol.h source/Host/common/NativeProcessProtocol.cpp source/Plugins/Process/

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

krytarowski added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:85 + int wstatus; + ::pid_t wpid = llvm::sys::RetryAfterSignal(-1, ::waitpid, pid, &wstatus, 0); + assert(wpid == pid); labath wrote: > krytarowski wrote: > >

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

krytarowski accepted this revision. krytarowski added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:87 + assert(wpid == pid); + (void)wpid; + if (wpid != pid || !WIFSTOPPED(wstatus)) { --

[Lldb-commits] [PATCH] D34872: Update lldb architecture docs

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D34872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf