valentinagiusti marked 2 inline comments as done.
valentinagiusti added a comment.
Hi Greg, thanks a lot for your review. I have a question about the API that you
proposed, please have a look at the inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:143-150
+
Author: labath
Date: Wed Jan 25 05:10:52 2017
New Revision: 293045
URL: http://llvm.org/viewvc/llvm-project?rev=293045&view=rev
Log:
Replace chdir() usage with the llvm equivalent.
This removes a hack in PosixApi.h, which tends to produce strange
compile errors when it's included in the wrong ord
Author: labath
Date: Wed Jan 25 05:19:49 2017
New Revision: 293047
URL: http://llvm.org/viewvc/llvm-project?rev=293047&view=rev
Log:
include Host/Time.h in Cocoa.cpp
Time.h contains the necessary magic to enable timegm on all android
targets.
Modified:
lldb/trunk/source/Plugins/Language/ObjC
Author: labath
Date: Wed Jan 25 05:19:45 2017
New Revision: 293046
URL: http://llvm.org/viewvc/llvm-project?rev=293046&view=rev
Log:
NPL: Compartmentalize arm64 single step workaround better
The main motivation for me doing this is being able to build an arm
android lldb-server against api level
valentinagiusti marked 3 inline comments as done.
valentinagiusti added inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:199-218
+ if (arch == llvm::Triple::ArchType::x86_64) {
+lbound = toU64(bt_entry_v[7], bt_entry_v[6], bt_entry_v[5], bt_entry_v[4],
+
valentinagiusti updated this revision to Diff 85733.
valentinagiusti added a comment.
Applied some of the proposed changes.
https://reviews.llvm.org/D29078
Files:
tools/CMakeLists.txt
tools/intel-mpx/CMakeLists.txt
tools/intel-mpx/IntelMPXTablePlugin.cpp
tools/intel-mpx/test/Makefile
labath created this revision.
Herald added a subscriber: ki.stfu.
Currently, in the default configuration, the "install" target will
install all llvm executables unversioned, except for three lldb tools
which will be installed versioned (with a non-versioned symlink). This
rectifies that situation
labath added a comment.
@sylvestre.ledru, I know that debian installs all llvm tools versioned, but I
have no idea through which mechanism. I am guessing it must be something
different than this, as this is lldb-specific. Do you know if you would be
impacted by this?
https://reviews.llvm.org/
mgorny added a comment.
Technically the patch looks sane; however, I suggest you wait for some input
from the others. As for Gentoo, I don't think we ever really cared for LLDB
being versioned — only clang.
https://reviews.llvm.org/D29126
___
lldb
clayborg added inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:151
+ //
+ bd_entry--;
+
There is indeed a bug in SBData::SetData():
```
void SBData::SetData(lldb::SBError &error, const void *buf, size_t size,
lldb::Byt
clayborg added inline comments.
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:151
+ //
+ bd_entry--;
+
clayborg wrote:
> There is indeed a bug in SBData::SetData():
>
> ```
> void SBData::SetData(lldb::SBError &error, const void *buf, size_t size,
>
boris.ulasevich created this revision.
Additional change for https://reviews.llvm.org/D26497,
https://reviews.llvm.org/D28945 - fix for TestCallThatThrows test fail (works
for Mac only).
Recent change of stop reason priorities affected function call mechanism: it is
important that CallFunction
Author: spyffe
Date: Wed Jan 25 15:32:00 2017
New Revision: 293098
URL: http://llvm.org/viewvc/llvm-project?rev=293098&view=rev
Log:
Link debugserver against Foundation to get access to NSProcessInfo.
debugserver-mini can't use Foundation so disable that code there.
Modified:
lldb/trunk/too
While the Green Dragon job where this change was first built failed for
infrastructure reasons in Jenkins, the LLDB build has been failing in the
same way since this commit was made, and looks like it may be related. Can
this be confirmed?
*First built*:
http://lab.llvm.org:8080/green/job/lldb_bui
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Can you explain in more detail the scenario this is addressing? You seem to be
handling a case where some plan has been completed, but it is not the function
call plan we are wait
Author: gclayton
Date: Wed Jan 25 15:50:28 2017
New Revision: 293102
URL: http://llvm.org/viewvc/llvm-project?rev=293102&view=rev
Log:
Fix SBData::SetData() so that it always sets the address byte size correctly
and added a test.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_ap
clayborg added a comment.
I fixed SBData with:
Sendingpackages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py
Sendingsource/API/SBData.cpp
Transmitting file data ..done
Committing transaction...
Committed revision 293102.
https://reviews.llvm.org/D29078
_
clayborg added a comment.
Let me know why your GetValueAsUnsigned isn't working on your register by
stepping through it.
https://reviews.llvm.org/D29078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: jmolenda
Date: Wed Jan 25 20:13:43 2017
New Revision: 293135
URL: http://llvm.org/viewvc/llvm-project?rev=293135&view=rev
Log:
Instead of weak-linking against LoggingSupport framework (which
requires that this private framework be available - and it is not
available earlier than macOS 10.1
Author: jmolenda
Date: Wed Jan 25 20:27:35 2017
New Revision: 293140
URL: http://llvm.org/viewvc/llvm-project?rev=293140&view=rev
Log:
Add Foundation to the debugserver-mini dependencies;
debugserver-mini can use Foundation.
Modified:
lldb/trunk/tools/debugserver/debugserver.xcodeproj/projec
boris.ulasevich added a comment.
I work on the case when we have two plans complete: internal breakpoint plus
our function call plan:
Active plan stack:
Element 0: Base thread plan.
Completed Plan Stack:
Element 0: Run to address: 0x00010e78be00 using breakpoint: 0 - but the
bre
21 matches
Mail list logo
