labath added a comment.
In https://reviews.llvm.org/D28519#641938, @clayborg wrote:
> You can't add anything extra to the AsCString() since it returns a "const
> char *". You can't return a StringRef because it isn't backed by anything.
> You could return a std::string.
>
> My vote would be to
labath updated this revision to Diff 83967.
labath added a comment.
Herald added a subscriber: mgorny.
- Replace the hacky proof-of-concept implementation with something more
production-ready
- Add a option to control adding of source information (defaulting to on)
- Add some unit tests
- Add an
Official Lgtm
On Wed, Jan 11, 2017 at 4:48 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://reviews.llvm.org/D28519#641938, @clayborg wrote:
>
> > You can't add anything extra to the AsCString() since it returns a
> "const char *". You can
clayborg requested changes to this revision.
clayborg added a reviewer: clayborg.
clayborg added a comment.
This revision now requires changes to proceed.
Looks fine except I would rather not have file + line on by default.
Comment at: source/Commands/CommandObjectLog.cpp:51-52
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
https://reviews.llvm.org/D28519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: rsmith
Date: Wed Jan 11 20:37:54 2017
New Revision: 291738
URL: http://llvm.org/viewvc/llvm-project?rev=291738&view=rev
Log:
Update to match clang r291737.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp
Modified:
lldb/trunk/source/Plugins/Express
