ldrumm reopened this revision.
ldrumm added a comment.
This patch was committed back in March https://reviews.llvm.org/rL263099 and
then reverted 2 hours later in https://reviews.llvm.org/rL263107 due to a
testing failure on greendragon related to ObjC. Unfortunately, I no longer have
access t
ldrumm added a subscriber: LLDB.
ldrumm removed rL LLVM as the repository for this revision.
ldrumm updated this revision to Diff 82251.
ldrumm added a comment.
This patch was committed back in March https://reviews.llvm.org/rL263099 and
then reverted 2 hours later in https://reviews.llvm.org/rL2
ldrumm created this revision.
ldrumm added reviewers: zturner, clayborg.
ldrumm added a subscriber: LLDB.
This patch fixes use of incorrect `%zi` to format a plain `int`, and switches
from using "%llu" to format a uint64_t to using the exact width specifier
PRIu64 from inttypes.h
https://revie
zturner added a comment.
How about re-writing these to use `llvm::formatv()` since the whole point of it
is to eliminate this problem entirely and clayborg@ has agreed that it looks
good going forward?
Individual call-site suggestions inlined.
Comment at: source/Interpreter/
Author: cbieneman
Date: Wed Dec 21 15:23:27 2016
New Revision: 290273
URL: http://llvm.org/viewvc/llvm-project?rev=290273&view=rev
Log:
[CMake] Support distribution install for LLDB.framework
This patch adds the last bit of support to get LLVM_DISTRIBUTION_COMPONENTS
working with libLLDB when bu
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please swift to using the new formatv stuff as this is the main reason Zach
made those changes.
Comment at: source/Plugins/ExpressionParser/Clang/IRForTarget.c
kubabrecka created this revision.
kubabrecka added reviewers: jasonmolenda, clayborg.
kubabrecka added subscribers: lldb-commits, zaks.anna.
kubabrecka added a project: Sanitizers.
We currently limit the length of TSan returned backtraces to 8, which is not
necessary (and a bug, most likely). Le
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks fine to me, the only reason I could think to cap it is if the method used
to backtrace the thread could get stuck in a loop & provide infinite number of
frames. but we could
kubabrecka added a comment.
We're dealing with ValueObjects here, so assuming GetNumChildren() returns a
valid number of children, I think this cannot cause any issues.
https://reviews.llvm.org/D28035
___
lldb-commits mailing list
lldb-commits@list
Author: spyffe
Date: Wed Dec 21 17:21:11 2016
New Revision: 290282
URL: http://llvm.org/viewvc/llvm-project?rev=290282&view=rev
Log:
specify -DNDEBUG for BNI builds of all targets in the Xcode build
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/proje
vadimcn added a comment.
Ping! Should I ask somebody else to review?
Repository:
rL LLVM
https://reviews.llvm.org/D27476
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
11 matches
Mail list logo
