Author: labath
Date: Mon Oct 31 06:53:13 2016
New Revision: 285562
URL: http://llvm.org/viewvc/llvm-project?rev=285562&view=rev
Log:
Use the right dwarf attributes for parsing location list entries (fixup for
r285441)
Note that the parsing code here is still incorrect wrt. the new draft of the
d
labath added a comment.
The snippets you showed are pretty-much expected behavior. The backtrace that
gets printed as a part of the log messages is coming from the backtrace(3)
library, which has pretty limited backtracing capabilities -- it only looks at
the symbols in the `.dynsym` section (b
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
I have a quick look and it seems ok. Apart from fixing the issue, it is a
useful clean up too. If testcases are ok then please free to commit.
If you have noted that a function (AddSlashes?) is
tfiala added a comment.
In https://reviews.llvm.org/D26093#583358, @labath wrote:
> The snippets you showed are pretty-much expected behavior. The backtrace that
> gets printed as a part of the log messages is coming from the backtrace(3)
> library, which has pretty limited backtracing capabili
Author: dvlahovski
Date: Mon Oct 31 10:26:44 2016
New Revision: 285584
URL: http://llvm.org/viewvc/llvm-project?rev=285584&view=rev
Log:
Minidump plugin: Adding x86_32 register context converter
Summary:
This, like the x86_64 case, reads the register values from the minidump
file, and emits a bin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285584: Minidump plugin: Adding x86_32 register context
converter (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25832?vs=75578&id=76414#toc
Repository:
rL LLVM
https:/
Author: dvlahovski
Date: Mon Oct 31 10:35:18 2016
New Revision: 285587
URL: http://llvm.org/viewvc/llvm-project?rev=285587&view=rev
Log:
Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin
in SystemInitializerFull
Summary:
This plugin resembles the already existing Wi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285587: Minidump plugin: Adding ProcessMinidump,
ThreadMinidump and register the plugin… (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25905?vs=76176&id=76416#toc
Reposit
labath updated this revision to Diff 76426.
labath added a comment.
Fix handling of single dots and add tests for that.
https://reviews.llvm.org/D26081
Files:
include/lldb/Host/FileSpec.h
source/Host/common/FileSpec.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
unittests/Host
labath added inline comments.
Comment at: source/Host/common/FileSpec.cpp:550
+ (m_filename.GetStringRef() != ".." && m_filename.GetStringRef() != "."))
+return *this;
amccarth wrote:
> Do we have to worry about an unnecessary single dot in the directo
labath updated this revision to Diff 76428.
labath added a comment.
Fix typo in the test
https://reviews.llvm.org/D26081
Files:
include/lldb/Host/FileSpec.h
source/Host/common/FileSpec.cpp
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
unittests/Host/FileSpecTest.cpp
Index: unitt
Author: labath
Date: Mon Oct 31 11:22:07 2016
New Revision: 285593
URL: http://llvm.org/viewvc/llvm-project?rev=285593&view=rev
Log:
Improve ".." handling in FileSpec normalization
Summary:
.. handling for windows path was completely broken because the function was
expecting \ as path separators,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285593: Improve ".." handling in FileSpec normalization
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D26081?vs=76428&id=76432#toc
Repository:
rL LLVM
https://reviews.llvm.
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
The patch generally looks good to me. I added a few high level thought about
register context but they are clearly out of scope for this change. Also next
time please upload your pat
Author: enrico
Date: Mon Oct 31 12:00:54 2016
New Revision: 285596
URL: http://llvm.org/viewvc/llvm-project?rev=285596&view=rev
Log:
Add the new minidump plugin files to the Xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
Author: enrico
Date: Mon Oct 31 12:12:16 2016
New Revision: 285599
URL: http://llvm.org/viewvc/llvm-project?rev=285599&view=rev
Log:
Remove a couple of old TODOs and don't make a new ConstString each time; none
of this is super-critical since it applies to older versions of macOS (or OSX,
I gues
labath updated this revision to Diff 76442.
labath added a comment.
Clean up the code a bit now that I have learned better how to use the chrono
library.
https://reviews.llvm.org/D25391
Files:
source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
source/Plugins/Process/gdb-remote/
Author: labath
Date: Mon Oct 31 12:19:42 2016
New Revision: 285602
URL: http://llvm.org/viewvc/llvm-project?rev=285602&view=rev
Log:
Remove usages of TimeValue from gdb-remote process plugin
Summary:
Most of the changes are very straight-forward, the only tricky part was the
"packet speed-test" f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285602: Remove usages of TimeValue from gdb-remote process
plugin (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D25391?vs=76442&id=76443#toc
Repository:
rL LLVM
https://rev
Author: cbieneman
Date: Mon Oct 31 17:06:52 2016
New Revision: 285646
URL: http://llvm.org/viewvc/llvm-project?rev=285646&view=rev
Log:
[Test-Suite] Speculative fix for darwin bots
When building with Xcode it looks like some of the logic in my test changes
went haywire. This should fix it.
Modi
Author: cbieneman
Date: Mon Oct 31 17:31:07 2016
New Revision: 285651
URL: http://llvm.org/viewvc/llvm-project?rev=285651&view=rev
Log:
[CMake] Populate the build directory's framework
This ensures that the Resources and clang headers are properly symlinked in
LLDB's framework. This should fix t
beanz created this revision.
beanz added reviewers: zturner, labath, spyffe, tfiala.
beanz added a subscriber: lldb-commits.
This patch allows the Darwin build to fall back to to Posix-style lookups for
the clang resource directory if the debugger library isn't inside a framework.
The patch also
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, zturner.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Build problem happens because of errno.
Repository:
rL LLVM
https://reviews.llvm.org/D26171
I think the new mini-dump test case added here might be flaky.
See: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/381
The next build was successful.
-Chris
> On Oct 31, 2016, at 8:35 AM, Dimitar Vlahovski via lldb-commits
> wrote:
>
> Author: dvlahovski
> Date: Mon
Author: sas
Date: Mon Oct 31 19:21:57 2016
New Revision: 285658
URL: http://llvm.org/viewvc/llvm-project?rev=285658&view=rev
Log:
Remove executable bit on a source file
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
(contents, props changed)
Modif
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks reasonable.
Comment at: source/Host/macosx/HostInfoMacOSX.mm:235-239
size_t framework_pos = raw_path.find("LLDB.framework");
- if (framework_pos != std::string::npo
Author: jmolenda
Date: Mon Oct 31 20:26:54 2016
New Revision: 285662
URL: http://llvm.org/viewvc/llvm-project?rev=285662&view=rev
Log:
Fix a bug where the EmulateInstructionARM64 handling of STP/LDP instructions
for floating point registers was not recording them correctly. I needed to
change the
jasonmolenda closed this revision.
jasonmolenda added a comment.
Committed in r285662.
Repository:
rL LLVM
https://reviews.llvm.org/D25864
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
> On Oct 31, 2016, at 9:35 AM, Tamas Berghammer wrote:
>
> tberghammer accepted this revision.
> tberghammer added a comment.
> This revision is now accepted and ready to land.
>
> The patch generally looks good to me. I added a few high level thought about
> register context but they are clea
29 matches
Mail list logo