Moving the discussion to lldb-dev.
On 21 October 2016 at 18:55, Dmitry Mikulin wrote:
> Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux
> changes were committed? I want to use those patches as a template, but it's
> hard to locate them digging through thousands of com
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: amccarth, lldb-commits.
Herald added subscribers: modocache, mgorny, beanz.
This plugin resembles the already existing Windows-only Minidump plugin.
The WinMinidumpPlugin uses the Windows A
Author: labath
Date: Mon Oct 24 07:59:20 2016
New Revision: 284970
URL: http://llvm.org/viewvc/llvm-project?rev=284970&view=rev
Log:
Add the new arm64 sub-register definitions to NativeRegisterContextLinux
It's quite sad that we have to edit so many files just to add a register. I am
going to inv
Author: labath
Date: Mon Oct 24 09:01:52 2016
New Revision: 284976
URL: http://llvm.org/viewvc/llvm-project?rev=284976&view=rev
Log:
Reformat RegisterInfos_arm64 into a table. NFC
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_arm64.h
Modified: lldb/trunk/source/Plugins/Pr
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good, minor comments below.
Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_32.h:37
+// This way we can reuse the already existing register cont
dvlahovski updated this revision to Diff 75578.
dvlahovski marked 3 inline comments as done.
dvlahovski added a comment.
Fixes regarding Pavel's comments
https://reviews.llvm.org/D25832
Files:
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minidump/RegisterContextMini
dvlahovski added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:279
// Register stuff
// TODO probably split register stuff tests into different file?
+#define REG_VAL32(x) *(reinterpret_cast(x))
labath wrote:
> If you want to sp
Author: labath
Date: Mon Oct 24 09:57:50 2016
New Revision: 284981
URL: http://llvm.org/viewvc/llvm-project?rev=284981&view=rev
Log:
Fix arm64 sub-register definitions
The "value regs" field was filled incorrectly. It is supposed to list the
registers that *this* register is a sub-register of, no
Author: labath
Date: Mon Oct 24 11:20:43 2016
New Revision: 284987
URL: http://llvm.org/viewvc/llvm-project?rev=284987&view=rev
Log:
Use shorter names in TestConcurrentEvents tests
Otherwise, they tend to generate filename too long errors.
They already contain the same test name in the directory
labath added a comment.
first round of comments. I will give this another look tomorrow.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64_not_crashed.cpp:7
+int
+bar(int x)
+{
Please format these consistently (llv
dvlahovski updated this revision to Diff 75617.
dvlahovski marked 6 inline comments as done.
dvlahovski added a comment.
Addressed Pavel's comments.
https://reviews.llvm.org/D25905
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
packages/Py
On 24 October 2016 at 06:26, Pavel Labath wrote:
>
> It's not my place to tell you how to work, but I'd recommend a
> different approach to this. If you base your work on the current
> FreeBSD in-process plugin, then when you get around to actually
> implementing remote support, you will find that
dvlahovski added a comment.
Please ignore the `RegisterContextMinidump_x86_*` changes. Can't seem to make
`arc diff` understand what I want.
https://reviews.llvm.org/D25905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
On 24.10.2016 20:38, Ed Maste wrote:
> On 24 October 2016 at 06:26, Pavel Labath wrote:
>>
>> It's not my place to tell you how to work, but I'd recommend a
>> different approach to this. If you base your work on the current
>> FreeBSD in-process plugin, then when you get around to actually
>> imp
tfiala created this revision.
tfiala added reviewers: jingham, labath.
tfiala added a subscriber: lldb-commits.
The TestUniversal.py test was attempting to build its own CFLAGS unreliably.
Essentially it just wanted the prevailing CFLAGS without the arch spec.
This change does the following:
-
jmajors created this revision.
jmajors added a reviewer: labath.
jmajors added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Added a test for the next_pc being zero before setting a software breakpoint
in arm32 and mips.
Reenabled the cr
Author: tfiala
Date: Mon Oct 24 16:46:46 2016
New Revision: 285032
URL: http://llvm.org/viewvc/llvm-project?rev=285032&view=rev
Log:
remove xfail from TestObjCNewSyntax.py test_expr_gmodules()
Fixes:
rdar://27792848
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-new-synt
On Mon, Oct 24, 2016 at 11:38 AM, Ed Maste via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> On 24 October 2016 at 06:26, Pavel Labath wrote:
> >
> > It's not my place to tell you how to work, but I'd recommend a
> > different approach to this. If you base your work on the current
> > Free
jasonmolenda added a comment.
Hi Tamas, sorry for not replying earlier, something urgent came up that I
needed to look at.
Thanks for the review. I agree with using your existing arm64 register enums
in lldb-arm64-register-enums.h. I'd like to remove the enums in
RegisterInfos_arm64.h instea
19 matches
Mail list logo
