[Lldb-commits] [PATCH] [Accepted] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

2016-09-30 Thread Bhushan Attarde via lldb-commits
bhushan accepted this revision. bhushan added a comment. This revision is now accepted and ready to land. Looks good as far as correctness is concerned. https://reviews.llvm.org/D24498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] [Commented On] D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address

2016-09-30 Thread Bhushan Attarde via lldb-commits
bhushan added a comment. Hi Eugene, I did not commit this patch because @zturner had asked for a testcase for this change. But the test will require to build it for micromips target (-mmicromips option) and currently I don't have any micromips hardware available. I had tested this patch with s

[Lldb-commits] [PATCH] [Updated, 58 lines] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-09-30 Thread Nitesh Jain via lldb-commits
nitesh.jain removed rL LLVM as the repository for this revision. nitesh.jain updated this revision to Diff 73029. nitesh.jain added a comment. We just require ABI information so that auxv vector is parse when lldb try to attach a process via "attach -p pid" https://reviews.llvm.org/D25021 File

[Lldb-commits] [lldb] r282848 - Fix PDB unittests on non-windows platforms

2016-09-30 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Sep 30 06:47:54 2016 New Revision: 282848 URL: http://llvm.org/viewvc/llvm-project?rev=282848&view=rev Log: Fix PDB unittests on non-windows platforms llvm r282788 changed how the presence of windows DIA SDK is signalled. Adjust to that. Modified: lldb/trunk/unittest

[Lldb-commits] [lldb] r282849 - XFAIL TestSBData for gcc-4.9 i386

2016-09-30 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Sep 30 07:12:15 2016 New Revision: 282849 URL: http://llvm.org/viewvc/llvm-project?rev=282849&view=rev Log: XFAIL TestSBData for gcc-4.9 i386 test broken in r282659. Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py Modified: lldb/

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-30 Thread Pavel Labath via lldb-commits
I made a quick investigation today. The problem is indeed specific to gcc-4.9. The main differences I could see is that gcc-4.9 generates a different prologue for the function, and uses pushl for argument passing. This confuses the emulator/augmenter and the unwind information at some points ends u

[Lldb-commits] [lldb] r282862 - Fixing windows build breakage caused by rL282822

2016-09-30 Thread Dimitar Vlahovski via lldb-commits
Author: dvlahovski Date: Fri Sep 30 09:36:17 2016 New Revision: 282862 URL: http://llvm.org/viewvc/llvm-project?rev=282862&view=rev Log: Fixing windows build breakage caused by rL282822 The breakage was because of the moving of the UTF functions to the llvm namespace Modified: lldb/trunk/sou

[Lldb-commits] [lldb] r282866 - Again fixing windows build breakage like in rL282862

2016-09-30 Thread Dimitar Vlahovski via lldb-commits
Author: dvlahovski Date: Fri Sep 30 10:41:33 2016 New Revision: 282866 URL: http://llvm.org/viewvc/llvm-project?rev=282866&view=rev Log: Again fixing windows build breakage like in rL282862 Modified: lldb/trunk/source/Host/windows/Windows.cpp Modified: lldb/trunk/source/Host/windows/Windows.

[Lldb-commits] [lldb] r282869 - Skip TestRuntimeIvars on i386; the Objective-C V1 runtime doesn't list ivars.

2016-09-30 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 30 11:02:28 2016 New Revision: 282869 URL: http://llvm.org/viewvc/llvm-project?rev=282869&view=rev Log: Skip TestRuntimeIvars on i386; the Objective-C V1 runtime doesn't list ivars. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-runtime-ivars/

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-09-30 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. zturner added subscribers: lldb-commits, LLDB. In https://reviews.llvm.org/D24952 I tried to refactor the `Args` class to get rid of `m_argv`. The original motivation for this is that I wanted a way to implement `GetArgumentAtIn

[Lldb-commits] [lldb] r282871 - Add namespace qualifiers for UTF functions that just moved.

2016-09-30 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Fri Sep 30 11:11:42 2016 New Revision: 282871 URL: http://llvm.org/viewvc/llvm-project?rev=282871&view=rev Log: Add namespace qualifiers for UTF functions that just moved. Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp lldb/trunk/source/Pl

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-09-30 Thread Adrian McCarthy via lldb-commits
amccarth added a comment. Just a drive by. > Args.h:449 >//-- >// Classes that inherit from Args can see and modify these >//-- This comment is no longer

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-09-30 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 73099. zturner added a comment. Renamed `EntryData` to `ArgEntry` and made it public. This will be useful later for providing iterator support over the entries. https://reviews.llvm.org/D25099 Files: include/lldb/Interpreter/Args.h source/Core/StringL

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-09-30 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 73095. https://reviews.llvm.org/D25099 Files: include/lldb/Interpreter/Args.h source/Core/StringList.cpp source/Interpreter/Args.cpp unittests/Interpreter/TestArgs.cpp Index: unittests/Interpreter/TestArgs.cpp

[Lldb-commits] [lldb] r282898 - Fixed several i386 Objective-C tests by completing objects, not their pointers.

2016-09-30 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 30 13:44:43 2016 New Revision: 282898 URL: http://llvm.org/viewvc/llvm-project?rev=282898&view=rev Log: Fixed several i386 Objective-C tests by completing objects, not their pointers. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/sou

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-30 Thread Jason Molenda via lldb-commits
Thanks for the help! It took me most of yesterday to get gcc-4.9 built (it's been more than a decade since I've built gcc) - I think I've got it set up now, so I'll figure this out today. I'm in the middle of looking into a bug in the 32-bit assembly assembly instruction unwind plan creation t

[Lldb-commits] [lldb] r282941 - Fix comment - Module::PrepareForFunctionNameLookup should be Module::LookupInfo::LookupInfo.

2016-09-30 Thread Dawn Perchik via lldb-commits
Author: dperchik Date: Fri Sep 30 15:38:33 2016 New Revision: 282941 URL: http://llvm.org/viewvc/llvm-project?rev=282941&view=rev Log: Fix comment - Module::PrepareForFunctionNameLookup should be Module::LookupInfo::LookupInfo. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileD

[Lldb-commits] [lldb] r282943 - Adding ivars in class extensions isn't supported on i386; skip a test.

2016-09-30 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 30 15:46:09 2016 New Revision: 282943 URL: http://llvm.org/viewvc/llvm-project?rev=282943&view=rev Log: Adding ivars in class extensions isn't supported on i386; skip a test. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/persist_objc_poin

[Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

2016-09-30 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Sep 30 17:07:41 2016 New Revision: 282966 URL: http://llvm.org/viewvc/llvm-project?rev=282966&view=rev Log: IsValid is the way to ask a breakpoint location whether it is valid. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint

[Lldb-commits] [PATCH] D25137: [lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output

2016-09-30 Thread Dawn Perchik via lldb-commits
dawn created this revision. dawn added reviewers: ted, zturner, clayborg. dawn added subscribers: amccarth, lldb-commits. dawn set the repository for this revision to rL LLVM. The code added in svn trunk 264332 causes "(lldb)" to be printed in the middle of program console output. This fix rest

[Lldb-commits] [lldb] r282969 - Add the radar from our end to the bugreport string.

2016-09-30 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Sep 30 17:22:09 2016 New Revision: 282969 URL: http://llvm.org/viewvc/llvm-project?rev=282969&view=rev Log: Add the radar from our end to the bugreport string. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py Modified

[Lldb-commits] [lldb] r282970 - Add the radar on our end to the bugreport string.

2016-09-30 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Sep 30 17:24:11 2016 New Revision: 282970 URL: http://llvm.org/viewvc/llvm-project?rev=282970&view=rev Log: Add the radar on our end to the bugreport string. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/create_during_step/TestCreateDuri

[Lldb-commits] [PATCH] D25137: [lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output

2016-09-30 Thread Ted Woodward via lldb-commits
ted accepted this revision. ted added a comment. This revision is now accepted and ready to land. The problem this scenario has is asynchronous output from 2 different sources. The original fix made Windows (or any lldb without libedit) much better, but I think most non-Windows builds will use l

[Lldb-commits] [lldb] r282976 - Fix up the test so it gets closer to passing.

2016-09-30 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Sep 30 17:55:57 2016 New Revision: 282976 URL: http://llvm.org/viewvc/llvm-project?rev=282976&view=rev Log: Fix up the test so it gets closer to passing. Remove the test for thread stopped states from this test. That isn't set properly now, and its setting doesn't matt

[Lldb-commits] [lldb] r282990 - test infra: clear file-charged issues on rerun of file

2016-09-30 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Sep 30 19:17:08 2016 New Revision: 282990 URL: http://llvm.org/viewvc/llvm-project?rev=282990&view=rev Log: test infra: clear file-charged issues on rerun of file This change addresses the corner case bug in the test infrastructure where a test file times out *outside* of

[Lldb-commits] [lldb] r282991 - Add support for some extended push instructions in i386/x86_64 like

2016-09-30 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Sep 30 19:19:26 2016 New Revision: 282991 URL: http://llvm.org/viewvc/llvm-project?rev=282991&view=rev Log: Add support for some extended push instructions in i386/x86_64 like 'push 0x20(%esp)' which clang can generate when emitting -fomit-frame-pointer code for 32-bit.

[Lldb-commits] [lldb] r282993 - Fix up this test case.

2016-09-30 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Sep 30 19:49:12 2016 New Revision: 282993 URL: http://llvm.org/viewvc/llvm-project?rev=282993&view=rev Log: Fix up this test case. The lldbutil.run_break_set_by_file_and_line has already checked that the number of locations was 1, so don't check it again. And certainl

[Lldb-commits] [lldb] r283010 - Add unit tests for specific instruction patterns that the x86

2016-09-30 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Sep 30 23:50:25 2016 New Revision: 283010 URL: http://llvm.org/viewvc/llvm-project?rev=283010&view=rev Log: Add unit tests for specific instruction patterns that the x86 assembly inspection class is designed to detect. This is only about half of the instructions that it

[Lldb-commits] [lldb] r283018 - Use StringRef instead of raw pointers in MCAsmInfo/MCInstrInfo APIs (NFC)

2016-09-30 Thread Mehdi Amini via lldb-commits
Author: mehdi_amini Date: Sat Oct 1 01:46:33 2016 New Revision: 283018 URL: http://llvm.org/viewvc/llvm-project?rev=283018&view=rev Log: Use StringRef instead of raw pointers in MCAsmInfo/MCInstrInfo APIs (NFC) Modified: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp