Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

2016-09-18 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23 @@ +22,3 @@ +{ +printf("About to write byteArray[%d] ...\n", i); // About to write byteArray + zturner wrote: > What'

Re: [Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2016-09-18 Thread Ilia K via lldb-commits
ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Hi! Please add tests for commands that you fixed. I'll take a look later this week. Repository: rL LLVM https://reviews.llvm.org/D24711 _