valentinagiusti updated this revision to Diff 70507.
valentinagiusti added a comment.
Improved TestMPXRegisters.py and Makefile according to review.
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalities/register/Makefile
packages/Python/lldbsuite/test/functio
Author: labath
Date: Wed Sep 7 03:46:50 2016
New Revision: 280793
URL: http://llvm.org/viewvc/llvm-project?rev=280793&view=rev
Log:
Fix unittest compilation on windows
After the reformat, the unittests do not compile due to missing due to
redefinition errors
between PosixApi.h and ucrt/direct.h
abhishek.aggarwal updated this revision to Diff 70513.
abhishek.aggarwal added a comment.
Changes based on review
- Added header doc and ran clang-format on code
https://reviews.llvm.org/D24251
Files:
include/lldb/API/SBSection.h
scripts/interface/SBSection.i
source/API/SBSection.cpp
In
labath added a comment.
Thank you for addressing the comments. let's continue this in the other thread.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27
@@ +26,3 @@
+
+@skipIfiOSSimulator
+@skipIf(compile
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
@@ +4,3 @@
+
+ifeq "$(ARCH)" "i386"
+ CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
valentinagiusti wrote:
> la
valentinagiusti marked an inline comment as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6
@@ +5,3 @@
+ifeq "$(ARCH)" "i386"
+ CFLAGS_EXTRAS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
+ LD_EXTRAS +=
emaste added a subscriber: emaste.
emaste added a comment.
Which library contains `llvm::itaniumDemangle`?
https://reviews.llvm.org/D24293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
On 7 September 2016 at 11:35, Chaoren Lin wrote:
> chaoren added a comment.
>
> Cool. Would it be a good idea to only use LLVM's demangler? We can get rid of
> all the messy ifdef business, and I assume the LLVM demangler would be better
> maintained and more up to date than any system demangler
On 7 September 2016 at 10:41, Ed Maste wrote:
> emaste added a subscriber: emaste.
> emaste added a comment.
>
> Which library contains `llvm::itaniumDemangle`?
lib/Demangle. I will try to make sue a shared library build works and
update the thread.
Cheers,
Rafael
__
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sounds good. As long as we know what is there (the XML and Jason's other
packet) and know that the desired functionalities do not overlap I am fine with
the approach that you suggest! Than
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We need to carefully benchmark any changes in demangling if we are thinking
about switching to using llvm::itaniumDemangle() for everything. The demangler
that was built into libcxxabi was
labath added a comment.
Ok, after a bit more digging, this is what I have found:
> Error ProcessGDBRemote::GetLoadedModuleList (LoadedModuleInfoList & list);
>
This packet is not usable **in it's current form** as it does not include the
UUID of the module. As far as I can tell, it is inte
zturner added a subscriber: zturner.
zturner added a comment.
AFAICT, this patch only changes the case where we were already not able to use
the fast demangler. So nothing should change.
https://reviews.llvm.org/D24293
___
lldb-commits mailing lis
chaoren added a comment.
Cool. Would it be a good idea to only use LLVM's demangler? We can get rid of
all the messy ifdef business, and I assume the LLVM demangler would be better
maintained and more up to date than any system demangler.
https://reviews.llvm.org/D24293
clayborg added a comment.
In https://reviews.llvm.org/D24293#535928, @zturner wrote:
> AFAICT, this patch only changes the case where we were already not able to
> use the fast demangler. So nothing should change.
Yep, I saw that and that is why I OK'ed the patch. Someone else suggested
cutt
rafael closed this revision.
rafael added a comment.
280821
https://reviews.llvm.org/D24293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
I think we're approaching the end now. If you could upload the new version
(you'll have to reformat the changes), I'll give it a final pass.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6
@@ +5,3 @
k8stone added a comment.
Glad to see this change. Maintaining another copy of the same demangler in
LLDB is definitely unnecessary.
https://reviews.llvm.org/D24293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
Eugene.Zelenko added inline comments.
Comment at: source/API/SBSection.cpp:257
@@ +256,3 @@
+SectionSP section_sp(GetSP());
+if (section_sp.get())
+return section_sp->GetPermissions();
You don't need to use get(), because smart pointers have
http:
zturner created this revision.
zturner added subscribers: LLDB, lldb-commits, rnk.
I was trying to brainstorm what a real test that currently exists might look
like if converted to a lit-style test. Not even proposing we do this, just
figured I would throw up what I came up with in case anyone
Author: jmolenda
Date: Wed Sep 7 18:08:36 2016
New Revision: 280879
URL: http://llvm.org/viewvc/llvm-project?rev=280879&view=rev
Log:
Remove CxaDemangle.cpp / .h from xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
Author: jingham
Date: Wed Sep 7 19:42:02 2016
New Revision: 280892
URL: http://llvm.org/viewvc/llvm-project?rev=280892&view=rev
Log:
Remove lldb coding conventions as they are no longer relevant.
Removed:
lldb/trunk/www/lldb-coding-conventions.html
Modified:
lldb/trunk/www/sidebar.incl
Author: jmolenda
Date: Wed Sep 7 21:26:58 2016
New Revision: 280902
URL: http://llvm.org/viewvc/llvm-project?rev=280902&view=rev
Log:
Force the initialization of the m_type ivar in
Function::GetStartLineSourceInfo before we try to
return the start line information about a function;
this function
Author: jmolenda
Date: Wed Sep 7 21:29:40 2016
New Revision: 280903
URL: http://llvm.org/viewvc/llvm-project?rev=280903&view=rev
Log:
I had a problem with one SDK where dispatch_release was actually a
macro, so writing ::dispatch_release did not work as expected.
Remove the global anon namespace
Author: jmolenda
Date: Thu Sep 8 00:12:41 2016
New Revision: 280906
URL: http://llvm.org/viewvc/llvm-project?rev=280906&view=rev
Log:
I'm experimenting with changing how the mixed source & assembly
mode in lldb works. I've been discussing this with Jim Ingham,
Greg Clayton, and Kate Stone for th
ki.stfu created this revision.
ki.stfu added reviewers: clayborg, jingham, zturner.
ki.stfu added a subscriber: lldb-commits.
It fixes the following compile warnings:
1. '0' flag ignored with precision and ‘%d’ gnu_printf format
2. enumeral and non-enumeral type in conditional expression
3. format
ki.stfu added a comment.
BTW, the following warnings remain:
1. unrecognized command line option ‘-Wno-vla-extension’
2. unrecognized command line option ‘-Wno-deprecated-register’
3. comparison of unsigned expression >= 0 is always true
[2782/3295] Building CXX object
tools/lldb/source/Plugi
27 matches
Mail list logo
