[Lldb-commits] [lldb] r279512 - Fix API usage in TestMultithreaded.test_sb_api_listener_event_process_state

2016-08-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Aug 23 07:10:03 2016 New Revision: 279512 URL: http://llvm.org/viewvc/llvm-project?rev=279512&view=rev Log: Fix API usage in TestMultithreaded.test_sb_api_listener_event_process_state The test was attempting to backtrace a process after every state change event (includin

[Lldb-commits] [lldb] r279513 - Fix a crash in GDBRemoteCommunicationClient::GetSupportedStructuredDataPlugins

2016-08-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Aug 23 07:10:09 2016 New Revision: 279513 URL: http://llvm.org/viewvc/llvm-project?rev=279513&view=rev Log: Fix a crash in GDBRemoteCommunicationClient::GetSupportedStructuredDataPlugins The function was attempting to write the reply to the log even if the reply was empt

[Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-23 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. This is a preparatory commit for D22914, where I'd like to replace this mutex by an R/W lock (which is also not recursive). This required a couple of changes: - Read/WriteRegister expect the

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-23 Thread Greg Clayton via lldb-commits
clayborg added a comment. The old mutex was there so that you could send a packet and get a result without worrying about other threads getting your response. It was recursive for the case where we needed to send two packets as one (set thread ID, then send packet), and for reading all register

[Lldb-commits] [lldb] r279533 - Change the PathMappingList::FindFile to use FileSpec API's

2016-08-23 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Aug 23 12:13:33 2016 New Revision: 279533 URL: http://llvm.org/viewvc/llvm-project?rev=279533&view=rev Log: Change the PathMappingList::FindFile to use FileSpec API's Also, when appending path components, collapse multiple "/" into one at the join. Modified: lldb/t

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-23 Thread Pavel Labath via lldb-commits
labath added a comment. In https://reviews.llvm.org/D23802#523244, @clayborg wrote: > The old mutex was there so that you could send a packet and get a result > without worrying about other threads getting your response. It was recursive > for the case where we needed to send two packets as one

[Lldb-commits] [lldb] r279540 - Implementation "step out" plans shouldn't gather the return value.

2016-08-23 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Aug 23 12:55:21 2016 New Revision: 279540 URL: http://llvm.org/viewvc/llvm-project?rev=279540&view=rev Log: Implementation "step out" plans shouldn't gather the return value. When, for instance, "step-in" steps into a function that it doesn't want to stop in (e.g. has no

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-23 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Maybe instead of "NoLock" on the functions we those functions take an extra argument? Then someone can't accidentally run one of those without locking. We need to somehow enforce

[Lldb-commits] [PATCH] Fix warnings preventing copy elision.

2016-08-23 Thread Taras Tsugrii via lldb-commits
Summary: Moving a temporary object prevents copy elision, which is exactly what clang points out by warning about this pattern. The fix is simply removal of std::move applied to temporary objects. Differential Revision: https://reviews.llvm.org/D23825 --- tools/debugserver/source/JSON.cpp | 20 +

[Lldb-commits] [PATCH] Fix warnings preventing copy elision.

2016-08-23 Thread Taras Tsugrii via lldb-commits
Summary: Moving a temporary object prevents copy elision, which is exactly what clang points out by warning about this pattern. The fix is simply removal of std::move applied to temporary objects. Differential Revision: https://reviews.llvm.org/D23825 --- tools/debugserver/source/JSON.cpp | 20 +

[Lldb-commits] [lldb] r279611 - Add api logging for SBDebugger::SetCurrentPlatformSDKRoot.

2016-08-23 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Aug 24 00:25:32 2016 New Revision: 279611 URL: http://llvm.org/viewvc/llvm-project?rev=279611&view=rev Log: Add api logging for SBDebugger::SetCurrentPlatformSDKRoot. Modified: lldb/trunk/source/API/SBDebugger.cpp Modified: lldb/trunk/source/API/SBDebugger.cpp UR