Author: labath
Date: Thu Aug 18 03:21:42 2016
New Revision: 279039
URL: http://llvm.org/viewvc/llvm-project?rev=279039&view=rev
Log:
Fix tests for the gdb-remote memory read packets
Part of TestGDBRemoteMemoryRead has been disabled since r259379 because it was
incompatible with
python3. This cha
Author: labath
Date: Thu Aug 18 03:21:38 2016
New Revision: 279038
URL: http://llvm.org/viewvc/llvm-project?rev=279038&view=rev
Log:
Fix parsing of complicated C++ names
Summary:
CPlusPlusLanguage::MethodName was not correctly parsing templated functions
whose demangled name
included the return
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279038: Fix parsing of complicated C++ names (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D23608?vs=68344&id=68493#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23608
Author: labath
Date: Thu Aug 18 03:30:03 2016
New Revision: 279040
URL: http://llvm.org/viewvc/llvm-project?rev=279040&view=rev
Log:
gdb-remote: Centralize thread specific packet handling
Summary:
Before this, each function had a copy of the code which handled appending of
the thread suffix to
t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279040: gdb-remote: Centralize thread specific packet
handling (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23604?vs=68337&id=68495#toc
Repository:
rL LLVM
https://review
Author: labath
Date: Thu Aug 18 07:32:41 2016
New Revision: 279057
URL: http://llvm.org/viewvc/llvm-project?rev=279057&view=rev
Log:
Move QSyncThreadState packet generation to the gdb-remote client
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
ll
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
The tricky part here was that the exisiting implementation of WriteAllRegisters
was expecting
hex-encoded data (as that was what the first implementation I replaced was
using, but here we ha
Author: labath
Date: Thu Aug 18 09:33:55 2016
New Revision: 279070
URL: http://llvm.org/viewvc/llvm-project?rev=279070&view=rev
Log:
gdb-remote: Remove manual locking from GetShlibInfoAddr
The function can simply call the non-NoLock version of the SendPacket function
and let it do the
locking.
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dvlahovski updated this revision to Diff 68557.
dvlahovski added a comment.
Update of the code, regarding the remarks
of zturner and amccarth.
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/minidump/CMakeLi
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:258
@@ +257,3 @@
+llvm::support::ulittle16_t processor_level;
+llvm::support::ulittle16_t processor_revision;
+
The idea of this is to be sure that the compiler d
dvlahovski added a comment.
In https://reviews.llvm.org/D23545#516808, @amccarth wrote:
> Are we putting this code in the right place? I wouldn't expect minidump
> parsing to fall under Plugins/Process.
>
> I assume the eventual intent is to turn the Windows-specific code into a user
> of your
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.h:67
@@ +66,3 @@
+bool m_valid_data;
+llvm::DenseMap m_directory_map;
+};
Can this be `llvm::DenseMap`?
No point erasing the type information of the enum.
=
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:259
@@ +258,3 @@
+static_assert(sizeof(MinidumpSystemInfo) == MINIDUMP_SYSTEM_INFO_SIZE, "sizeof
MinidumpSystemInfo is not correct!");
+
+struct MinidumpMiscInfo
I think th
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D23659
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: spyffe
Date: Thu Aug 18 12:45:50 2016
New Revision: 279098
URL: http://llvm.org/viewvc/llvm-project?rev=279098&view=rev
Log:
Fixed a problem where we failed to get the size of an Objective-C type.
Modified:
lldb/trunk/source/Expression/Materializer.cpp
Modified: lldb/trunk/source/E
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.h:67
@@ +66,3 @@
+bool m_valid_data;
+llvm::DenseMap m_directory_map;
+};
zturner wrote:
> Can this be `llvm::DenseMap`?
>
> No point erasing the type information
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.h:67
@@ +66,3 @@
+bool m_valid_data;
+llvm::DenseMap m_directory_map;
+};
dvlahovski wrote:
> zturner wrote:
> > Can this be `llvm::DenseMap > MinidumpLocationDescrip
dvlahovski added a comment.
Also FYI I copied the implementation of `consumeObject` to my header.
https://reviews.llvm.org/D23545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added a comment.
In https://reviews.llvm.org/D23545#519675, @dvlahovski wrote:
> In https://reviews.llvm.org/D23545#516808, @amccarth wrote:
>
> > Are we putting this code in the right place? I wouldn't expect minidump
> > parsing to fall under Plugins/Process.
> >
> > I assume the eve
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:21
@@ +20,3 @@
+
+llvm::Optional
+MinidumpHeader::Parse(llvm::ArrayRef &data)
zturner wrote:
> I think these can all just return the pointer instead of `llvm::Optional<
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:133
@@ +132,3 @@
+// This matches the Linux kernel definitions from
+enum MinidumpPCPUInformationARMElfHwCaps
+{
dvlahovski wrote:
> amccarth wrote:
> > zturner wrote:
> >
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:260
@@ +259,3 @@
+
+uint8_t number_of_processors;
+uint8_t product_type;
amccarth wrote:
> I'll concede that the static_assert is useful. Given that, showing the
> On Aug 11, 2016, at 4:00 PM, Enrico Granata wrote:
>
>
>> On Aug 11, 2016, at 3:55 PM, Jim Ingham via lldb-commits
>> mailto:lldb-commits@lists.llvm.org>> wrote:
>>
>> jingham added a comment.
>>
>> The patch seems correct to me.
>>
>> I don't have a strong opinion about std::vector vrs.
Author: tfiala
Date: Thu Aug 18 23:38:44 2016
New Revision: 279203
URL: http://llvm.org/viewvc/llvm-project?rev=279203&view=rev
Log:
fix broken gdb-remote gtest
This change adds the Process/gdb-remote gtests to the Xcode
build. It also adds a virtual method impl to the continuation
delegate that
Author: tfiala
Date: Thu Aug 18 23:55:12 2016
New Revision: 279205
URL: http://llvm.org/viewvc/llvm-project?rev=279205&view=rev
Log:
fixup macOS gtest running
Needed to explicitly turn off RTTI (since lldb-core builds
with -fno-rtti) and specify -DGTEST_HAVE_RTTI=0.
Modified:
lldb/trunk/lldb
Author: tfiala
Date: Fri Aug 19 00:26:40 2016
New Revision: 279208
URL: http://llvm.org/viewvc/llvm-project?rev=279208&view=rev
Log:
add all missing gtest tests to the Xcode lldb-gtest target
Exclusions:
ModuleCacheTest: https://llvm.org/bugs/show_bug.cgi?id=29045
SymbolFilePDBTests: https://llvm
tfiala commandeered this revision.
tfiala added a reviewer: aprantl.
tfiala added a comment.
Grabbing it.
I had to get that DarwinLog support wrapped up (it was in process for something
like a month). Now that I wrapped that up, I'll get back to this.
https://reviews.llvm.org/D20835
__
28 matches
Mail list logo
