labath added a subscriber: zturner.
labath added a comment.
I think I have understood the situation a bit more now, so let me try to
explain what is going on.
In https://reviews.llvm.org/D23290#511683, @clayborg wrote:
> Is this something the user is typing in your IDE that you are forwarding t
On 11 August 2016 at 00:41, Zachary Turner via lldb-commits
wrote:
> Couple of random style comments below. You don't have to fix these, just
> something to think about in the future.
>
>
>
> On Wed, Aug 10, 2016 at 4:33 PM Greg Clayton via lldb-commits
> wrote:
>>
>> +
>> +TEST_F(PythonDataObje
Author: labath
Date: Thu Aug 11 04:22:22 2016
New Revision: 278325
URL: http://llvm.org/viewvc/llvm-project?rev=278325&view=rev
Log:
Remove a double send of eRunPacketSent event
I accidentaly added the send both to the base class and the derived class in my
refactor. Fix
that.
Modified:
ll
omjavaid created this revision.
omjavaid added a reviewer: labath.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: samparker, rengolin, aemerson.
LldbGdbServerTestCase.test_software_breakpoint_set* are failing when breakpoint
target address is an thumb16 instruction.
Test ri
omjavaid updated this revision to Diff 67669.
omjavaid added a comment.
Herald added a subscriber: srhines.
Updated with suggestion incorporated.
Here's what I am getting on different inputs:
Testing make clean CC=gcc
ar
objcopy
Testing make clean CC=clang
ar
objcopy
Testing make clean CC=gcc-
Author: omjavaid
Date: Thu Aug 11 05:35:05 2016
New Revision: 278326
URL: http://llvm.org/viewvc/llvm-project?rev=278326&view=rev
Log:
Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due
thumb instructions
Differential revision: https://reviews.llvm.org/D23395
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278326: Make sure LldbGdbServerTestCase is built in arm mode
to avoid failures due… (authored by omjavaid).
Changed prior to commit:
https://reviews.llvm.org/D23395?vs=67663&id=67670#toc
Repository:
labath created this revision.
labath added reviewers: clayborg, jingham.
labath added subscribers: lldb-commits, tberghammer.
The following problem was occuring:
- broadcaster B had two listeners: L1 and L2 (thread T1)
- (T1) B has started to broadcast an event, it has locked a shared_ptr to L1 (i
Author: labath
Date: Thu Aug 11 09:12:10 2016
New Revision: 278335
URL: http://llvm.org/viewvc/llvm-project?rev=278335&view=rev
Log:
Make sure files include what they use (part 2/2)
This makes lldb still compile on linux after a project-wide clang-format
Modified:
lldb/trunk/source/Plugins/P
Tbh I've no experience with ptys so I don't know if there is an equivalent
I do know that more than one process can share a single console. So for
example if you run a copy of lldb, you can have the ide and lldb share the
same console.
Not sure if this is similar to what you're doing though
On Th
kubabrecka accepted this revision.
kubabrecka added a comment.
This revision is now accepted and ready to land.
LGTM. While you’re at it, could you also reformat with clang-format? I
noticed that the files inconsistently use curly braces on same line or new line.
https://reviews.llvm.org/D231
kubabrecka accepted this revision.
kubabrecka added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
labath added a comment.
Looks great, just give me a while to prepare the new paths on the buildbots.
Should be done by tomorrow.
https://reviews.llvm.org/D20386
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: labath
Date: Thu Aug 11 10:31:30 2016
New Revision: 278345
URL: http://llvm.org/viewvc/llvm-project?rev=278345&view=rev
Log:
Fix unit tests on windows
Python headers need to be included before PosixApi.h
Modified:
lldb/trunk/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.c
labath added a comment.
Hm... there is one more problem here.. when we run the tests against a
top-of-tree clang that we have just built, we will compute AR and OBJCOPY to be
in the build directory. They will obviously not be there, and we cannot just
create the symlinks there by hand because t
vsk added a comment.
Thanks for the review!
Normally I'd be happy to commit some clang-format changes as a follow-up, but
the lldb team is planning on doing a project-wide clang-format commit in early
September. Maybe it would be best to wait for that?
https://reviews.llvm.org/D23150
_
Author: vedantk
Date: Thu Aug 11 12:28:37 2016
New Revision: 278368
URL: http://llvm.org/viewvc/llvm-project?rev=278368&view=rev
Log:
[InstrumentationRuntime] Refactor the API (Part 2/N) (NFCI)
Factor out some common logic used to find the runtime library in a list
of modules.
Differential Revis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278368: [InstrumentationRuntime] Refactor the API (Part 2/N)
(NFCI) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D23150?vs=66755&id=67706#toc
Repository:
rL LLVM
https://
Author: vedantk
Date: Thu Aug 11 12:28:33 2016
New Revision: 278367
URL: http://llvm.org/viewvc/llvm-project?rev=278367&view=rev
Log:
[InstrumentationRuntime] Refactor the API (Part 1/N) (NFCI)
Adapters for instrumentation runtimes have to do two basic things:
1) Load a runtime library.
2) I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278367: [InstrumentationRuntime] Refactor the API (Part 1/N)
(NFCI) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D23043?vs=66411&id=67705#toc
Repository:
rL LLVM
https://
Author: zturner
Date: Thu Aug 11 13:10:40 2016
New Revision: 278373
URL: http://llvm.org/viewvc/llvm-project?rev=278373&view=rev
Log:
Modify coding conventions to mention include ordering.
Modified:
lldb/trunk/www/lldb-coding-conventions.html
Modified: lldb/trunk/www/lldb-coding-conventions.
clayborg added a comment.
My only issue with this patch is that is uses llvm::SmallVector. Although the
class is nice, we don't have visibility into this class when debugging like we
do when we use STL collections. I would rather not move to SmallVector if we
don't need to. Jim, thoughts?
htt
clayborg added a comment.
In https://reviews.llvm.org/D23290#512346, @labath wrote:
> I think I have understood the situation a bit more now, so let me try to
> explain what is going on.
>
> In https://reviews.llvm.org/D23290#511683, @clayborg wrote:
>
> > Is this something the user is typing in
jingham added a comment.
The patch seems correct to me.
I don't have a strong opinion about std::vector vrs. SmallVector. These are
temporary objects, so the size of the container doesn't matter, and I doubt
this code is hot enough in normal lldb sessions that the difference between in
perfor
> On Aug 11, 2016, at 3:55 PM, Jim Ingham via lldb-commits
> wrote:
>
> jingham added a comment.
>
> The patch seems correct to me.
>
> I don't have a strong opinion about std::vector vrs. SmallVector. These are
> temporary objects, so the size of the container doesn't matter, and I doubt
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Ok. Jim says the patch is OK, so I will OK it also.
https://reviews.llvm.org/D23406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
I have no opposition to unit tests in general, but if somebody finds some free
time on their hands, it would be really great to make the option definition &
argument parsing available to the SB API's so that people could define real
lldb Python commands that did completion, help etc as an equal
27 matches
Mail list logo
