labath requested a review of this revision.
labath added a comment.
Sean, could you take a quick look at this one as well?
http://reviews.llvm.org/D17856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: labath
Date: Tue Jul 12 04:26:30 2016
New Revision: 275164
URL: http://llvm.org/viewvc/llvm-project?rev=275164&view=rev
Log:
Dwarf parser: don't lookup void typedefs in the DWO
Summary:
void typedefs do not have a DW_AT_type attribute, so we end up with an empty
encoding_uid
variable. Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275164: Dwarf parser: don't lookup void typedefs in the DWO
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22218?vs=63499&id=63657#toc
Repository:
rL LLVM
http://reviews.llv
Author: labath
Date: Tue Jul 12 04:37:55 2016
New Revision: 275165
URL: http://llvm.org/viewvc/llvm-project?rev=275165&view=rev
Log:
Fix a race on process exit
Summary:
Process::SetExitStatus was popping the process io handler and resetting
m_process_input_reader
shared pointer, which is not a s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275165: Fix a race on process exit (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22209?vs=63481&id=63659#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22209
Files:
lld
tberghammer updated this revision to Diff 63664.
tberghammer added a comment.
Add SBMemoryRegionInfo::GetName
http://reviews.llvm.org/D22219
Files:
docs/lldb-gdb-remote.txt
include/lldb/API/SBMemoryRegionInfo.h
include/lldb/Target/MemoryRegionInfo.h
packages/Python/lldbsuite/test/tools/
EwanCrawford abandoned this revision.
EwanCrawford added a comment.
Thanks for getting around to looking at this Sean, i'd forgotten about it.
Unfortunately the patch seems to have gone stale as the test case no longer
passes.
So i'm just going to close the review for now.
Repository:
rL LLVM
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D22213#480052, @labath wrote:
> Btw, I tried to make a unit test for this, but I could not get your meta test
> runner to work -- the existing test was failing for m
tfiala added a comment.
Looks like this one can be closed out, @spyffe?
Repository:
rL LLVM
http://reviews.llvm.org/D21152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Tue Jul 12 10:07:18 2016
New Revision: 275173
URL: http://llvm.org/viewvc/llvm-project?rev=275173&view=rev
Log:
[test] Fix category-based skipping
Summary:
LLDBTestResult.hardMarkAsSkipped marked the whole class as skipped when the
first class in the
test failed the category
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275173: [test] Fix category-based skipping (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D22213?vs=63487&id=63679#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22213
Fil
tfiala added a comment.
Did this one go in? If so, can we close the review?
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D21032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
labath created this revision.
labath added a reviewer: jasonmolenda.
labath added a subscriber: lldb-commits.
This adds the knowledge of the DW_CFA_GNU_args_size instruction to the eh_frame
parsing code.
Right now it is ignored as I am unsure how is it supposed to be handled, but
now we are at l
Author: labath
Date: Tue Jul 12 10:13:11 2016
New Revision: 275175
URL: http://llvm.org/viewvc/llvm-project?rev=275175&view=rev
Log:
[NPL] Increase ETXTBSY workaround sleep
10ms does not seem to be enough all the time, go to 50.
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeProcess
labath added a comment.
I used the command you mentioned in the original patch:
$ python -m unittest discover -s test/src -p 'Test*.py'
FF
==
FAIL: test_with_function_filter
(TestCatchInvalidDecorator.TestCatchInvalidDec
tfiala added a comment.
We have a separate configuration for that build in Xcode - it is called
DebugClang. You can build that configuration from the command line with
something like:
xcodebuild --scheme desktop --configuration DebugClang
or clone the "desktop" scheme in Xcode, setting the sc
Author: labath
Date: Tue Jul 12 11:06:31 2016
New Revision: 275185
URL: http://llvm.org/viewvc/llvm-project?rev=275185&view=rev
Log:
Increase "process load" timeout
Loading a dynamic library can take quite a long time, since it triggers a
number of
shared-library-event stops for dependent librar
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Many issues. See inlined comments.
Comment at: include/lldb/lldb-private-types.h:57-58
@@ -56,1 +56,4 @@
// ax, ah, and al.
+
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
As Todd said, we already have a "DebugClang" configuration for this. We should
abandon this change.
http://reviews.llvm.org/D22235
___
sas abandoned this revision.
sas added a comment.
Ah, makes sense, I had missed the `DebugClang` build configuration. Thanks for
pointing this out.
http://reviews.llvm.org/D22235
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
Author: ovyalov
Date: Tue Jul 12 13:14:27 2016
New Revision: 275198
URL: http://llvm.org/viewvc/llvm-project?rev=275198&view=rev
Log:
Add logging to Linux Host::GetProcessAndStatInfo.
Modified:
lldb/trunk/source/Host/linux/Host.cpp
Modified: lldb/trunk/source/Host/linux/Host.cpp
URL:
http:/
Author: enrico
Date: Tue Jul 12 13:33:52 2016
New Revision: 275199
URL: http://llvm.org/viewvc/llvm-project?rev=275199&view=rev
Log:
Tweaks to the NSIndexPath formatter to enhance stability
rdar://problem/25767901
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSIndexPath.cpp
Modified:
sas created this revision.
sas added reviewers: jingham, clayborg.
sas added a subscriber: lldb-commits.
The function FunctionCaller::WriteFunctionArguments returns false on
errors, so they should check for the false return value.
Change by Walter Erquinigo
http://reviews.llvm.org/D22278
Files
Author: spyffe
Date: Tue Jul 12 17:42:07 2016
New Revision: 275223
URL: http://llvm.org/viewvc/llvm-project?rev=275223&view=rev
Log:
Mark TagDecls as having external visible storage, like ContainerDecls.
The lookup tables can get out of date during the lifetime of the object so we
need to preserv
Author: gclayton
Date: Tue Jul 12 18:06:28 2016
New Revision: 275225
URL: http://llvm.org/viewvc/llvm-project?rev=275225&view=rev
Log:
This doesn't compiler on Darwin. Skipping it.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcp
Author: gclayton
Date: Tue Jul 12 18:07:50 2016
New Revision: 275226
URL: http://llvm.org/viewvc/llvm-project?rev=275226&view=rev
Log:
Remove assert since it was crashing the mutli process driver tests. Made the
code behave correctly when indexes are out of range or the collection is empty
and i
Argh, this isn’t what I wanted to commit AT ALL.
Sorry folks. I’ll fix this momentarily.
Thanks to Jim Ingham for pointing it out.
Sean
> On Jul 12, 2016, at 3:42 PM, Sean Callanan via lldb-commits
> wrote:
>
> Author: spyffe
> Date: Tue Jul 12 17:42:07 2016
> New Revision: 275223
>
> URL: h
Author: spyffe
Date: Tue Jul 12 18:31:42 2016
New Revision: 275237
URL: http://llvm.org/viewvc/llvm-project?rev=275237&view=rev
Log:
Revert r275223, which committed the wrong thing.
Modified:
lldb/trunk/lldb.xcworkspace/contents.xcworkspacedata
Modified: lldb/trunk/lldb.xcworkspace/contents.
Reverted with r275237.
Sean
> On Jul 12, 2016, at 4:33 PM, Sean Callanan wrote:
>
> Argh, this isn’t what I wanted to commit AT ALL.
> Sorry folks. I’ll fix this momentarily.
> Thanks to Jim Ingham for pointing it out.
>
> Sean
>
>> On Jul 12, 2016, at 3:42 PM, Sean Callanan via lldb-commits
ChuckR added a subscriber: ki.stfu.
ChuckR added a comment.
@abidh @ki.stfu Do you have any feedback? We would like to check this in and I
want to get more sign off then just me.
Repository:
rL LLVM
http://reviews.llvm.org/D21757
___
lldb-commit
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Comment at: include/lldb/Host/Editline.h:289
@@ +288,3 @@
+unsigned char
+EndOrAddLineCommand (int ch);
+
Will be good idea to not add space between name and arguments list in new code.
Same for o
fjricci created this revision.
fjricci added reviewers: clayborg, lattner.
fjricci added subscribers: sas, lldb-commits.
Herald added a subscriber: kubabrecka.
Clang supports symbol rewrites via the -frewrite-map-file flag,
this patch adds complementary functionality in lldb.
Re-written symbols a
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
This is fine - is there a binary using this? I'd love to see the assembly code
and a dump of the eh_frame CFI.
I googled around and didn't find much about DW_CFA_GNU_args_size but
33 matches
Mail list logo
