This revision was automatically updated to reflect the committed changes.
Closed by commit rL274831: [zorg] Remove flunkOnFailure=False from the scripted
LLDB builder unittests (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22097?vs=63086&id=63187#toc
Repository:
rL
labath added a comment.
Thanks for adding the additional checks. Looks good apart from the clang-format
changes. This looks like the llvm style. I am not sure how you've run this but
it does not seem to have picked up LLDB's `.clang-format` file.
Are you using git? You need to set `clangFormat.
nitesh.jain retitled this revision from "[LLDB][MIPS] Fix FPU Size Based on
Dynamic FR/FRE bit" to "[LLDB][MIPS] Fix FPU Size Based on Dynamic FR".
nitesh.jain updated the summary for this revision.
nitesh.jain updated this revision to Diff 63201.
nitesh.jain added a comment.
Update diff as per s
nitesh.jain marked 6 inline comments as done.
nitesh.jain added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain marked an inline comment as done.
nitesh.jain added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtIndex (re
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtInde
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtIndex (re
nitesh.jain removed rL LLVM as the repository for this revision.
nitesh.jain updated this revision to Diff 63224.
nitesh.jain added a comment.
Added lldb_private::RegisterInfo * DynamicRegisterInfo::GetRegisterInfoAtIndex
(uint32_t i)
http://reviews.llvm.org/D20357
Files:
include/lldb/lldb-
nitesh.jain marked an inline comment as done.
nitesh.jain added a comment.
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few fixes and this will be ready.
Comment at: include/lldb/lldb-forward.h:147
@@ -146,2 +146,3 @@
class ObjectFileJITDelegate;
+class OCamlASTContext
ovyalov added a comment.
In http://reviews.llvm.org/D22081#477746, @labath wrote:
> Thanks for adding the additional checks. Looks good apart from the
> clang-format changes. This looks like the llvm style. I am not sure how
> you've run this but it does not seem to have picked up LLDB's `.clan
ovyalov updated this revision to Diff 63255.
ovyalov added a comment.
Reran with proper clang-format.
http://reviews.llvm.org/D22081
Files:
source/Plugins/Platform/Android/AdbClient.cpp
source/Plugins/Platform/Android/AdbClient.h
source/Plugins/Platform/Android/PlatformAndroid.cpp
Index:
Author: ovyalov
Date: Fri Jul 8 12:45:37 2016
New Revision: 274895
URL: http://llvm.org/viewvc/llvm-project?rev=274895&view=rev
Log:
Use shell cat command as a workaround if ADB stat cannot lookup a file.
http://reviews.llvm.org/D22081
Modified:
lldb/trunk/source/Plugins/Platform/Android/A
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Users:
ovyalov (Author)
http://reviews.llvm.or
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: enrico
Date: Fri Jul 8 13:39:36 2016
New Revision: 274901
URL: http://llvm.org/viewvc/llvm-project?rev=274901&view=rev
Log:
Make IsSyntheticChildrenGenerated() virtual so that dynamic and synthetic
values can refer back to their parents
Modified:
lldb/trunk/include/lldb/Core/ValueO
Author: gclayton
Date: Fri Jul 8 18:06:38 2016
New Revision: 274948
URL: http://llvm.org/viewvc/llvm-project?rev=274948&view=rev
Log:
When calling "settings set target.source-map ", make sure
that exists before accepting it as a remapping.
We had some clients that had added old source paths r
18 matches
Mail list logo
