Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-07-01 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In http://reviews.llvm.org/D20464#471803, @Eugene.Zelenko wrote: > I see HAVE_CXX_ATOMICS64_WITHOUT_LIB messages during LLVM Cmake run, but I > don't see such message during LLDB CMake run. > > Is this value is supposed to be read form LLVM CMake cache? Yes. Repo

[Lldb-commits] [PATCH] D21923: Split TestTemplateIntegerArgs test into two

2016-07-01 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. One of the tests there does not work with gcc, so I'm spinning that off into a separate test, so that we can XFAIL it with more granularity. I am also renaming the test to reflect the fact t

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit

2016-07-01 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505 @@ +496,11 @@ + { +bool fre; +bool fr1; +IsFR1_FRE (fr1, fre); + +// fr1 fre fpu_reg_size +

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit

2016-07-01 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505 @@ +496,11 @@ + { +bool fre; +bool fr1; +IsFR1_FRE (fr1, fre); + +// fr1 fre fpu_reg_size +

[Lldb-commits] [lldb] r274364 - Skip TestDisassembleRawData when remote

2016-07-01 Thread Francis Ricci via lldb-commits
Author: fjricci Date: Fri Jul 1 11:47:44 2016 New Revision: 274364 URL: http://llvm.org/viewvc/llvm-project?rev=274364&view=rev Log: Skip TestDisassembleRawData when remote Summary: As this test will create a new target, it will cause all following tests to fail when running in platform mode, if

Re: [Lldb-commits] [PATCH] D21906: Skip TestDisassembleRawData when remote

2016-07-01 Thread Francis Ricci via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274364: Skip TestDisassembleRawData when remote (authored by fjricci). Changed prior to commit: http://reviews.llvm.org/D21906?vs=62406&id=62504#toc Repository: rL LLVM http://reviews.llvm.org/D2190

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit

2016-07-01 Thread Greg Clayton via lldb-commits
clayborg added a comment. There should be no need to add code on the lldb-server side. It would just send the DWARF expression bytes over when qRegisterInfo or the target xml is sent to the host. The host would store this expression and run it each time the register info is asked for for a regi

Re: [Lldb-commits] [PATCH] D21923: Split TestTemplateIntegerArgs test into two

2016-07-01 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D21923 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] r274366 - Added support for thread local variables on all Apple OS variants.

2016-07-01 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jul 1 12:17:23 2016 New Revision: 274366 URL: http://llvm.org/viewvc/llvm-project?rev=274366&view=rev Log: Added support for thread local variables on all Apple OS variants. We had support that assumed that thread local data for a variable could be determined solely f

[Lldb-commits] [lldb] r274374 - Try to fix Ubuntu buildbots after I broke thread local variables with 274366.

2016-07-01 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jul 1 13:22:01 2016 New Revision: 274374 URL: http://llvm.org/viewvc/llvm-project?rev=274374&view=rev Log: Try to fix Ubuntu buildbots after I broke thread local variables with 274366. Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSI

[Lldb-commits] [lldb] r274377 - Revert fix that didn't work. I will need to debug this on linux to figure things out.

2016-07-01 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jul 1 13:55:55 2016 New Revision: 274377 URL: http://llvm.org/viewvc/llvm-project?rev=274377&view=rev Log: Revert fix that didn't work. I will need to debug this on linux to figure things out. Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicL

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-07-01 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a comment. I run CMake with --trace and is mentioned only in condition added there. Repository: rL LLVM http://reviews.llvm.org/D20464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] r274388 - Thread local storage was already broken on Linux and the tests were passing because there was a dectorator:

2016-07-01 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jul 1 16:25:20 2016 New Revision: 274388 URL: http://llvm.org/viewvc/llvm-project?rev=274388&view=rev Log: Thread local storage was already broken on Linux and the tests were passing because there was a dectorator: @unitte

[Lldb-commits] [lldb] r274393 - Fixed thread local storage test case to run normally with no expected fail for Darwin, always skip on windows, and expected fail for all other OSs while mentioning the

2016-07-01 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jul 1 17:33:13 2016 New Revision: 274393 URL: http://llvm.org/viewvc/llvm-project?rev=274393&view=rev Log: Fixed thread local storage test case to run normally with no expected fail for Darwin, always skip on windows, and expected fail for all other OSs while mentioni

Re: [Lldb-commits] [PATCH] D21898: Enable test log collection from remote debug servers (take 2)

2016-07-01 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks good, Pavel! http://reviews.llvm.org/D21898 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman