[Lldb-commits] [lldb] r274116 - XFAIL tests which fail with gcc on linux

2016-06-29 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Jun 29 05:16:14 2016 New Revision: 274116 URL: http://llvm.org/viewvc/llvm-project?rev=274116&view=rev Log: XFAIL tests which fail with gcc on linux Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExprs.py lldb/trunk/

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-06-29 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, thanks. Repository: rL LLVM http://reviews.llvm.org/D20464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.o

Re: [Lldb-commits] [PATCH] D21770: Improve ADB utilization within Android platform

2016-06-29 Thread Pavel Labath via lldb-commits
labath added a comment. Is AdbClient getting big enough to deserve a couple of unit tests? All it would take is to add the ability to specify the address to connect to and make a small mock server that listens at that address? http://reviews.llvm.org/D21770 _

Re: [Lldb-commits] [PATCH] D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files.

2016-06-29 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. Please also add a test for this in `TestLinuxCore.py`. There shouldn't be a need to add a new core file, you can just add an additional check to the `do_test` method that verifies the right memory regions (which you can pass in the same

[Lldb-commits] [lldb] r274121 - [LLDB][MIPS] Check if libatomic needs to be specified explicitly

2016-06-29 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Jun 29 07:30:18 2016 New Revision: 274121 URL: http://llvm.org/viewvc/llvm-project?rev=274121&view=rev Log: [LLDB][MIPS] Check if libatomic needs to be specified explicitly Patch by Nitesh Jain. Summary : The problem appears while linking liblldb.so. The class Address

[Lldb-commits] [lldb] r274125 - Remove platform plugins from lldb-server

2016-06-29 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Jun 29 08:58:27 2016 New Revision: 274125 URL: http://llvm.org/viewvc/llvm-project?rev=274125&view=rev Log: Remove platform plugins from lldb-server Summary: This removes the last usage of Platform plugins in lldb-server -- it was used for launching child processes, wher

Re: [Lldb-commits] [PATCH] D20440: Remove platform plugins from lldb-server

2016-06-29 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274125: Remove platform plugins from lldb-server (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20440?vs=57807&id=62220#toc Repository: rL LLVM http://reviews.llvm.org/D2044

Re: [Lldb-commits] [PATCH] D21770: Improve ADB utilization within Android platform

2016-06-29 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a comment. In http://reviews.llvm.org/D21770#469876, @labath wrote: > Is AdbClient getting big enough to deserve a couple of unit tests? All it > would take is to add the ability to specify the address to connect to and > make a small mock server that listens at that address? It

Re: [Lldb-commits] [PATCH] D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files.

2016-06-29 Thread Howard Hellyer via lldb-commits
hhellyer added a comment. In http://reviews.llvm.org/D21751#468976, @clayborg wrote: > We should document the Process::GetMemoryRegionInfo() and what we expect of > it so that all plug-ins implement it correctly. I'll add a full comment in Process.h and I'll make sure the description matches

[Lldb-commits] [lldb] r274159 - Validate the option index before trying to access an array element using it - OptionArgElement can potentially use negative indices to mean interesting, but non option,

2016-06-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jun 29 15:23:03 2016 New Revision: 274159 URL: http://llvm.org/viewvc/llvm-project?rev=274159&view=rev Log: Validate the option index before trying to access an array element using it - OptionArgElement can potentially use negative indices to mean interesting, but non op

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-06-29 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This change broke standalone build. Looks like check which should set HAVE_CXX_ATOMICS64_WITHOUT_LIB was not performed. I build LLDB with LLVM STL which doesn't have libatomic. Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r274164 - Add NSTaggedPointerString to the table of data formatters

2016-06-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jun 29 16:00:18 2016 New Revision: 274164 URL: http://llvm.org/viewvc/llvm-project?rev=274164&view=rev Log: Add NSTaggedPointerString to the table of data formatters Fixes rdar://27002512 Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp Modified: