ravitheja added a comment.
Well its not possible for the assembly unwinder to do the correct thing in this
situation , as the function is entered through a stub function (which has push
instruction) and then a jump. The point of this patch is to catch when to use
the CFI or the assembly unwinde
omjavaid created this revision.
omjavaid added reviewers: labath, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
This patch adds logic to make sure we can install watchpoints at 1,2 and 4 byte
alligned addresses.
ptrace
nitesh.jain added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438
@@ +437,3 @@
+// The auxiliary vector consists of a sequence of key-value pairs, where
key and value are of
+// the pointer size for the architecture tha
hhellyer updated this revision to Diff 60517.
hhellyer added a comment.
Updated to rebase on the latest changes to MemoryRegionInfo.h
http://reviews.llvm.org/D20565
Files:
include/lldb/API/LLDB.h
include/lldb/API/SBDefines.h
include/lldb/API/SBMemoryRegionInfo.h
include/lldb/API/SBMemor
ravitheja updated this revision to Diff 60533.
ravitheja added a comment.
Making EH Frame CFI the full unwinder
when artificial symbols are found.
http://reviews.llvm.org/D21221
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
source/Plugins/DynamicLoader/POSIX-DYLD
ravitheja updated this revision to Diff 60539.
ravitheja added a comment.
Checks for nullptr
http://reviews.llvm.org/D21221
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
source/Plugins/Process/Uti
cameron314 created this revision.
cameron314 added reviewers: clayborg, labath, zturner.
cameron314 added a subscriber: lldb-commits.
This is the follow-up to D19122, which was accepted but subsequently reverted
due to a bug it introduced (that I didn't see during local testing on Windows
but wh
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Does this patch handle being able to share an 8 byte watchpoint between two
watchpoints? Lets say you have an 8 byte array named "a" and watch to watch
a[0] and a[3] and a[7]. You should b
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This looks like it would work for normal operation. I am not sure it will work
when an extra private state thread is spun up. In certain circumstances we need
to create more priv
cameron314 added a comment.
@clayborg: Thanks for having a look! I've added Jim Ingham as a reviewer.
@jingham, I'd appreciate if you could take a few minutes to look this over.
Right, I'd seen the backup/restore of the thread. As far as I can tell it
should still work; the code in `ControlPriv
clayborg added a comment.
Ok, as long as Jim agrees, then I will give it the go ahead.
http://reviews.llvm.org/D21296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This looks okay to me.
http://reviews.llvm.org/D21296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good if Jim is happy.
http://reviews.llvm.org/D21296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D21152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
The overall change looks good, but please also add a test which specifically
tests for watchpoints at unaligned addresses. Last time I checked, we all
watchpoint tests were passing (
Author: jmolenda
Date: Mon Jun 13 22:49:13 2016
New Revision: 272635
URL: http://llvm.org/viewvc/llvm-project?rev=272635&view=rev
Log:
Add support to PlatformRemoteiOS, PlatformRemoteAppleWatch, and
PlatformRemoteAppleTV to check the target.exec-search-paths
directories for files after looking in
labath added a comment.
I think this idea in general is more acceptable, but we'll need an OK from
Jason on the details.
Also, we should figure out a way to add a test for this. We should definitely
add a more deterministic test and not rely on TestPrintStackTraces to check
this functionality.
jasonmolenda added a comment.
Hi Ravi, sorry for not having time to look at this patch yet - I was out of the
office Friday and was catching up on everything today. I'll look at this
tomorrow. My initial reactions are to be a little worried. It sounds like you
have functions that are non-ABI
omjavaid added a comment.
In http://reviews.llvm.org/D21280#457196, @labath wrote:
> The overall change looks good, but please also add a test which specifically
> tests for watchpoints at unaligned addresses. Last time I checked, we all
> watchpoint tests were passing (at least on android) eve
19 matches
Mail list logo
