Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

2016-05-31 Thread Howard Hellyer via lldb-commits
hhellyer marked 2 inline comments as done. hhellyer added a comment. In http://reviews.llvm.org/D20565#442373, @clayborg wrote: > This looks good as long as SBMemoryRegionInfo and SBMemoryRegionInfoList are > ready only and will never have any setter functions. If we plan to ever have > the SBM

Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

2016-05-31 Thread Greg Clayton via lldb-commits
clayborg added a comment. In http://reviews.llvm.org/D20565#444223, @hhellyer wrote: > In http://reviews.llvm.org/D20565#442373, @clayborg wrote: > > > This looks good as long as SBMemoryRegionInfo and SBMemoryRegionInfoList > > are ready only and will never have any setter functions. If we plan

[Lldb-commits] [PATCH] D20826: [CMake] Update to retiring CMake 3.4.3

2016-05-31 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added a subscriber: lldb-commits. This is as per the discussions on developer lists: http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html http://reviews.llvm.org/D20826 Files: CMakeList

Re: [Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

2016-05-31 Thread Todd Fiala via lldb-commits
tfiala updated this revision to Diff 59105. tfiala added a comment. Updates per Greg. - Args::Dump(stream, label) now takes a default label. - Dropped the Args::Dump(stream) call. - Converted the Args stream parameter to a ref. It is not valid to call this without a stream. - Updated in-source

Re: [Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

2016-05-31 Thread Todd Fiala via lldb-commits
tfiala marked 2 inline comments as done. tfiala added a comment. Marked comments as done. http://reviews.llvm.org/D20722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r271312 - Implement ProcessInfo::Dump(), log gdb-remote stub launch

2016-05-31 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue May 31 13:32:20 2016 New Revision: 271312 URL: http://llvm.org/viewvc/llvm-project?rev=271312&view=rev Log: Implement ProcessInfo::Dump(), log gdb-remote stub launch This change implements dumping the executable, triple, args and environment when using ProcessInfo::Dump()

Re: [Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

2016-05-31 Thread Todd Fiala via lldb-commits
tfiala closed this revision. tfiala added a comment. Closed by commit r271312. http://reviews.llvm.org/D20722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r270891 - Make sure that we succeed in starting a definition before we complete it and emit an error if we fail to start the definition.

2016-05-31 Thread Ed Maste via lldb-commits
On 26 May 2016 at 15:24, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Thu May 26 14:24:02 2016 > New Revision: 270891 > > URL: http://llvm.org/viewvc/llvm-project?rev=270891&view=rev > Log: > Make sure that we succeed in starting a definition before we complete it and > emit an

Re: [Lldb-commits] [lldb] r270891 - Make sure that we succeed in starting a definition before we complete it and emit an error if we fail to start the definition.

2016-05-31 Thread Ed Maste via lldb-commits
On 31 May 2016 at 16:24, Ed Maste wrote: > > ../tools/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1762:61: > warning: data argument not used by format string [-Wformat-extra-args] > type_name_cstr); >

[Lldb-commits] [lldb] r271328 - [CMake] Update to requiring CMake 3.4.3

2016-05-31 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue May 31 15:21:44 2016 New Revision: 271328 URL: http://llvm.org/viewvc/llvm-project?rev=271328&view=rev Log: [CMake] Update to requiring CMake 3.4.3 Summary: This is as per the discussions on developer lists: http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h

Re: [Lldb-commits] [PATCH] D20826: [CMake] Update to retiring CMake 3.4.3

2016-05-31 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271328: [CMake] Update to requiring CMake 3.4.3 (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D20826?vs=59096&id=59124#toc Repository: rL LLVM http://reviews.llvm.org/D20

[Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Adrian Prantl via lldb-commits
aprantl created this revision. aprantl added reviewers: jingham, clayborg. aprantl added a subscriber: lldb-commits. aprantl set the repository for this revision to rL LLVM. Here's a fun little idea plus a preliminary patch implementing it. When I'm debugging programs I often wonder what exactly

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Jim Ingham via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks fine. Can you add a setting in the "stop-line" vein that will turn on and off the column listing. Seems odd to control all the other stuff, but not this. Repository:

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Adrian Prantl via lldb-commits
aprantl added a comment. I was also wondering if there was a preferred way to detect whether LLDB is connected to a dumb terminal. I noticed that Stream has an eANSI flag, but it seemed to be always zero. Repository: rL LLVM http://reviews.llvm.org/D20835

[Lldb-commits] [lldb] r271343 - Add more verification on consectutive bitfields otherwise clang will assert.

2016-05-31 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue May 31 17:29:56 2016 New Revision: 271343 URL: http://llvm.org/viewvc/llvm-project?rev=271343&view=rev Log: Add more verification on consectutive bitfields otherwise clang will assert. We need to verify that consecutive bitfields have higher offsets and don't overlap.

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Adrian Prantl via lldb-commits
aprantl added a subscriber: friss. aprantl removed rL LLVM as the repository for this revision. aprantl updated this revision to Diff 59141. aprantl added a comment. Added a use-column-info setting. http://reviews.llvm.org/D20835 Files: include/lldb/API/SBSourceManager.h include/lldb/Core/D

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Jim Ingham via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I wouldn't call the setting "use-column-info". It would be better to call it "stop-print-column-info" or something that makes it clear this is just for printing. If we get better

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Greg Clayton via lldb-commits
clayborg added a comment. "display-column-info"? http://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] LLVM buildmaster will be restarted tonight

2016-05-31 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thank you for understanding. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] Buildbot numbers for the last week of 5/22/2016 - 5/28/2016

2016-05-31 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 5/22/2016 - 5/28/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Jim Ingham via lldb-commits
All the other controls for printing the stop info have "stop-*". It would be clearer to keep doing this, I think. Jim > On May 31, 2016, at 4:30 PM, Greg Clayton wrote: > > clayborg added a comment. > > "display-column-info"? > > > http://reviews.llvm.org/D20835 > > > _

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. All the other controls for printing the stop info have "stop-*". It would be clearer to keep doing this, I think. Jim http://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Adrian Prantl via lldb-commits
aprantl updated this revision to Diff 59154. aprantl added a comment. Rename the property to "stop-show-column" and query the stream whether ansi escape sequences are allowed. http://reviews.llvm.org/D20835 Files: include/lldb/API/SBSourceManager.h include/lldb/Core/Debugger.h include/ll

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-05-31 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks fine to me. http://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma