labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks fine. Out of curiosity, where were the undefined symbols coming from? I'm
curious to know why they weren't showing up in none of our builds?
Repository:
rL LLVM
http://reviews.llvm.o
labath added a subscriber: labath.
labath added a comment.
I am glad to see more testing of the modules debugging. I have a couple of
small comments though:
- `-fmodules`: Why is it not being added to CXXFLAGS? Is this how clang is
supposed to be invoked? (I am not very familiar clang modules)
aprantl added a comment.
In http://reviews.llvm.org/D19998#423277, @labath wrote:
> I am glad to see more testing of the modules debugging. I have a couple of
> small comments though:
>
> - `-fmodules`: Why is it not being added to CXXFLAGS? Is this how clang is
> supposed to be invoked? (I am
tfiala added a comment.
> I propose that we be more aggressive in using it for new tests which do not
> specifically test debug info.
I totally agree, but I also caution that, as a debugger, the heart of much of
what we do does use debug info. So we need to be careful to make sure that we
Eugene.Zelenko added a comment.
Undefined symbols were used in clang::CodeGen::CoverageMappingGen.
Repository:
rL LLVM
http://reviews.llvm.org/D19991
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: eugenezelenko
Date: Fri May 6 12:03:09 2016
New Revision: 268750
URL: http://llvm.org/viewvc/llvm-project?rev=268750&view=rev
Log:
Fix standalone build on RHEL6.
Differential revision: http://reviews.llvm.org/D19991
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
Modified: lldb/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268750: Fix standalone build on RHEL6. (authored by
eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D19991?vs=56330&id=56430#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19991
Author: compnerd
Date: Fri May 6 12:32:58 2016
New Revision: 268755
URL: http://llvm.org/viewvc/llvm-project?rev=268755&view=rev
Log:
debugserver: fix some -Wformat-pedantic warnings
Perform explicit casts for the log message to address some `-Wformat-pedantic`
warnings from clang. NFC.
Modifi
Author: compnerd
Date: Fri May 6 12:33:01 2016
New Revision: 268756
URL: http://llvm.org/viewvc/llvm-project?rev=268756&view=rev
Log:
debugserver: fix a few -Wcovered-swift-default warnings
Remove a couple of `default` cases from switches which are covered. This is
beneficial since it would all
Author: compnerd
Date: Fri May 6 12:33:13 2016
New Revision: 268759
URL: http://llvm.org/viewvc/llvm-project?rev=268759&view=rev
Log:
debugserver; fix -Wunused-local-typedef, -Wunused-variable warnings
Remove the typedef and local structure which was unused. Fixes last of the new
clang warnings
Author: compnerd
Date: Fri May 6 12:33:04 2016
New Revision: 268757
URL: http://llvm.org/viewvc/llvm-project?rev=268757&view=rev
Log:
debugserver: fix some -Wpessimizing-move warnings
Remove the unnecessary use of std::move to permit the compiler to perform NVRO
instead. Fixes more warnings fro
Author: compnerd
Date: Fri May 6 12:33:09 2016
New Revision: 268758
URL: http://llvm.org/viewvc/llvm-project?rev=268758&view=rev
Log:
debugserver: fix a couple of -Wmissing-field-initializers warnings
Explicitly provide an initializer for the std::vector in the constructed type.
Addresses -Wmiss
labath added a comment.
In http://reviews.llvm.org/D19998#423541, @aprantl wrote:
> In http://reviews.llvm.org/D19998#423277, @labath wrote:
>
> > I am glad to see more testing of the modules debugging. I have a couple of
> > small comments though:
> >
> > - `-fmodules`: Why is it not being adde
Author: zturner
Date: Fri May 6 16:35:47 2016
New Revision: 268802
URL: http://llvm.org/viewvc/llvm-project?rev=268802&view=rev
Log:
Fix LLDB after removal of PDB_ErrorCode
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
Modified: lldb/trunk/source/Plugins/SymbolFile/PD
ted created this revision.
ted added a reviewer: jingham.
ted added a subscriber: lldb-commits.
new StackFrame objects created in StackFrameList::GetFramesUpTo are constructed
with SymbolContext set to nullptr, except for inline frames. Calling the ctor
with nullptr causes StackFrame::GetSymbolC
Author: jingham
Date: Fri May 6 18:44:10 2016
New Revision: 268823
URL: http://llvm.org/viewvc/llvm-project?rev=268823&view=rev
Log:
Fix the way the ShouldStopHere checker handles the general case of "stepping
through line 0 code".
That's good 'cause it means all the different kinds of source
Author: jingham
Date: Fri May 6 19:52:18 2016
New Revision: 268827
URL: http://llvm.org/viewvc/llvm-project?rev=268827&view=rev
Log:
Remove some lldbassert's from the packet checking code.
Greg says he doesn't need these asserts anymore and since they cause occasional
test suite
crashes, out th
Author: jingham
Date: Fri May 6 19:54:56 2016
New Revision: 268828
URL: http://llvm.org/viewvc/llvm-project?rev=268828&view=rev
Log:
Take the API lock in SBThread::IsValid & SBFrame::IsValid.
The IsValid calls can try to reconstruct the thread & frame, which can
take various internal locks. Th
stigger created this revision.
stigger added a reviewer: zturner.
stigger added a subscriber: lldb-commits.
- File path comparisons should be case-insensitive on OS X
- Fixed TestBreakpointCaseSensitivity
http://reviews.llvm.org/D20041
Files:
include/lldb/Host/FileSpec.h
packages/Python/ll
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
I don't know if this is a safe change. Mac OS X filesystems like HFS Plus may
be case-insensitive (but case preserving) or they may be case sensitive.
Network filesystems mounted on a Mac may be case sensitive. Witho
stigger added a comment.
These are valid points, but they apply to Linux and Windows as well: nothing
prevents you from mounting a case-insensitive FS on Linux or a case-sensitive
network share on Windows. However, in most cases the file system is going to be
case-sensitive on Linux and case-in
jasonmolenda added a comment.
Agreed, filesystems are almost always case sensitive on mac/ios. I'd hate for
anyone to make the assumption that it's always the case, though - I work with
network filesystems that are case sensitive every day so I'm very aware of the
possibility. :)
http://revi
22 matches
Mail list logo
