[Lldb-commits] [lldb] r267688 - Fix compiler warnings in SymbolFilePDBTests

2016-04-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 27 05:40:52 2016 New Revision: 267688 URL: http://llvm.org/viewvc/llvm-project?rev=267688&view=rev Log: Fix compiler warnings in SymbolFilePDBTests Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolFile/PDB/

[Lldb-commits] [lldb] r267704 - Remove flaky decorator from three tests on linux

2016-04-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 27 07:43:37 2016 New Revision: 267704 URL: http://llvm.org/viewvc/llvm-project?rev=267704&view=rev Log: Remove flaky decorator from three tests on linux The flakyness is no longer reproducible, and the tests seem to be passing reliably now. Modified: lldb/trunk

[Lldb-commits] [lldb] r267726 - Decorate TSan tests with "@skipUnlessThreadSanitizer" which skips the tests if the selected compiler can't compile with "-fsanitize=thread".

2016-04-27 Thread Kuba Brecka via lldb-commits
Author: kuba.brecka Date: Wed Apr 27 10:26:27 2016 New Revision: 267726 URL: http://llvm.org/viewvc/llvm-project?rev=267726&view=rev Log: Decorate TSan tests with "@skipUnlessThreadSanitizer" which skips the tests if the selected compiler can't compile with "-fsanitize=thread". Modified: ll

[Lldb-commits] [lldb] r267741 - Use absolute module path when possible if sent in svr4 packets

2016-04-27 Thread Francis Ricci via lldb-commits
Author: fjricci Date: Wed Apr 27 12:10:15 2016 New Revision: 267741 URL: http://llvm.org/viewvc/llvm-project?rev=267741&view=rev Log: Use absolute module path when possible if sent in svr4 packets Summary: If the remote uses svr4 packets to communicate library info, the LoadUnload tests will fail

Re: [Lldb-commits] [PATCH] D19557: Use absolute module path when possible if sent in svr4 packets

2016-04-27 Thread Francis Ricci via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267741: Use absolute module path when possible if sent in svr4 packets (authored by fjricci). Changed prior to commit: http://reviews.llvm.org/D19557?vs=55083&id=55253#toc Repository: rL LLVM http:/

[Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2016-04-27 Thread Stephane Sezer via lldb-commits
sas created this revision. sas added a reviewer: zturner. sas added a subscriber: lldb-commits. http://reviews.llvm.org/D19603 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp =

[Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-04-27 Thread Stephane Sezer via lldb-commits
sas created this revision. sas added a reviewer: zturner. sas added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This is required to start debugging WinPhone ARM targets. http://reviews.llvm.org/D19604 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp I

Re: [Lldb-commits] [PATCH] D6959: LLDB Help Improvements

2016-04-27 Thread Kate Stone via lldb-commits
k8stone closed this revision. k8stone added a comment. Long since complete. http://reviews.llvm.org/D6959 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r267749 - Renamed system plugin directory to address https://bugs.swift.org/browse/SR-1093

2016-04-27 Thread Kate Stone via lldb-commits
Author: kate Date: Wed Apr 27 12:49:51 2016 New Revision: 267749 URL: http://llvm.org/viewvc/llvm-project?rev=267749&view=rev Log: Renamed system plugin directory to address https://bugs.swift.org/browse/SR-1093 Modified: lldb/trunk/source/Host/linux/HostInfoLinux.cpp Modified: lldb/trunk/s

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2016-04-27 Thread Zachary Turner via lldb-commits
zturner added a reviewer: clayborg. zturner added a comment. +greg. I thought I remember Greg saying that that offsets were supposed to be RVAs, not VAs. Am I wrong here? http://reviews.llvm.org/D19603 ___ lldb-commits mailing list lldb-commits@l

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2016-04-27 Thread Stephane Sezer via lldb-commits
sas added a comment. @zturner, you might be right, I might have to change the code I have to load the initial executable's `Module` and use an offset different than 0 there. I'll wait to see what @clayborg says. http://reviews.llvm.org/D19603 ___

[Lldb-commits] [PATCH] D19606: XFail TestLambdas.py on Windows after fixing some of the problems

2016-04-27 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: spyffe. amccarth added a subscriber: lldb-commits. 1. Fixed semicolon placement in the lambda in the test itself. 2. Fixed lldbinline tests in general so that we don't attempt tests on platforms that don't use the given type of debug i

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-04-27 Thread Renato Golin via lldb-commits
rengolin added reviewers: omjavaid, compnerd. rengolin added a comment. Nice! LLDB on ARM Windows! :) Adding Omair and Saleem to approve, as hard-coding the triple may bring unwanted consequences. http://reviews.llvm.org/D19604 ___ lldb-commits ma

[Lldb-commits] [PATCH] D19608: Checkout release_38 branches of llvm and clang when building lldb 3.8

2016-04-27 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, jasonmolenda. fjricci added subscribers: hans, sas, lldb-commits. This commit is intended only for the release_38 branch, not for master. Fixes xcodebuild for the release_38 branch, since llvm and clang must be on the same branch a

[Lldb-commits] [lldb] r267768 - Added a testcase for the IR interpreter, ensuring that it behaves like the JIT.

2016-04-27 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Apr 27 14:37:42 2016 New Revision: 267768 URL: http://llvm.org/viewvc/llvm-project?rev=267768&view=rev Log: Added a testcase for the IR interpreter, ensuring that it behaves like the JIT. Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/ir-interpr

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2016-04-27 Thread Greg Clayton via lldb-commits
clayborg added a comment. "offset" here must be a file address, or a virtual address as the file's sections know it. So if you take "offset" and look it up in the sections for the COFF file, it should be a correct address. I don't know what "m_coff_header_opt.image_base" is, but as along as ent

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2016-04-27 Thread Zachary Turner via lldb-commits
zturner added a comment. image base is the address that the process should be loaded to in memory. But this is only a hint anyway, and a process might end up being loaded at a different address. So now that I think about it, this is wrong no matter what because even if you did want a virtual

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2016-04-27 Thread Greg Clayton via lldb-commits
clayborg added a comment. Let me clarify a few things. A "file address" is an address (lldb::addr_t) that gets translated into a section + offset address (lldb_private::Address which contains a lldb_private::Section + offset. Any addresses coming from ObjectFile parsers must be made into lldb_p

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2016-04-27 Thread Greg Clayton via lldb-commits
clayborg added a comment. Example code to resolve this would be: Address entry_addr = objfile->GetEntryPointAddress(); lldb::addr_t entry_load_addr = entry_addr.GetLoadAddress(target); if (entry_load_addr != LLDB_INVALID_ADDRESS) { // We were able to resolve the address as the

[Lldb-commits] [PATCH] D19626: XFail TestIRInterpreter on Windows

2016-04-27 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: spyffe. amccarth added a subscriber: lldb-commits. Test relies on a POSIX-only function `getpid()`, so the expression on Windows gets an undefined symbol. If you substitute `_getpid()`, the interpreter complains that it uses an opcode i

[Lldb-commits] [lldb] r267800 - XFail TestIRInterpreter on Windows

2016-04-27 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Wed Apr 27 16:53:19 2016 New Revision: 267800 URL: http://llvm.org/viewvc/llvm-project?rev=267800&view=rev Log: XFail TestIRInterpreter on Windows There's an open bug with calling functions in the inferior. And Windows doesn't have the POSIX function getpid(). Differenti

Re: [Lldb-commits] [PATCH] D19626: XFail TestIRInterpreter on Windows

2016-04-27 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267800: XFail TestIRInterpreter on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19626?vs=55326&id=55333#toc Repository: rL LLVM http://reviews.llvm.org/D19626 F

[Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

2016-04-27 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: granata.enrico, zturner. fjricci added subscribers: sas, lldb-commits. This should make TestCommandScriptImmediateOutput more consistent with the rest of the test suite. http://reviews.llvm.org/D19633 Files: packages/Python/lldbsuite/tes

Re: [Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

2016-04-27 Thread Zachary Turner via lldb-commits
You can probably remove the expected failure windows if this is no longer going to be a pexpect test. On Wed, Apr 27, 2016 at 3:14 PM Francis Ricci wrote: > fjricci created this revision. > fjricci added reviewers: granata.enrico, zturner. > fjricci added subscribers: sas, lldb-commits. > > This

Re: [Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

2016-04-27 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 55340. fjricci added a comment. Remove windows expected failure http://reviews.llvm.org/D19633 Files: packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py Index: packages/Python/lldbsuite/te

Re: [Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

2016-04-27 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Why are we trying to do this in the first place? The entire purpose of this test is to verify the immediate output to the console. If you want to test the output to a file instead, make a separate test case, that would be fine. But I'd rather much leave this tes

Re: [Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

2016-04-27 Thread Francis Ricci via lldb-commits
fjricci added a comment. As of r264351, this test already writes to both the console and to files (since the file writing is testing the same python file io bugs tested by the console writing). I can make another patch to split it out if that's preferable. However, this patch is intended to mov

Re: [Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

2016-04-27 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. My personal preference would be to split up the test cases. I'd really like to keep testing the immediate output to console scenario since it is interesting for - e.g. - kernel debugging at Apple. http://reviews.llvm.org/D19633 ___

[Lldb-commits] [lldb] r267833 - Fixed a bug where const this would cause parser errors about $__lldb_expr.

2016-04-27 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Apr 27 20:36:21 2016 New Revision: 267833 URL: http://llvm.org/viewvc/llvm-project?rev=267833&view=rev Log: Fixed a bug where const this would cause parser errors about $__lldb_expr. In templated const functions, trying to run an expression would produce the error error:

[Lldb-commits] [lldb] r267834 - Add the ability to limit "source regexp" breakpoints to a particular function

2016-04-27 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Apr 27 20:40:57 2016 New Revision: 267834 URL: http://llvm.org/viewvc/llvm-project?rev=267834&view=rev Log: Add the ability to limit "source regexp" breakpoints to a particular function within a source file. This isn't done, I need to make the name match smarter (right n

[Lldb-commits] [lldb] r267842 - Fix an inefficiency in the handling of $__lldb_local_vars in expressions.

2016-04-27 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Apr 27 21:17:02 2016 New Revision: 267842 URL: http://llvm.org/viewvc/llvm-project?rev=267842&view=rev Log: Fix an inefficiency in the handling of $__lldb_local_vars in expressions. The code in ClangExpressionDeclMap::FindExternalVisibleDecls figures out what the token