Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

2016-04-21 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. A producer string would be excellent but I know it is not easy to add it to all part of the toolchain. In case of development compilers I would suggest to add the version number of the nex

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-21 Thread Jonas Hahnfeld via lldb-commits
Hahnfeld added a comment. In http://reviews.llvm.org/D18848#406521, @labath wrote: > In http://reviews.llvm.org/D18848#406509, @zturner wrote: > > > I was under the impression the make build was officially unsupported/dead? > > > You can still cmake to generate makefiles (and it does that by defa

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-21 Thread Zachary Turner via lldb-commits
It should be fixed now, please sync and try again On Thu, Apr 21, 2016 at 4:04 AM Jonas Hahnfeld wrote: > Hahnfeld added a comment. > > In http://reviews.llvm.org/D18848#406521, @labath wrote: > > > In http://reviews.llvm.org/D18848#406509, @zturner wrote: > > > > > I was under the impression the

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-21 Thread Zachary Turner via lldb-commits
zturner added a comment. It should be fixed now, please sync and try again http://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r267000 - Host: fix some -Wformat-pedantic warnings

2016-04-21 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Apr 21 11:55:58 2016 New Revision: 267000 URL: http://llvm.org/viewvc/llvm-project?rev=267000&view=rev Log: Host: fix some -Wformat-pedantic warnings Add explicit casts for function pointer to void * for %p conversion. NFC. Modified: lldb/trunk/source/Host/macosx/

[Lldb-commits] [lldb] r267001 - API: fix a -Wunused-variable warning

2016-04-21 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Apr 21 11:56:02 2016 New Revision: 267001 URL: http://llvm.org/viewvc/llvm-project?rev=267001&view=rev Log: API: fix a -Wunused-variable warning expr_log is only conditionally used via preprocessing. Ensure that we guard the definition accordingly. NFC. Modified:

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

2016-04-21 Thread Ryan Brown via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267048: Update Go OS Plugin for newer runtimes. (authored by ribrdb). Changed prior to commit: http://reviews.llvm.org/D19273?vs=54427&id=54572#toc Repository: rL LLVM http://reviews.llvm.org/D19273

[Lldb-commits] [lldb] r267048 - Update Go OS Plugin for newer runtimes.

2016-04-21 Thread Ryan Brown via lldb-commits
Author: ribrdb Date: Thu Apr 21 15:57:28 2016 New Revision: 267048 URL: http://llvm.org/viewvc/llvm-project?rev=267048&view=rev Log: Update Go OS Plugin for newer runtimes. Differential Revision: http://reviews.llvm.org/D19273 Modified: lldb/trunk/source/Plugins/OperatingSystem/Go/OperatingS