Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-04 Thread Pavel Labath via lldb-commits
labath added a comment. In http://reviews.llvm.org/D18519#390337, @eran.ifrah wrote: > Spoke too soon, the hack into `CMakeLists.txt` is still needed > Passing ` -mbig-obj` crashes `ld.exe` (although it crashes in a much later > stage, at about 77% in the build) Clang only puts /bigobj on a

[Lldb-commits] [lldb] r265294 - Fix flakyness in TestWatchpointMultipleThreads

2016-04-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Apr 4 09:18:21 2016 New Revision: 265294 URL: http://llvm.org/viewvc/llvm-project?rev=265294&view=rev Log: Fix flakyness in TestWatchpointMultipleThreads This addresses the same problem as r264846 (the test not expecting the situation when two thread hit the watchpoint

[Lldb-commits] [lldb] r265299 - Make FileSpec handling platform-independent

2016-04-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Apr 4 09:39:12 2016 New Revision: 265299 URL: http://llvm.org/viewvc/llvm-project?rev=265299&view=rev Log: Make FileSpec handling platform-independent Summary: Even though FileSpec attempted to handle both kinds of path syntaxes (posix and windows) on both platforms, it

Re: [Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

2016-04-04 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265299: Make FileSpec handling platform-independent (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18689?vs=52348&id=52556#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r265308 - Set the architecture type from minidump more precisely. Differentiate i686 v i386 when possible.

2016-04-04 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Mon Apr 4 11:41:16 2016 New Revision: 265308 URL: http://llvm.org/viewvc/llvm-project?rev=265308&view=rev Log: Set the architecture type from minidump more precisely. Differentiate i686 v i386 when possible. Modified: lldb/trunk/source/Plugins/Process/Windows/MiniDum

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

2016-04-04 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 52572. labath added a comment. Address review comments. http://reviews.llvm.org/D18697 Files: include/lldb/Target/Process.h packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py packages/Python/lldbsuite/test/functional

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

2016-04-04 Thread Pavel Labath via lldb-commits
labath marked an inline comment as done. labath added a comment. I have also added a test which loads two core files with the same pid. (Based on very little experimentation) everything seems to be working ok for that case. Comment at: source/Plugins/Process/elf-core/ProcessElf

[Lldb-commits] [lldb] r265315 - Xcode: modify lldb-python-test-suite target to build inferiors with $(LLDB_PYTHON_TESTSUITE_CC)

2016-04-04 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Apr 4 12:15:57 2016 New Revision: 265315 URL: http://llvm.org/viewvc/llvm-project?rev=265315&view=rev Log: Xcode: modify lldb-python-test-suite target to build inferiors with $(LLDB_PYTHON_TESTSUITE_CC) $(LLDB_PYTHON_TESTSUITE_CC) defaults to the just-built clang. Toge

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 52588. amccarth added a comment. OK, this now dumps headers for the ObjectFiles of the modules rather than the modules themselves, using `target modules dump objfile` as suggested. My only concern here is that the SB API has a module dump, but no object fil

[Lldb-commits] [lldb] r265340 - Xcode: run gtests when building the lldb-gtest target

2016-04-04 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Apr 4 14:40:29 2016 New Revision: 265340 URL: http://llvm.org/viewvc/llvm-project?rev=265340&view=rev Log: Xcode: run gtests when building the lldb-gtest target This addresses the following task: https://llvm.org/bugs/show_bug.cgi?id=27181 Xcode gtests: ensure they run,

[Lldb-commits] [lldb] r265342 - disabled TSAN tests until the author can help track down CI failures

2016-04-04 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Apr 4 14:58:24 2016 New Revision: 265342 URL: http://llvm.org/viewvc/llvm-project?rev=265342&view=rev Log: disabled TSAN tests until the author can help track down CI failures These tests run fine locally for me but are failing on the Green Dragon OS X CI. Modified:

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Close, we just need to remove the "Headers for" string. See inlined comment. Comment at: source/Commands/CommandObjectTarget.cpp:1568 @@ +1567,3 @@ +

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 52618. amccarth added a comment. Removed the "headers for" string, but kept the name of the file, as not all of the ObjectFile::Dump implementations (e.g., ELF) print the file name. http://reviews.llvm.org/D18464 Files: source/Commands/CommandObjectTarg

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Commands/CommandObjectTarget.cpp:1568 @@ +1567,3 @@ +ObjectFile *objfile = module->GetObjectFile(); +

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Adrian McCarthy via lldb-commits
amccarth added inline comments. Comment at: source/Commands/CommandObjectTarget.cpp:1568 @@ +1567,3 @@ +ObjectFile *objfile = module->GetObjectFile(); +strm.Printf("'%s':\n", objfile->GetFileSpec().GetCString()); +strm.IndentMore();

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 52624. amccarth added a comment. Removed the per-file header from the common code and make the ObjectFileELF::Dump print its own header like the others. http://reviews.llvm.org/D18464 Files: source/Commands/CommandObjectTarget.cpp source/Plugins/Objec

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Thanks for making all the changes. http://reviews.llvm.org/D18464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-04 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265349: Implement `target modules dump objfile` (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D18464?vs=52624&id=52626#toc Repository: rL LLVM http://reviews.llvm.org/D184

[Lldb-commits] [lldb] r265349 - Implement `target modules dump objfile`

2016-04-04 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Mon Apr 4 16:21:49 2016 New Revision: 265349 URL: http://llvm.org/viewvc/llvm-project?rev=265349&view=rev Log: Implement `target modules dump objfile` Differential Revision: http://reviews.llvm.org/D18464 Modified: lldb/trunk/source/Commands/CommandObjectTarget.cpp

[Lldb-commits] [lldb] r265357 - Improve the way LLDB escapes arguments before passing them to the shell

2016-04-04 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Apr 4 17:46:38 2016 New Revision: 265357 URL: http://llvm.org/viewvc/llvm-project?rev=265357&view=rev Log: Improve the way LLDB escapes arguments before passing them to the shell Teach LLDB that different shells have different characters they are sensitive to, and use t

[Lldb-commits] [PATCH] D18779: Fix dotest.py '-p' option for multi-process mode

2016-04-04 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: zturner, tfiala. fjricci added subscribers: sas, lldb-commits. The '-p' option for dotest.py was ignored in multiprocess mode, as the -p argument to the inferior would overwrite the -p argument passed on the command line. http://reviews.llvm

Re: [Lldb-commits] [PATCH] D18779: Fix dotest.py '-p' option for multi-process mode

2016-04-04 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. That looks fine. Thanks for the fix! http://reviews.llvm.org/D18779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

[Lldb-commits] [lldb] r265377 - Consolidate the knowledge of what arm cores are always executing

2016-04-04 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Apr 5 00:01:30 2016 New Revision: 265377 URL: http://llvm.org/viewvc/llvm-project?rev=265377&view=rev Log: Consolidate the knowledge of what arm cores are always executing in thumb mode into one method in ArchSpec, replace checks for specific cores in the disassembler w