nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain updated this revision to Diff 52177.
nitesh.jain added a comment.
Corrected formatting issue
Repository:
rL LLVM
http://reviews.llvm.org/D18638
Files:
include/lldb/Core/ArchSpec.h
source/Core/ArchSpec.cpp
source/P
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
Looks good but I don't understand why android is working while other linux
platforms isn't.
http://reviews.llvm.org/D18631
___
lldb-commits
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good (I don't like the syntax with a class level variable but don't know
any better one as using decorators for this would be very difficult)
http://reviews.llvm.org/D18598
labath created this revision.
labath added reviewers: tberghammer, clayborg.
labath added a subscriber: lldb-commits.
In case of Dwo, DIERef stores a compile unit offset in the main object file,
and not in the dwo.
The implementation of SymbolFileDWARFDwo::GetDIE inherited from SymbolFileDWARF
t
fjricci added a comment.
android is detected from the ELF, so we can get around using the gdb-remote
info.
http://reviews.llvm.org/D18631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D18646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: labath
Date: Thu Mar 31 08:30:04 2016
New Revision: 265011
URL: http://llvm.org/viewvc/llvm-project?rev=265011&view=rev
Log:
Fix DWO breakage in r264909
Summary:
In case of Dwo, DIERef stores a compile unit offset in the main object file,
and not in the dwo.
The implementation of SymbolF
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265011: Fix DWO breakage in r264909 (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18646?vs=52196&id=52198#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18646
Files:
ll
labath added a subscriber: labath.
labath added a comment.
Cyclic code dependencies are not an imaginary problem. Right now, it is very
hard to make lldb-server small, because everything in lldb depends on
everything else, and so lldb-server ends up containing chunks e.g. clang, even
though tha
Author: labath
Date: Thu Mar 31 09:22:52 2016
New Revision: 265017
URL: http://llvm.org/viewvc/llvm-project?rev=265017&view=rev
Log:
Don't vary debug info for lldb-server tests
Summary:
Debug info is used only by the client and lldb-server tests do not even have
the client component
running, as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265017: Don't vary debug info for lldb-server tests
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18598?vs=52058&id=52203#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I question if ArchSpec::GetClangTargetABI() belongs in ArchSpec. It is very
clang specific. Should this just be a function in ClangExpressionParser? Like:
static std::string
clayborg added a comment.
See inlined comment for a follow up fix.
Comment at:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:136
@@ +135,3 @@
+{
+assert(m_base_dwarf_cu->GetOffset() == die_ref.cu_offset);
+return DebugInfo()->GetDIEForDIEOffset(die_r
tberghammer added inline comments.
Comment at:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:136
@@ +135,3 @@
+{
+assert(m_base_dwarf_cu->GetOffset() == die_ref.cu_offset);
+return DebugInfo()->GetDIEForDIEOffset(die_ref.die_offset);
c
clayborg added a comment.
I don't mind asserts when they shouldn't happen if they are lldbassert calls
since these are removed for release builds, but we can't just call assert and
crash because something bad happened. LLDB is a shared library and a framework
and it shouldn't crash no matter wh
I don't agree that asserts are good in released code unless you have no way of
backing out of the situation you find yourself in. After all, you are saying
to some unlucky user out there that they can't use the debugger on their app
and in general there's nothing they can do about it. Greg's s
jingham added a subscriber: jingham.
jingham added a comment.
I don't agree that asserts are good in released code unless you have no way of
backing out of the situation you find yourself in. After all, you are saying
to some unlucky user out there that they can't use the debugger on their app
I think it depends on how bad the thing that happens is. If you are out of
memory, sure you can assert. If a syscall fails that is supposed to never
fail, you can assert. But if one piece of debug info appears corrupt, I
don't think it's worth bringing down the whole process, which could be an
e
> On Mar 31, 2016, at 11:15 AM, Zachary Turner via lldb-commits
> wrote:
>
> I think it depends on how bad the thing that happens is. If you are out of
> memory, sure you can assert. If a syscall fails that is supposed to never
> fail, you can assert.
Admittedly, if you’re out of memory t
Moving lldb out of process is a worthy effort, but it is only a partial
solution. We do a lot of things on the users behalf, and if one of these
crashes without really giving the user insight into how to avoid the crash,
while it's great that we didn't also lose some editing changes they had in
fjricci created this revision.
fjricci added reviewers: spyffe, jingham, Eugene.Zelenko.
fjricci added subscribers: sas, lldb-commits.
Flag updated in D233237
http://reviews.llvm.org/D18660
Files:
source/Commands/CommandObjectWatchpoint.cpp
Index: source/Commands/CommandObjectWatchpoint.cpp
=
This assert isn't checking for the correctness of the debug info (what is a
program input). It is checking that we passed the DIERef to the correct
SymbolFileDWARFDwo instance what is the contract of the API and should be
checked by an assert. This assert will only fire if we have a bug in LLDB
reg
It's a double edged sword though. If you disable them, then sure you don't
crash anymore, but now you don't know when issues actually do happen
because, well, they're disabled. That's why I actually like lldbassert.
You get all the benefits of the assertion such as knowing when bugs happen,
but w
> On Mar 31, 2016, at 11:51 AM, Tamas Berghammer wrote:
>
> This assert isn't checking for the correctness of the debug info (what is a
> program input). It is checking that we passed the DIERef to the correct
> SymbolFileDWARFDwo instance what is the contract of the API and should be
> check
Author: gclayton
Date: Thu Mar 31 19:41:29 2016
New Revision: 265086
URL: http://llvm.org/viewvc/llvm-project?rev=265086&view=rev
Log:
Fixed an issue that could cause debugserver to return two stop reply packets
($T packets) for one \x03 interrupt. The problem was that when a \x03 byte is
sent t
nitesh.jain added a comment.
Yes this function is clang specific(even GetClangTargetCPU) .Will update the
diff as per suggestion.
Thanks
Repository:
rL LLVM
http://reviews.llvm.org/D18638
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
26 matches
Mail list logo
