Author: labath
Date: Wed Mar 30 03:43:54 2016
New Revision: 264846
URL: http://llvm.org/viewvc/llvm-project?rev=264846&view=rev
Log:
Fix flakyness in TestWatchpointMultipleThreads
Summary:
the inferior in the test deliberately does not lock a mutex when accessing the
watched variable.
The reason
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264846: Fix flakyness in TestWatchpointMultipleThreads
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18558?vs=51929&id=52028#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: labath
Date: Wed Mar 30 03:45:37 2016
New Revision: 264847
URL: http://llvm.org/viewvc/llvm-project?rev=264847&view=rev
Log:
Fix warning in ClangExpressionParser
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/source/Plugins/
tberghammer added a reviewer: ted.
tberghammer added a comment.
Looks good (I added Ted as a reviewer for hexagon).
http://reviews.llvm.org/D18531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tberghammer added a comment.
I would prefer a more general solution then the one Pavel proposed because
currently we are adding 2 more options (abi and isa) but in the future we might
need a lot of other stuff as well and adding a new argument for each one will
be problematic (e.g. omit frame p
Author: labath
Date: Wed Mar 30 04:42:59 2016
New Revision: 264849
URL: http://llvm.org/viewvc/llvm-project?rev=264849&view=rev
Log:
Fix warning in ThreadSanitizerRuntime
Modified:
lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp
Modified:
lldb/tr
Author: labath
Date: Wed Mar 30 04:43:04 2016
New Revision: 264850
URL: http://llvm.org/viewvc/llvm-project?rev=264850&view=rev
Log:
Fix SocketAddressTest (again)
On some versions of Windows, the address is returned as "::1", while on others
it's
"0:0:...:0:1". Accept both versions, as they repr
Author: kuba.brecka
Date: Wed Mar 30 05:50:24 2016
New Revision: 264854
URL: http://llvm.org/viewvc/llvm-project?rev=264854&view=rev
Log:
Fix the ThreadSanitizer support to avoid creating empty SBThreads and to not
crash when thread_id is unavailable. Plus a whitespace fix.
Modified:
lldb/
labath created this revision.
labath added reviewers: tberghammer, tfiala.
labath added a subscriber: lldb-commits.
Debug info is used only by the client and lldb-server tests do not even have
the client component
running, as they communicate with the server directly. Therefore, running the
test
LGTM, thanks for getting to that, Pavel!
On Wednesday, March 30, 2016, Pavel Labath wrote:
> labath created this revision.
> labath added reviewers: tberghammer, tfiala.
> labath added a subscriber: lldb-commits.
>
> Debug info is used only by the client and lldb-server tests do not even
> have
Any issues with this? Honestly you can probably just read the description
and lgtm it based on that, because as I said it's 99% a code move, and
there is no functional change except for the one bug fix in
ClangUtil::RemoveFastQualifiers.
I have a followup patch almost complete which moves some mo
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
The main reason I don't like this is all of the merge headaches it will create
for us. We merge to swift.org and then over into some internal git repos. We
have like 5 branches t
clayborg added a comment.
I do like the tests that you added and I think we can still do the tests in
TestClangASTContext.cpp.
http://reviews.llvm.org/D18530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
zturner added a comment.
One or two of the functions, you are right. They do `clang::ASTContext`
related things. That was actually an oversight on my part. I meant to move
only functions that specifically did NOT do `clang::ASTContext` things. Like
`RemoveFastQualifiers`, or converting enum
Author: jingham
Date: Wed Mar 30 13:14:36 2016
New Revision: 264883
URL: http://llvm.org/viewvc/llvm-project?rev=264883&view=rev
Log:
Fix header name.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/Clang
ted added a comment.
Thanks for adding me, Tamas.
It looks like removing the code in the Hexagon Dynamic Loader plugin will have
lldb drill down into ObjectFileElf, and end up doing the same thing - set the
load address of each section of the ELF file. So it should behave the same as
before th
clayborg added a comment.
In http://reviews.llvm.org/D18530#387175, @zturner wrote:
> One or two of the functions, you are right. They do `clang::ASTContext`
> related things. That was actually an oversight on my part. I meant to move
> only functions that specifically did NOT do `clang::AST
zturner added a reviewer: rsmith.
zturner added a comment.
But wouldn't doing that manual merge once then make things easier for the
future? For example, if you merge back to a branch that doesn't have
`ClangUtil.cpp`, and then you just add `ClangUtil.cpp` to that branch, the
problem is solved
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I have explained my beef with the changes. If you feel you must make them as
you want to we will deal with the fallout and extra work.
http://reviews.llvm.org/D18530
__
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
I don't maintain any downstream branch to worry about merges but my personal
opinion is moving large amount of code around can cause some issue in the
future even for upstream. The 2 main issue I can think about:
- "git l
rsmith added a comment.
In http://reviews.llvm.org/D18530#387230, @zturner wrote:
> I'm curious now what clang does in this regard, so +rsmith in case he has
> some insight into what happens in clang when someone wants to re-organize
> some code and how other downstream customers (for example,
zturner added a comment.
In http://reviews.llvm.org/D18530#387328, @tberghammer wrote:
> I don't maintain any downstream branch to worry about merges but my personal
> opinion is moving large amount of code around can cause some issue in the
> future even for upstream. The 2 main issue I can th
> On Mar 30, 2016, at 12:31 PM, Tamas Berghammer via lldb-commits
> wrote:
>
> So in general if we get some actual advantage from moving the code (e.g.
> cleaner API, better testing options, etc...) then I have no issue around it
> but if the only gain is the file size reduction and the remov
Author: gclayton
Date: Wed Mar 30 15:14:35 2016
New Revision: 264909
URL: http://llvm.org/viewvc/llvm-project?rev=264909&view=rev
Log:
When support for DWO files was added, there were two ways to pass
lldb::user_id_t out to the rest of LLDB:
1 - DWARF in .o files with debug map in executable: we
zturner added a comment.
So, in thinking about this some more, my end goal does not necessarily involve
the creation of a new file. The primary goal is group related functions
together into a more bite-sized interface in order to make it easier to
understand the code.
How about keeping everyt
Author: spyffe
Date: Wed Mar 30 15:17:41 2016
New Revision: 264914
URL: http://llvm.org/viewvc/llvm-project?rev=264914&view=rev
Log:
Fixed a problem where a dSYM wasn't properly found because it had the wrong name
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-static-me
clayborg added a comment.
In http://reviews.llvm.org/D18530#387377, @zturner wrote:
> So, in thinking about this some more, my end goal does not necessarily
> involve the creation of a new file. The primary goal is group related
> functions together into a more bite-sized interface in order to
zturner added a comment.
In http://reviews.llvm.org/D18530#387382, @clayborg wrote:
> In http://reviews.llvm.org/D18530#387377, @zturner wrote:
>
> > So, in thinking about this some more, my end goal does not necessarily
> > involve the creation of a new file. The primary goal is group related
zturner added a comment.
The last time we talked about this, you said something along the lines of
"Changes to LLVM and LLDB at the same time are a problem, but any refactor that
happens entirely within LLDB is fine"
http://reviews.llvm.org/D18530
___
clayborg added a comment.
> I thought you said the issue was if you try to merge to a branch that didn't
> have the `ClangUtil.cpp` file. If you just copy and paste a function from
> one location in a file to another location and change the class it belongs
> to, that's still a problem?
So m
fjricci created this revision.
fjricci added reviewers: tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
Print environment from triple if it exists.
http://reviews.llvm.org/D18620
Files:
source/Core/ArchSpec.cpp
Index: source/Core/ArchSpec.cpp
==
fjricci created this revision.
fjricci added reviewers: clayborg, tfiala, tberghammer.
fjricci added subscribers: sas, lldb-commits.
Herald added subscribers: danalbert, tberghammer, aemerson.
If we determine an OS from the executable, but not an environment,
the existing code will not update the
fjricci abandoned this revision.
fjricci added a comment.
Doesn't appear necessary after applying http://reviews.llvm.org/D18620
http://reviews.llvm.org/D18621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
zturner added a comment.
I will move most of this back to `ClangASTContext`, but I want to state again
that I would like to reach a point where downstream merge issues are not even a
topic that comes up in code reviews. I see many huge refactors coming through
from people that do not go up for
Author: enrico
Date: Wed Mar 30 17:45:13 2016
New Revision: 264957
URL: http://llvm.org/viewvc/llvm-project?rev=264957&view=rev
Log:
Enhance the 'type X list' commands such that they actually alert the user if no
formatters matching the constraints could be found
Modified:
lldb/trunk/packa
fjricci created this revision.
fjricci added reviewers: jasonmolenda, tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fixes "target list" for non-android linux platforms (ie gnu, gnueabi)
http://reviews.llvm.org/D18631
Files:
so
Author: enrico
Date: Wed Mar 30 20:10:54 2016
New Revision: 264980
URL: http://llvm.org/viewvc/llvm-project?rev=264980&view=rev
Log:
Add --help and --long-help options to 'command alias' such that one can now
specify a help string for an alias as they are defining it
Modified:
lldb/trunk/pa
nitesh.jain created this revision.
nitesh.jain added reviewers: clayborg, ovyalov.
nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad,
lldb-commits.
These patch will set clang::TargetOptions::ABI and accordingly code will be
generated For MIPS target.
http://reviews.llvm.org/
38 matches
Mail list logo
