Re: [Lldb-commits] [PATCH] D18335: Fix for missing prompt on Windows

clayborg added a comment. Sounds good. This code is very tricky and we need to find a way to control this so that these issues never happen. When we do this, it will hopefully fix these kinds of issues for everyone. Thanks for taking the extra time to look into it and at least you have made the

[Lldb-commits] LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Having trouble building on OSX. ERROR:root:Unable to find swig executable: 'module' object has no attribute 'OSError' Command /bin/sh failed with exit code 250 But "which swig" finds it just fine. It's been a long time since I've built on OSX so I don't know if something has changed. In any c

Re: [Lldb-commits] [PATCH] D18228: Make File option flags consistent for Python API

fjricci added a comment. Friendly ping. http://reviews.llvm.org/D18228 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

fjricci created this revision. fjricci added reviewers: clayborg, granata.enrico, zturner. fjricci added subscribers: sas, lldb-commits. This reverts some of the changes made by: r257644 r250530 r250525 The changes made in these patches result in leaking the FILE* passed to SetImmediateOutputFile

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. This patch won't work. `PyFile_AsFile` doesn't exist on Python 3. Anything that you need done to make this work has to be wrapped up in `PythonFile` class as it was before, becau

[Lldb-commits] [lldb] r264332 - Fix for missing prompt on Windows

Author: ted Date: Thu Mar 24 15:35:03 2016 New Revision: 264332 URL: http://llvm.org/viewvc/llvm-project?rev=264332&view=rev Log: Fix for missing prompt on Windows Summary: On Windows (and possibly other hosts with LLDB_DISABLE_LIBEDIT defined), the (lldb) prompt won't print after async output,

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

You you building with Xcode? You should be building by checking out lldb at the top level, then typing: % xcodebuild -configuration Debug > On Mar 24, 2016, at 12:31 PM, Zachary Turner wrote: > > Having trouble building on OSX. > > ERROR:root:Unable to find swig executable: 'module' object h

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Yes I was doing it from inside the IDE though. I selected lldb-tool, 64-bit, and hit Product -> Build On Thu, Mar 24, 2016 at 2:11 PM Greg Clayton wrote: > You you building with Xcode? You should be building by checking out lldb > at the top level, then typing: > > % xcodebuild -configuration D

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

I usually select "desktop" as the target. Is this patch up to date? If so, I can apply and compile it and let you know what the results are. > On Mar 24, 2016, at 2:21 PM, Zachary Turner wrote: > > Yes I was doing it from inside the IDE though. I selected lldb-tool, 64-bit, > and hit Product

[Lldb-commits] [lldb] r264343 - Make 'type lookup' print an error message instead of complete radio silence when it can't find a type matching user input

Author: enrico Date: Thu Mar 24 16:32:39 2016 New Revision: 264343 URL: http://llvm.org/viewvc/llvm-project?rev=264343&view=rev Log: Make 'type lookup' print an error message instead of complete radio silence when it can't find a type matching user input It would be fun to make it provide sugges

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

zturner updated this revision to Diff 51605. zturner added a comment. Update patch. http://reviews.llvm.org/D18381 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/ClangASTImporter.h include/lldb/Symbol/ClangUtil.h include/lldb/Symbol/TypeSystem.h source/Plugins/Expres

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

It's updated now. I'm still getting errors building from inside Xcode when I use the IDE, but it works from the command line. But running the test pops up hundreds of dialogs asking me to enter my password to take control of another process, so I'm not sure how to disable that. Anyway I updated

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

> On Mar 24, 2016, at 2:44 PM, Zachary Turner via lldb-commits > wrote: > > It's updated now. I'm still getting errors building from inside Xcode when I > use the IDE, but it works from the command line. But running the test pops > up hundreds of dialogs asking me to enter my password to ta

[Lldb-commits] [lldb] r264346 - Get rid of a global constructor that was causing a warning on MacOSX and make the Timer safe to use after the main threads global destructor chain is called.

Author: gclayton Date: Thu Mar 24 16:46:47 2016 New Revision: 264346 URL: http://llvm.org/viewvc/llvm-project?rev=264346&view=rev Log: Get rid of a global constructor that was causing a warning on MacOSX and make the Timer safe to use after the main threads global destructor chain is called. Mo

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Is it one time until I reboot, or until the end of the test suite? On Thu, Mar 24, 2016 at 2:51 PM Enrico Granata wrote: > On Mar 24, 2016, at 2:44 PM, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > It's updated now. I'm still getting errors building from inside Xco

[Lldb-commits] [lldb] r264347 - Get rid of two global constructors by making things static variables in the only function that uses these variables.

Author: gclayton Date: Thu Mar 24 16:48:10 2016 New Revision: 264347 URL: http://llvm.org/viewvc/llvm-project?rev=264347&view=rev Log: Get rid of two global constructors by making things static variables in the only function that uses these variables. Modified: lldb/trunk/source/Plugins/La

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

> On Mar 24, 2016, at 2:53 PM, Zachary Turner wrote: > > Is it one time until I reboot, or until the end of the test suite? > The former. > On Thu, Mar 24, 2016 at 2:51 PM Enrico Granata > wrote: >> On Mar 24, 2016, at 2:44 PM, Zachary Turner via lldb-commits >> m

[Lldb-commits] [lldb] r264348 - Get rid of a global constructor and also make this code safe to use after the global destructor chain has been run on the main thread.

Author: gclayton Date: Thu Mar 24 16:49:22 2016 New Revision: 264348 URL: http://llvm.org/viewvc/llvm-project?rev=264348&view=rev Log: Get rid of a global constructor and also make this code safe to use after the global destructor chain has been run on the main thread. Modified: lldb/trunk/

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Once per login session. You may also need to run: sudo /usr/sbin/DevToolsSecurity --enable if you've never debugged anything before. You should only need to do this once per clean OS install. Jim > On Mar 24, 2016, at 2:53 PM, Zachary Turner via lldb-commits > wrote: > > Is it one time un

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

fjricci added a comment. Because python 3 doesn't use `FILE*` as the underlying implementation anymore, I think the only way to make this work is to continue to use `dup()` to make the `FILE*`, but then to actually keep track of the ownership of the `FILE*`. This can't be done inside `PythonFil

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

zturner added a comment. if (!StreamIsValid()) { if (DescriptorIsValid()) { const char *mode = GetStreamOpenModeFromOptions (m_options); if (mode) { if (!m_should_close_fd) { // We must duplicate the file d

[Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

amccarth created this revision. amccarth added a reviewer: clayborg. amccarth added a subscriber: lldb-commits. I set out to add functionality to dump headers from a binary, only to discover that the functionality already existed but wasn't (as far as I can tell) hooked up to the command line.

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Figured as much. Thanks for the tip. Back to the issue of the test suite, I ran the test suite but I get a ton of errors in Objective C tests even without my patch applied. So I must still be doing something worng. I used the xcodebuild command line, then ran `test/dotest.py` with no arguments.

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

fjricci added a comment. When we pass the `FILE*` to `SetImmediateOutputFile`, it then generates a new `File` from this `FILE*`, but doesn't take ownership, because the transfer_ownership flag is always false. And the `File` destructor only closes files if it has ownership of the `FILE*`. htt

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

clayborg added a comment. What does some sample output of this look like? I can't remember what module->Dump(...) does. http://reviews.llvm.org/D18464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

zturner added inline comments. Comment at: scripts/Python/python-typemaps.swig:532 @@ -531,3 +524,1 @@ - file.Clear(); -} } fjricci wrote: > The problem is that here, we save the `FILE*` (`$1`) and let the `File` > (`file`) go out of scope. So the `F

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

zturner added inline comments. Comment at: scripts/Python/python-typemaps.swig:532 @@ -531,3 +524,1 @@ - file.Clear(); -} } zturner wrote: > fjricci wrote: > > The problem is that here, we save the `FILE*` (`$1`) and let the `File` > > (`file`) go ou

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

You might need to set your workspace settings for the lldb.xcworkspace as follows: File -> Workspace Settings... Derived Data: Workspace-relative Location and use the value "build" for it Then click the "Advanced..." button and select "Legacy". The test suite automatically looks in the lldb

[Lldb-commits] [lldb] r264351 - Make File option flags consistent for Python API

Author: sas Date: Thu Mar 24 17:22:20 2016 New Revision: 264351 URL: http://llvm.org/viewvc/llvm-project?rev=264351&view=rev Log: Make File option flags consistent for Python API Summary: Fixes SBCommandReturnObject::SetImmediateOutputFile() and SBCommandReturnObject::SetImmediateOutputFile() for

Re: [Lldb-commits] [PATCH] D18228: Make File option flags consistent for Python API

sas closed this revision. sas added a comment. Committed as r264351. http://reviews.llvm.org/D18228 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

fjricci added inline comments. Comment at: scripts/Python/python-typemaps.swig:532 @@ -531,3 +524,1 @@ - file.Clear(); -} } The problem is that here, we save the `FILE*` (`$1`) and let the `File` (`file`) go out of scope. So the `File` gets destructe

Re: [Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

Is there any way you could try it out for me? It still doesn't build successfully from the IDE with those steps. The patch should apply cleanly at tip. Later this week I can try to nuke my whole lldb directory and start over with a clean repo. On Thu, Mar 24, 2016 at 3:26 PM Greg Clayton wrote

[Lldb-commits] [lldb] r264353 - Update the INFOPLIST_FILE setting in the xcode project file

Author: jmolenda Date: Thu Mar 24 17:27:52 2016 New Revision: 264353 URL: http://llvm.org/viewvc/llvm-project?rev=264353&view=rev Log: Update the INFOPLIST_FILE setting in the xcode project file so that the lldb command line binary's version #'s are updated correctly. Modified: lldb/trunk/l

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

amccarth added a comment. I'm using it with PE files (Windows), so I see A table of where the debug info exists MSDOS Header COFF Header PECOFF header a table of section headers (.rdata, .bss, etc.). The section headers table is redundant with `target modules dump sections`, but I don't see ano

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

amccarth added a comment. Literally: Dumping headers for 1 module(s). Headers for 'd:\src\fizzbuzz\a.exe': Module d:\src\fizzbuzz\a.exe 04189230: ObjectFilePECOFF, file = 'd:\src\fizzbuzz\a.exe', arch = i386 SectID Type File Address

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

fjricci added inline comments. Comment at: scripts/Python/python-typemaps.swig:532 @@ -531,3 +524,1 @@ - file.Clear(); -} } zturner wrote: > zturner wrote: > > fjricci wrote: > > > The problem is that here, we save the `FILE*` (`$1`) and let the `File

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

Could there be an overload of SBCommandReturnObject constructor that takes an fd instead of a FILE*, and pass through to the private method which does its own duping? Then this typemap could be changed to convert to int instead of to FILE* Also I'm OOO until tomorrow now, so I can't look at the co

[Lldb-commits] [lldb] r264356 - Make it possible for language plugins to provide additional custom help for 'type lookup'

Author: enrico Date: Thu Mar 24 18:06:42 2016 New Revision: 264356 URL: http://llvm.org/viewvc/llvm-project?rev=264356&view=rev Log: Make it possible for language plugins to provide additional custom help for 'type lookup' Modified: lldb/trunk/include/lldb/Target/Language.h lldb/trunk/s

[Lldb-commits] [lldb] r264361 - Ignore global constructor warning in clang.

Author: gclayton Date: Thu Mar 24 18:50:03 2016 New Revision: 264361 URL: http://llvm.org/viewvc/llvm-project?rev=264361&view=rev Log: Ignore global constructor warning in clang. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/trunk/source

[Lldb-commits] [lldb] r264379 - Use Clang's FixItHints to correct expressions with "trivial" mistakes (e.g. "." for "->".)

Author: jingham Date: Thu Mar 24 20:57:14 2016 New Revision: 264379 URL: http://llvm.org/viewvc/llvm-project?rev=264379&view=rev Log: Use Clang's FixItHints to correct expressions with "trivial" mistakes (e.g. "." for "->".) This feature is controlled by an expression command option, a target pro

[Lldb-commits] [lldb] r264380 - Add the same host logging that I added to PlatformRemoteiOS a few

Author: jmolenda Date: Thu Mar 24 21:17:27 2016 New Revision: 264380 URL: http://llvm.org/viewvc/llvm-project?rev=264380&view=rev Log: Add the same host logging that I added to PlatformRemoteiOS a few months back to PlatformRemoteAppleTV and PlatformRemoteAppleWatch to help understand what's happe

Re: [Lldb-commits] [lldb] r264379 - Use Clang's FixItHints to correct expressions with "trivial" mistakes (e.g. "." for "->".)

This seems like an odd thing to do by default. Is there going to be a setting to turn this off? Seems to me like off should be default An enumerated setting would be even nicer, where one option is "report" that just doesn't apply any FixIts, but prints a message saying "did you mean Foo->bar()?"

Re: [Lldb-commits] [lldb] r264379 - Use Clang's FixItHints to correct expressions with "trivial" mistakes (e.g. "." for "->".)

The specific example Jim gave (./->) is a very common complaint of people coming from gdb. gdb's hand-rolled parser would realize that when you -> on an object, that doesn't make sense and silently correct it to . for you. In practice, when you're examining local variables, you often don't r

Re: [Lldb-commits] [lldb] r264379 - Use Clang's FixItHints to correct expressions with "trivial" mistakes (e.g. "." for "->".)

I can see how it would be useful, but i do think it should be possible to disable and/or warn about On Thu, Mar 24, 2016 at 7:40 PM Jason Molenda wrote: > The specific example Jim gave (./->) is a very common complaint of people > coming from gdb. > > gdb's hand-rolled parser would realize that w