zturner added a comment.
I guess my point was just that it seems a little weird to treat DWARF
specially. It's just another debug info format (albeit one that most compilers
support), so by baking into the supposedly generic interface the requirement
that "every type system must be able to sup
Author: kuba.brecka
Date: Wed Mar 23 10:36:22 2016
New Revision: 264162
URL: http://llvm.org/viewvc/llvm-project?rev=264162&view=rev
Log:
Add ThreadSanitizer debugging support.
This patch adds ThreadSanitizer support into LLDB:
- Adding a new InstrumentationRuntime plugin, ThreadSanitizerRuntime,
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp:110-119
@@ -80,3 +109,12 @@
-} // anonymous namespace end
+template
+
Author: kuba.brecka
Date: Wed Mar 23 11:54:23 2016
New Revision: 264168
URL: http://llvm.org/viewvc/llvm-project?rev=264168&view=rev
Log:
Follow-up for r264162 to fix the CMake build (update LLDBDependencies.cmake).
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
Modified: lldb/trunk/cmak
clayborg added a comment.
I
In http://reviews.llvm.org/D18381#381457, @zturner wrote:
> I guess my point was just that it seems a little weird to treat DWARF
> specially. It's just another debug info format (albeit one that most
> compilers support), so by baking into the supposedly generic i
Author: sas
Date: Wed Mar 23 13:00:13 2016
New Revision: 264173
URL: http://llvm.org/viewvc/llvm-project?rev=264173&view=rev
Log:
Implement ObjectFilePECOFF::GetEntryPointAddress.
Reviewers: zturner, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D17970
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264173: Implement ObjectFilePECOFF::GetEntryPointAddress.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D17970?vs=50978&id=51449#toc
Repository:
rL LLVM
http://reviews.llvm.org
ted updated this revision to Diff 51462.
ted added a comment.
Updated to change cursor position before async output so old prompt is
overwritten.
Adrian, please test with your setup and let me know if it solves the issues you
see.
http://reviews.llvm.org/D18335
Files:
source/Core/IOHandler
amccarth added a comment.
This is better. In the same scenario, I see just one extra prompt instead of
three extras. Maybe that one happens through a different code path.
> (lldb) br set -l 22
> Breakpoint 1: where = a.exe`main + 20 at fizzbuzz.cpp:22, address =
> 0x0040e074
> (lldb) run
sivachandra updated this revision to Diff 51466.
sivachandra added a comment.
Address comments.
http://reviews.llvm.org/D18379
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.h
===
sivachandra added inline comments.
Comment at: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp:110-119
@@ -80,3 +109,12 @@
-} // anonymous namespace end
+template
+T
+Align(const T v, uint8_t bytes)
+{
+uint8_t rem = v % bytes;
+if (rem == 0)
+
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for all the fixes.
http://reviews.llvm.org/D18379
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
zturner updated this revision to Diff 51476.
zturner added a comment.
This patch has gotten both bigger and smaller. Smaller in the sense that after
taking into consideration the most recent comments, there was really only one
piece left of my patch. It is the piece that abstracted out `CanCom
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few things in inlined comments, but this is very close.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParser.h:36
@@ -35,3 +35,3 @@
virtual bool
-
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1614-1622
@@ -1611,9 +1613,11 @@
TypeSystem *type_system = compiler_type.GetTypeSystem();
-if (type_system)
-{
-DWARFASTParser *dwarf_ast = type_system->GetDWARFPars
zturner updated this revision to Diff 51480.
zturner added a comment.
Fixes issue with `CanCompleteType` being unimplemented. This update deletes
`CanCompleteType` and `CompleteType` from `DWARFASTParser` base class, and
users of that function now call `GetClangASTImporter().CanImport()` and
`
clayborg added a comment.
I will need to run the MacOSX test suite on this before I can give it the OK. I
won't be able to do this today, but might be able to get to it tomorrow. If you
can run the MacOSX test suite, let me know.
http://reviews.llvm.org/D18381
__
ted added a comment.
Adrian and I worked out what is going on:
1. Run starts the launch and writes a prompt
2. State change fires, prints out “launching” through async, overwriting the
prompt from 1) and writing a new prompt
3. CommandObjectProcessLaunch::Execute appends “launch” to the result.
zturner added a comment.
It's been a while since I've used my Mac. I'll fire it up and see if I can get
it going, but no promises. I'll update tomorrow
http://reviews.llvm.org/D18381
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
Author: sivachandra
Date: Wed Mar 23 18:27:23 2016
New Revision: 264217
URL: http://llvm.org/viewvc/llvm-project?rev=264217&view=rev
Log:
[JITLoaderGDB] Read jit entry struct manually.
Summary:
Though r264012 was fancy enough to make reading the jit entry struct
work with templates, the packing a
20 matches
Mail list logo
