labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.
The actual changes aren't too bad, but I wonder why you need to add them at
all. These files all assume they will b
jasonmolenda added a comment.
Good point. Let me play with the xcode project file (which I was using to do
the build) tomorrow; your solution may be the correct one, we might have some
files being built unnecessarily.
Repository:
rL LLVM
http://reviews.llvm.org/D17750
__
Author: labath
Date: Tue Mar 1 05:40:47 2016
New Revision: 262322
URL: http://llvm.org/viewvc/llvm-project?rev=262322&view=rev
Log:
Fix warning in NSDictionary.cpp
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.cpp
Modified: lldb/trunk/source/Plugins/Language/ObjC/NSDictiona
labath added a comment.
In http://reviews.llvm.org/D17724#364450, @clayborg wrote:
> As long as both long and short options are still supported? Can you still
> type any of:
>
> - --arch=x86_64
> - --arch x86_64
> - -arch=x86_64
> - -arch x86_64
> - -ax86_64
> - -a x86_64
All the variants work
Author: labath
Date: Tue Mar 1 08:04:41 2016
New Revision: 262333
URL: http://llvm.org/viewvc/llvm-project?rev=262333&view=rev
Log:
Slightly improve logging in LLGS tests
we're sometimes getting an exception here, and I want to see why...
Modified:
lldb/trunk/packages/Python/lldbsuite/test
Author: tberghammer
Date: Tue Mar 1 09:01:05 2016
New Revision: 262339
URL: http://llvm.org/viewvc/llvm-project?rev=262339&view=rev
Log:
DWARFExpression: Don't resolve load address in DW_OP_plus
If we have a TargetLoadAddress on the top of the DWARF stack then a
DW_OP_plus or a DW_OP_plus_ucons
I think there's a lot of value in having lldb's help output and cl syntax
match all of the other llvm tools that people are already familiar with.
Simplicity through consistency. So lgtm
On Tue, Mar 1, 2016 at 4:22 AM Pavel Labath wrote:
> labath added a comment.
>
> In http://reviews.llvm.org/D1
zturner added a comment.
I think there's a lot of value in having lldb's help output and cl syntax
match all of the other llvm tools that people are already familiar with.
Simplicity through consistency. So lgtm
http://reviews.llvm.org/D17724
___
ll
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One general comment is the use of "auto". Although it makes the code shorter,
it does make it quite a bit less readable. I will leave the decision to you
since this is your code,
On Tue, Mar 1, 2016 at 10:10 AM Greg Clayton wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> One general comment is the use of "auto". Although it makes the code
> shorter, it does make it quite a bit less read
There's an lldb-private-forward.h that you can use for this purpose if you wish.
Jim
> On Mar 1, 2016, at 10:32 AM, Zachary Turner via lldb-commits
> wrote:
>
>
>
> On Tue, Mar 1, 2016 at 10:10 AM Greg Clayton wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
You don't add plug-in specify unique_ptr and shared_ptr definitions. You would
put these in SymbolFilePDB.h only.
> On Mar 1, 2016, at 10:51 AM, Jim Ingham wrote:
>
> There's an lldb-private-forward.h that you can use for this purpose if you
> wish.
>
> Jim
>
>> On Mar 1, 2016, at 10:32 AM,
Regarding the refactoring of ResolveSymbolContext to a lower level. It
seems like a worthwhile refactor but probably one that should be done as an
independent CL. It seems like it has potential to open up a bit of a rats
nest so to speak, and if something ends up breaking as a result, we can
revert
ldrumm created this revision.
ldrumm added reviewers: clayborg, zturner, tberghammer, spyffe.
ldrumm added a subscriber: lldb-commits.
This CL adds a regression test for the bug listed at
https://llvm.org/bugs/show_bug.cgi?id=26790
http://reviews.llvm.org/D1
Files:
packages/Python/lldbsui
ldrumm updated this revision to Diff 49531.
ldrumm added a comment.
Updated diff to show full context
http://reviews.llvm.org/D17719
Files:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
Index: source/Plugins/Ex
You could add a test to that grabs functions bounds, once you implement
functions, and then lookup each address inside of a function and make sure each
one has a file and line. This might fall down for complex examples, but we also
ran into the Swift compiler saying a function went from 0x1000-0
ted updated this revision to Diff 49542.
ted added a comment.
Updated to address Sean's comments
http://reviews.llvm.org/D17745
Files:
include/lldb/Expression/IRInterpreter.h
source/Expression/IRExecutionUnit.cpp
source/Expression/IRInterpreter.cpp
source/Expression/LLVMUserExpression.c
Author: ted
Date: Tue Mar 1 15:53:26 2016
New Revision: 262407
URL: http://llvm.org/viewvc/llvm-project?rev=262407&view=rev
Log:
Fix bug with function resolution when using IR Interpreter
Summary: Recent changes to the expression parser broke function name resolution
when using the IR interpret
Author: eugenezelenko
Date: Tue Mar 1 19:09:03 2016
New Revision: 262441
URL: http://llvm.org/viewvc/llvm-project?rev=262441&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core;
other minor fixes.
Modified:
lldb/trunk/include/lldb/Core/Broadcaster.h
Author: eugenezelenko
Date: Tue Mar 1 20:18:18 2016
New Revision: 262450
URL: http://llvm.org/viewvc/llvm-project?rev=262450&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core;
other minor fixes.
Modified:
lldb/trunk/source/Core/DataExtractor.cpp
ll
jasonmolenda abandoned this revision.
jasonmolenda added a comment.
Yes, taking the source/Plugins/Process/Linux directory out of the xcodeproject
file altogether makes this build on ios, I'll go with that approach.
Repository:
rL LLVM
http://reviews.llvm.org/D17750
__
21 matches
Mail list logo
