Hi Hans,
This change fixes expression related tests for MIPS release 6 architecture
(mipsr6).
Regards,
Bhushan
-Original Message-
From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
Wennborg
Sent: 23 February 2016 00:25
To: Bhushan Attarde
Cc: lldb-commits@lists
labath added a subscriber: labath.
Comment at: source/Core/ConstString.cpp:269
@@ +268,3 @@
+bool
+ConstString::Equals (const ConstString& lhs, const ConstString& rhs, const
bool case_sensitive)
+{
zturner wrote:
> Looks like this code also isn't clang-formatted.
I agree with Adrian. I don't think the section comments are supposed
to apply to the "main header file", which should always come first.
On 23 February 2016 at 00:17, Eugene Zelenko via lldb-commits
wrote:
> On Mon, Feb 22, 2016 at 4:14 PM, Adrian McCarthy wrote:
>> It looks like this patch reor
Author: tberghammer
Date: Tue Feb 23 05:35:38 2016
New Revision: 261630
URL: http://llvm.org/viewvc/llvm-project?rev=261630&view=rev
Log:
XFAIL TestInlines for Linux with gcc
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/inlines/TestInlines.py
Modified:
lldb/trunk/packages/Pyth
labath added a subscriber: labath.
labath added a comment.
I'll leave the final review to Tamas, just a couple of comments here.
Comment at:
packages/Python/lldbsuite/test/functionalities/single_step_atomic_sequence/TestStepInAtomicSequence.py:70
@@ +69,3 @@
+inst_o
Author: labath
Date: Tue Feb 23 06:26:08 2016
New Revision: 261631
URL: http://llvm.org/viewvc/llvm-project?rev=261631&view=rev
Log:
[linux] Remove all traces of signalfd(2)
Summary:
Signalfd is not used in the code anymore, and given that the same functionality
can be achieved
with the new Main
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261631: [linux] Remove all traces of signalfd(2) (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D17510?vs=48692&id=48805#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1751
Author: labath
Date: Tue Feb 23 07:56:30 2016
New Revision: 261636
URL: http://llvm.org/viewvc/llvm-project?rev=261636&view=rev
Log:
Work around a stepping bug in arm64 android M
Summary:
On arm64, linux<=4.4 and Android<=M there is a bug, which prevents
single-stepping from working when
the sys
This revision was automatically updated to reflect the committed changes.
labath marked 2 inline comments as done.
Closed by commit rL261636: Work around a stepping bug in arm64 android M
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D17509?vs=48690&id=48811#toc
Reposi
tberghammer added a comment.
We have 2 (+1) independent dimension here:
1. List of ranges where the variable is in scope
2. List of ranges where the variable is available
3. Format of the location list (it is more of an implementation details because
of a format change in dwarf5)
To represent a
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
the python2 branch seems erroneous as it expected the object to be both a
"String" and "Bytes".
Fix the expectation.
http://reviews.llvm.org/D17545
Files:
unittests/ScriptInterpreter/Pytho
zturner added inline comments.
Comment at: source/Core/ConstString.cpp:269
@@ +268,3 @@
+bool
+ConstString::Equals (const ConstString& lhs, const ConstString& rhs, const
bool case_sensitive)
+{
labath wrote:
> zturner wrote:
> > Looks like this code also isn't cl
zturner added inline comments.
Comment at: unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:212
@@ -211,3 +211,2 @@
PythonBytes python_bytes(PyRefType::Owned, py_bytes);
-EXPECT_EQ(PyObjectType::Bytes, python_bytes.GetObjectType());
Seems l
zturner added a comment.
http://reviews.llvm.org/D17545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Comment at: unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:212
@@ -211,3 +211,2 @@
PythonBytes python_bytes(PyRefType::Owned, py_bytes);
-EXPECT_EQ(PyObjectType::Bytes, python_bytes.GetObjectType());
zturner
Did those tests pass for mipsr6 with 3.7?
On Tue, Feb 23, 2016 at 3:19 AM, Bhushan Attarde
wrote:
> Hi Hans,
>
> This change fixes expression related tests for MIPS release 6 architecture
> (mipsr6).
>
>
> Regards,
> Bhushan
>
> -Original Message-
> From: hwennb...@google.com [mailto:hwe
These were failures with 3.7 for mipsr6.
Regards,
Bhushan
From: hwennb...@google.com [hwennb...@google.com] on behalf of Hans Wennborg
[h...@chromium.org]
Sent: Tuesday, February 23, 2016 10:29 PM
To: Bhushan Attarde
Cc: lldb-commits@lists.llvm.org; Greg C
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham; removed: clayborg.
clayborg added a comment.
Looks good to me, but I think Jim Ingham should have a look in case he has
anything to add since Jim is the master or stepping.
Repository:
rL LLVM
http://reviews.llv
clayborg added a comment.
In http://reviews.llvm.org/D17449#359717, @tberghammer wrote:
> We have 2 (+1) independent dimension here:
>
> 1. List of ranges where the variable is in scope
> 2. List of ranges where the variable is available
> 3. Format of the location list (it is more of an implemen
tberghammer added a comment.
I am not sure I agree with the following starting point of the CL (I know about
the similar functionality in GDB) and even if we agree in it I think you are
handling a very small fraction of the problems.
> LLDB should treat all instructions in the atomic sequence a
tberghammer added a comment.
I can live with that but I still think the scope information belongs to the
variable and not to the DWARF expression representing it's location. As far as
I see keeping the information inside the variable have lower memory impact
(assuming an empty list means full s
+1
We put the header file first immediately after the header comment in the .cpp
file. The reason is that if you put the .cpp file's associated .h file in the
project include headers section, then it would be easy to accidentally put
another "project include" in front of the associated one (f
clayborg added a comment.
In http://reviews.llvm.org/D17449#359874, @tberghammer wrote:
> I can live with that but I still think the scope information belongs to the
> variable and not to the DWARF expression representing it's location. As far
> as I see keeping the information inside the varia
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
IIUC, what you are doing here is when lldb-server gets a "step instruction"
request that would step into one of these atomic regions, it sets a bunch of
breakpoints on it's end (no
Author: spyffe
Date: Tue Feb 23 17:09:06 2016
New Revision: 261704
URL: http://llvm.org/viewvc/llvm-project?rev=261704&view=rev
Log:
When looking for symbols, find load addresses in a more robust way.
IRExecutionUnit previously replicated a bunch of logic that already
existed elsewhere for the pu
amccarth updated this revision to Diff 48863.
amccarth added a comment.
Adds some very basic tests using a check-in minidump captured with Task Manager.
What we can do in the test is limited because the minidump doesn't seem to have
an exception record (thus the thread isn't stopped). I plan to
Hi Sean,
On Linux with i386 inferiors,
range.GetBaseAddress().GetCallableLoadAddress(target);
returns the wrong load address for strlen, while
candidate_sc.symbol->ResolveCallableAddress(*target);
returns the correct load address.
This is causing TestCStrings to fail on our bot:
http://lab.ll
chaoren created this revision.
chaoren added a reviewer: spyffe.
chaoren added a subscriber: lldb-commits.
Temporarily revert part of r261704.
http://reviews.llvm.org/D17557
Files:
source/Expression/IRExecutionUnit.cpp
Index: source/Expression/IRExecutionUnit.cpp
=
chaoren updated this revision to Diff 48867.
chaoren added a comment.
Use target instead of sc.target_sp.get().
http://reviews.llvm.org/D17557
Files:
source/Expression/IRExecutionUnit.cpp
Index: source/Expression/IRExecutionUnit.cpp
===
Honsik updated the summary for this revision.
Honsik updated this revision to Diff 48871.
Honsik added a comment.
I added requested changes.
http://reviews.llvm.org/D17492
Files:
include/lldb/Core/ConstString.h
include/lldb/Host/FileSpec.h
packages/Python/lldbsuite/test/functionalities/b
Author: eugenezelenko
Date: Tue Feb 23 20:05:55 2016
New Revision: 261716
URL: http://llvm.org/viewvc/llvm-project?rev=261716&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in some
files in source/Commands; other minor fixes.
Modified:
lldb/trunk/source
Honsik added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:288-294
@@ -288,1 +287,9 @@
+
+if sys.platform.startswith('win32'):
+import ctypes, time
+while not ctypes.windll.kernel32.IsDebuggerPresent():
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261718: Fix TestCStrings for Linux with i386 inferiors.
(authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D17557?vs=48867&id=48878#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: chaoren
Date: Tue Feb 23 21:15:21 2016
New Revision: 261718
URL: http://llvm.org/viewvc/llvm-project?rev=261718&view=rev
Log:
Fix TestCStrings for Linux with i386 inferiors.
Summary: Temporarily revert part of r261704.
Reviewers: spyffe
Subscribers: lldb-commits
Differential Revision:
zturner added inline comments.
Comment at: source/Host/common/FileSpec.cpp:519
@@ -515,3 +518,3 @@
// in one of the FileSpec objects.
if (full || (a.m_directory && b.m_directory))
Did the case sensitive check get removed here? I thought this would nee
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good after the fix of the misspelling. If you want I can fix it for you
and commit tomorrow.
I assume you ran the test suite and did not see any new errors?
Comment
36 matches
Mail list logo
