labath added a comment.
I like the idea. I think this could help us with the linux vs. android dilemma
we've been having recently: currently, we consider android to be a flavour of
linux, which means it's not possible to XFAIL tests passing on android but
failing on linux. This should make expr
omjavaid added a comment.
Is this good to go ?
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a subscriber: labath.
labath added a comment.
I think this would be better if you could specify the connection direction in
the url. Also, a test for this functionality would be great.
Comment at: source/Interpreter/CommandInterpreter.cpp:638
@@ +637,3 @@
+
nitesh.jain created this revision.
nitesh.jain added reviewers: clayborg, ovyalov.
nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad,
lldb-commits.
nitesh.jain set the repository for this revision to rL LLVM.
The debug version of libc.so is require for backtracing which may n
tberghammer added a comment.
Can you take a look for the 2 marked comment? I think you handling those error
scenarios incorrectly
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:592
@@ +591,3 @@
+if (float_count == 1 && !is_complex)
+
bhushan updated this revision to Diff 47621.
bhushan added a comment.
Addressed review comments:
- Rebased this patch off top of tree
- Added ArchSpec::GetClangTargetCPU() as suggested and moved large switch
statement into it.
Repository:
rL LLVM
http://reviews.llvm.org/D17022
Files:
inc
omjavaid updated this revision to Diff 47625.
omjavaid added a comment.
I have added an else case for unhandled or error cases.
I have added to Todo for handling complex and vector types. ABI document doesnt
say much about how complex will be returned so I am doing a bit investigation
with how t
omjavaid added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:658
@@ -582,2 +657,3 @@
+
if (byte_size <= 4)
{
Homogenous types with elements more than 4 will fall through and will be
handled by this even in case of hard
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good, thank you for fixing it
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
Author: omjavaid
Date: Thu Feb 11 05:41:22 2016
New Revision: 260512
URL: http://llvm.org/viewvc/llvm-project?rev=260512&view=rev
Log:
Handle floating-point type homogeneous aggregate return values in ABISysV_arm
For details refer to review link given below.
Differential revision: http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260512: Handle floating-point type homogeneous aggregate
return values in ABISysV_arm (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D16975?vs=47625&id=47626#toc
Repository:
Author: aidandodds
Date: Thu Feb 11 09:16:37 2016
New Revision: 260525
URL: http://llvm.org/viewvc/llvm-project?rev=260525&view=rev
Log:
[Renderscript] Refactor target argument reading code.
This patch reworks the function argument reading code, allowing us to annotate
arguments with their types
zturner added a comment.
I think technically there are some platforms that cannot be both a host and a
target. ios and anything involving a simulator comes to mind. But, if the
only "gotcha" to having both of them be in the same enum is that it's up to the
programmer to make sure he's using t
labath added a comment.
In http://reviews.llvm.org/D17088#350005, @zturner wrote:
> I think technically there are some platforms that cannot be both a host and a
> target. ios and anything involving a simulator comes to mind. But, if the
> only "gotcha" to having both of them be in the same e
Author: aidandodds
Date: Thu Feb 11 11:17:12 2016
New Revision: 260546
URL: http://llvm.org/viewvc/llvm-project?rev=260546&view=rev
Log:
[Renderscript] Fix typo in mips64 argument reading code.
A typo in the mips64 argument reading code would cause register passed
arguments to be truncated to 32
fjricci added a comment.
Would it be better to add a test in the same commit or a separate one?
Comment at: source/Interpreter/CommandInterpreter.cpp:638
@@ +637,3 @@
+connect_gdb_remote_cmd_ap->AddRegexCommand("^([^:]+:[[:digit:]]+)
reverse$",
+
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
In some circumstances (notably, certain minidumps), the thread CONTEXT does not
have values for the control registers (EIP, ESP, EBP, EFLAGS). There are flags
in the CONTEXT which indi
cameron314 added a comment.
I've replied to most of your comments, thanks everyone. I'll make most of the
suggested changes, but some of them have nothing to do with correct Unicode
handling and are rather pre-existing design issues, and so are out of the scope
of this patch.
@zturner: I agree
Author: amccarth
Date: Thu Feb 11 12:24:57 2016
New Revision: 260559
URL: http://llvm.org/viewvc/llvm-project?rev=260559&view=rev
Log:
Improve ReadRegister for RegisterContextWindowsx86
In some circumstances (notably, certain minidumps), the thread CONTEXT does not
have values for the
control re
zturner added inline comments.
Comment at: lldb/trunk/source/Commands/CommandCompletions.cpp:171
@@ -168,1 +170,3 @@
{
+#ifdef _WIN32
+llvm::SmallVector wpartial_name_copy;
cameron314 wrote:
> zturner wrote:
> > I'm not fond of this approach o
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Don't assert in ArchSpec::GetClangTargetCPU () and always call this function.
See inlined comments.
Comment at: source/Core/ArchSpec.cpp:558
@@ +557,3 @@
+
fjricci updated this revision to Diff 47681.
fjricci added a comment.
Refactor to use listen urls
http://reviews.llvm.org/D17099
Files:
source/Interpreter/CommandInterpreter.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommuni
zturner updated this revision to Diff 47684.
zturner added a comment.
Merged into one list. Also moved code into a new module `lldbplatform`.
http://reviews.llvm.org/D17088
Files:
packages/Python/lldbsuite/test/decorators.py
packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHis
zturner added a comment.
Also make sure you run `ninja check-lldb` and `ninja check-lldb-unit` with this
patch to make sure everything works.
Comment at: lldb/trunk/source/Core/ConnectionSharedMemory.cpp:140
@@ +139,3 @@
+llvm::SmallVector wname;
+if (llvm::convertUTF8T
zturner added inline comments.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:108
@@ +107,3 @@
+if (stat_result == 0)
+*stats_ptr = *reinterpret_cast(&file_stats);
+return stat_result == 0;
cameron314 wrote:
> zturner wrote:
> >
Author: emaste
Date: Thu Feb 11 15:15:49 2016
New Revision: 260589
URL: http://llvm.org/viewvc/llvm-project?rev=260589&view=rev
Log:
XFAIL TestCommandScriptImmediateOutput on FreeBSD also
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/Tes
mamai created this revision.
mamai added a reviewer: spyffe.
mamai added subscribers: phlav, lldb-commits.
mamai set the repository for this revision to rL LLVM.
The evaluation of expressions containing register values was broken for targets
for which endianness differs from host.
This patch fix
ovyalov added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py:22
@@ -20,1 +21,3 @@
+# Backtracing failed due to lack of prolog/epilog informations in assert
function of libc.so.6
+@expectedFailureAll(tripl
Author: gclayton
Date: Thu Feb 11 17:36:57 2016
New Revision: 260618
URL: http://llvm.org/viewvc/llvm-project?rev=260618&view=rev
Log:
Removed a bad assertion:
assert(((SymbolFileDWARF*)m_ast.GetSymbolFile())->UserIDMatches(die.GetDIERef().GetUID())
&&
"Adding incorrect type to forward de
Author: jingham
Date: Thu Feb 11 18:03:19 2016
New Revision: 260624
URL: http://llvm.org/viewvc/llvm-project?rev=260624&view=rev
Log:
When calling TypeSystemMap::Clear, objects being destroyed in the process of
clearing the map ended up calling back into the TypeSystemMap to do lookups.
Not a g
Author: gclayton
Date: Thu Feb 11 18:07:16 2016
New Revision: 260626
URL: http://llvm.org/viewvc/llvm-project?rev=260626&view=rev
Log:
Don't crash if we have a DIE that has a DW_AT_ranges attribute and yet the
SymbolFileDWARF doesn't have a DebugRanges. If this happens print a nice error
message
sivachandra created this revision.
sivachandra added reviewers: zturner, tfiala, labath.
sivachandra added a subscriber: lldb-commits.
This does not yet give us a clean testsuite run but it does help with:
1. Actually building on linux
2. Run the testsuite with over 70% tests passing on linux.
ht
sivachandra added a comment.
BTW, I should mention that the testsuite run with Python-2.x is still clean
with this change applied.
http://reviews.llvm.org/D17182
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
bhushan updated this revision to Diff 47765.
bhushan added a comment.
Removed assert statement so now "ArchSpec::GetClangTargetCPU ()" returns an
empty string (instead of crashing) for any CPU that doesn't really need to make
a special CPU string.
Removed the "if (is_mips)".
Repository:
rL L
zturner added a comment.
Very excited to see more platforms trying to get Python 3 working.
Comment at: source/API/liblldb.exports:4
@@ -3,1 +3,2 @@
init_lld*
+PyInit__lld*
I don't really know what the syntax of this file is, but the symbol is called
`PyInit__
nitesh.jain updated this revision to Diff 47767.
nitesh.jain added a comment.
Updated as per suggestion.
Repository:
rL LLVM
http://reviews.llvm.org/D17131
Files:
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
Index:
packages/Python/lldbsuite/test/f
zturner added a subscriber: zturner.
zturner added a comment.
Not going to block the change over this, but just as an fyi, you can
specify regexes without usign `re.compile`. You can literally just pass a
string that is a regex, it will still work
Repository:
rL LLVM
http://reviews.llvm.org/
Not going to block the change over this, but just as an fyi, you can
specify regexes without usign `re.compile`. You can literally just pass a
string that is a regex, it will still work
On Thu, Feb 11, 2016 at 11:22 PM Nitesh Jain via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> nitesh.j
Author: enrico
Date: Fri Feb 12 01:50:15 2016
New Revision: 260664
URL: http://llvm.org/viewvc/llvm-project?rev=260664&view=rev
Log:
The data formatters for NSArray, NSDictionary and (only partially) NSSet
contain logic to inspect the objects without running code.
However, they also contain fallb
39 matches
Mail list logo
