Re: [Lldb-commits] [lldb] r259962 - Fix "thread backtrace -s": option was misparsed because of a missing break.

2016-02-06 Thread Jason Molenda via lldb-commits
Hi Zachary, related to this bug, I was looking into clang diagnostics and there is one that would have helped us catch this, -Wimplicit-fallthrough. It would have issued a warning for CommandObjectThread.cpp (when built with clang, of course) but it won't generate a warning for case 0: case 1:

Re: [Lldb-commits] [lldb] r259962 - Fix "thread backtrace -s": option was misparsed because of a missing break.

2016-02-06 Thread Zachary Turner via lldb-commits
On MSVC 2015 I get this: 1>c:\users\zach\documents\visual studio 2015\projects\consoleapplication2\consoleapplication2\consoleapplication2.cpp(22): warning C5030: attribute 'clang::fallthrough' is not recognized 1>c:\users\zach\documents\visual studio 2015\projects\consoleapplication2\consoleappli