labath accepted this revision.
This revision is now accepted and ready to land.
Comment at: packages/Python/lldbsuite/test/dosep.py:1145
@@ -1144,1 +1144,3 @@
+else:
+target = None
I think this should be `target = platform_name`, so that you
labath updated this revision to Diff 45667.
labath added a comment.
Let's try a different approach. This should disable the logic of
LINK_LLVM_DYLIB for lldb binaries, and thereby enabling that build
to work. It should be the safest thing in the short term, and we
can figure out a better fix later
Author: labath
Date: Fri Jan 22 08:50:29 2016
New Revision: 258501
URL: http://llvm.org/viewvc/llvm-project?rev=258501&view=rev
Log:
Revert "Enable test log collection from remote debug servers"
Unfortunately, this turns out not to be working on the lldb-server tests, as
there the server is
star
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
https://llvm.org/bugs/show_bug.cgi?id=25819
http://reviews.llvm.org/D16476
Files:
packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py
Index: packages/Python/lldb
zturner created this revision.
zturner added a reviewer: gkistanova.
zturner added a subscriber: lldb-commits.
x86 builds of libclang.dll are failing with out of memory errors (Example:
http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc/builds/14604). This
patch is a global change against
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:1145
@@ -1144,1 +1144,3 @@
+else:
+target = None
labath wrote:
> I think this should be `target = platform_name`, so that you can still match
> the ios-simulat
Author: tfiala
Date: Fri Jan 22 14:20:48 2016
New Revision: 258542
URL: http://llvm.org/viewvc/llvm-project?rev=258542&view=rev
Log:
fixed test suite crash when --platform-name doesn't start with 'remote-'
Also removes Darwin test case files from the expectedTimeout hard-coded
file list.
See:
ht
Author: compnerd
Date: Fri Jan 22 14:26:32 2016
New Revision: 258547
URL: http://llvm.org/viewvc/llvm-project?rev=258547&view=rev
Log:
Target: fix -Wcast-qual warning
We were unnecessarily stripping the const qualifier on the temporary variable.
Restore the constness to avoid the warning. NFC.
Author: compnerd
Date: Fri Jan 22 14:26:30 2016
New Revision: 258546
URL: http://llvm.org/viewvc/llvm-project?rev=258546&view=rev
Log:
Silence -Wreturn-type warnings
Address a couple of instances of -Wreturn-type warning from GCC. The switches
are covered, add an llvm_unreachable to the end of t
Author: compnerd
Date: Fri Jan 22 14:26:34 2016
New Revision: 258548
URL: http://llvm.org/viewvc/llvm-project?rev=258548&view=rev
Log:
Commands: silence dumb -Wextra warning from GCC
This is a rather unhelpful warning indicating that the ternary operator return
types are mismatched, returning an
tfiala closed this revision.
tfiala added a comment.
Closed by svn commit r258542.
http://reviews.llvm.org/D16423
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Fri Jan 22 15:58:55 2016
New Revision: 258565
URL: http://llvm.org/viewvc/llvm-project?rev=258565&view=rev
Log:
added test fixture to EditlineTest gtest
Primarily a trial test for me to try out the
git clang-format integration. Works like a charm!
This change adds a gtest f
Author: amccarth
Date: Fri Jan 22 17:05:47 2016
New Revision: 258578
URL: http://llvm.org/viewvc/llvm-project?rev=258578&view=rev
Log:
XFail a test from TestConditionalBreak.py on Windows.
Filed a bug to investigate later: llvm.org/pr26265
Modified:
lldb/trunk/packages/Python/lldbsuite/tes
Author: amccarth
Date: Fri Jan 22 17:05:29 2016
New Revision: 258577
URL: http://llvm.org/viewvc/llvm-project?rev=258577&view=rev
Log:
XFail TestNamespaceLookup tests on Windows.
There's already a pr: https://llvm.org/bugs/show_bug.cgi?id=25819
Modified:
lldb/trunk/packages/Python/lldbsuit
Author: enrico
Date: Fri Jan 22 17:50:46 2016
New Revision: 258584
URL: http://llvm.org/viewvc/llvm-project?rev=258584&view=rev
Log:
Add a helper function to ProcessStructReader to allow one to inquire about the
offset of a field
Modified:
lldb/trunk/include/lldb/Utility/ProcessStructReader
Author: tfiala
Date: Fri Jan 22 17:50:57 2016
New Revision: 258585
URL: http://llvm.org/viewvc/llvm-project?rev=258585&view=rev
Log:
candidate fix for Green Dragon lldb testbot
The python test run target started failing recently.
I tracked it down to what looks like the passing of
environment var
Author: zturner
Date: Fri Jan 22 17:54:41 2016
New Revision: 258586
URL: http://llvm.org/viewvc/llvm-project?rev=258586&view=rev
Log:
More fixes related to counting threads on Windows.
The Windows 10 loader spawns threads at startup, so
tests which count threads or assume that a given user
thread
Author: zturner
Date: Fri Jan 22 17:54:45 2016
New Revision: 258587
URL: http://llvm.org/viewvc/llvm-project?rev=258587&view=rev
Log:
Un xfail TestSettings.test_run_args_and_env_vars_with_dwarf
Modified:
lldb/trunk/packages/Python/lldbsuite/test/settings/TestSettings.py
Modified: lldb/trunk/
Author: zturner
Date: Fri Jan 22 17:54:49 2016
New Revision: 258588
URL: http://llvm.org/viewvc/llvm-project?rev=258588&view=rev
Log:
Decode files with UTF-8 in lldbutil.line_number.
Since Unicode support is different in Py2 and Py3, Py3 was throwing
exceptions about being unable to decode the fi
Would you mind adding a comment telling people how to do this correctly to the
"Writing test cases" section of the README-testsuite?
Jim
> On Jan 22, 2016, at 3:54 PM, Zachary Turner via lldb-commits
> wrote:
>
> Author: zturner
> Date: Fri Jan 22 17:54:41 2016
> New Revision: 258586
>
> URL
Yea, that's a good idea. Thanks for the suggestion
On Fri, Jan 22, 2016 at 4:05 PM Jim Ingham wrote:
> Would you mind adding a comment telling people how to do this correctly to
> the "Writing test cases" section of the README-testsuite?
>
> Jim
>
> > On Jan 22, 2016, at 3:54 PM, Zachary Turner
By the way, I'm reminded of a discussion we had on an old bug report where
we said that an even better way to do this would be to name threads from
inside the debugger and have the test fetch threads with specific names.
That's probably still a better way to do this (especially when multiple
thread
That would be fine as an additional test.
There isn't an SBThread::SetName, but that would be trivial to add.
Also, if we are going to rely on this, we should improve how SetName is done.
Right now the default implementation does nothing, so it relies on the
particular implementation to se
Author: zturner
Date: Fri Jan 22 18:49:11 2016
New Revision: 258592
URL: http://llvm.org/viewvc/llvm-project?rev=258592&view=rev
Log:
Fix missing function argument passthrough.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
Modified: lldb/trunk/packages/Python/lldbsuite/test
Author: tfiala
Date: Fri Jan 22 20:24:41 2016
New Revision: 258601
URL: http://llvm.org/viewvc/llvm-project?rev=258601&view=rev
Log:
fixed TestConsecutiveBreakpoints test on OS X
Also renamed directory and class name to fix typos.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionali
Author: tfiala
Date: Fri Jan 22 20:34:16 2016
New Revision: 258602
URL: http://llvm.org/viewvc/llvm-project?rev=258602&view=rev
Log:
Skipped IncompleteModulesTestCase on OS X
This is hitting an assert in clang when evaluating the
module load. I am seeing it locally on Xcode 7.3 public Beta 1
and
cray added a subscriber: cray.
cray added a comment.
The amd64_x86 toolchain is not present on the community edition of visual
studio. I am not sure if any build bots use this version though.
http://reviews.llvm.org/D16477
___
lldb-commits mailin
27 matches
Mail list logo
