Author: tberghammer
Date: Tue Jan 19 04:24:51 2016
New Revision: 258113
URL: http://llvm.org/viewvc/llvm-project?rev=258113&view=rev
Log:
Unconditionally accept symbol sizes from elf
The ELF symbol table always contain the size of the symbols so we
don't have to try to guess them based on the add
ravitheja updated this revision to Diff 45238.
ravitheja added a comment.
correcting previous revision.
http://reviews.llvm.org/D16107
Files:
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
packages/Python/lldbsuite/test/functionalities/unwind/noreturn
labath added a comment.
Looks good as far as I am concerned. @tberghammer, @ovyalov ?
http://reviews.llvm.org/D16107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Tue Jan 19 04:59:10 2016
New Revision: 258114
URL: http://llvm.org/viewvc/llvm-project?rev=258114&view=rev
Log:
Remove last XTIMEOUTs from android tests
TestHelloWorld seems to be passing now as far as I can tell. TestExitDuringStep
is still hanging.
I have marked the releva
bhushan updated the summary for this revision.
bhushan updated this revision to Diff 45237.
bhushan added a comment.
Addressed review comments.
Instead of adding new decorator, this patch modifies existing `skipUnlessArch`
to detect the type of the "archs" variable and do the things according to
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D16107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: ravitheja
Date: Tue Jan 19 06:55:21 2016
New Revision: 258122
URL: http://llvm.org/viewvc/llvm-project?rev=258122&view=rev
Log:
Fix for Bug 25338
Summary:
The issue arises because LLDB is not
able to read the vdso library correctly.
The fix adds memory allocation callbacks
to allocate suf
tfiala added a subscriber: tfiala.
tfiala added a comment.
> Setting the dependencies as private required a fixup of the argdumper link
> command, as it was not
actually linking to liblldb (it was referring to symbols from the lldb_private
namespace, which
are not exposed in liblldb),
At some
hans added a comment.
In http://reviews.llvm.org/D16284#329161, @loladiro wrote:
> The Makefile system will be removed from trunk very soon, so it might not
> necessarily make sense there, but I think it would be good to get this
> applied to release-38. @clayborg @hans how would you like to ha
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
We already have the ability to collect the server logs when doing local
debugging. This enables
the collection of remote logs as well. This relies on specifying a relative
path "server.log" fo
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Tue Jan 19 11:54:47 2016
New Revision: 258150
URL: http://llvm.org/viewvc/llvm-project?rev=258150&view=rev
Log:
Implementing the method Target::TargetEventData::Dump (Stream *s) so that its
clients can easily dump it out for informational messages.
http://reviews.llvm.org/D
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL258150
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just factor the cool archs stuff into a function that others can use and this
is good to go.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1040-1049
@@
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
That looks fine to me as far as it goes, but it doesn't cover other places
where $ is used in function names, e.g. the name of the expression itself, and
classes it's placed in. Cou
Sure. Greg, are you the code owner for this, or is there a specific
owner for Go?
Thanks,
Hans
On Fri, Jan 15, 2016 at 11:43 AM, Ryan Brown via lldb-commits
wrote:
> It would be nice if we could get this into 3.8 to get rid of these asserts.
>
> -- Ryan Brown
>
> On Fri, Jan 15, 2016 at 11:35 AM
zturner added a comment.
Yea that seems like a good idea. I can do that in a followup.
Jim, does this patch look ok to you?
http://reviews.llvm.org/D16247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
jingham added a comment.
Yes, that is a cleaner way to do this.
In about half the cases you use get_threads_stopped_at_breakpoint and half
get_stopped_thread. It looks like you were just mirroring what the test did,
so that's fine, but if I know the breakpoint I'm expecting, I prefer
get_thre
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Oh, yeah, I'm supposed to say "request changes" for the use of
get_threads_stopped_at_breakpoint...
http://reviews.llvm.org/D16247
_
Author: spyffe
Date: Tue Jan 19 15:48:25 2016
New Revision: 258194
URL: http://llvm.org/viewvc/llvm-project?rev=258194&view=rev
Log:
Removed a bunch of spurious files from the man page Copy Files build phase.
A few files were accidentally added to the Copy Files build phase for our man
page, and
Author: davide
Date: Tue Jan 19 15:59:12 2016
New Revision: 258199
URL: http://llvm.org/viewvc/llvm-project?rev=258199&view=rev
Log:
[Process] Remove dead code. All the switch cases are already covered.
Modified:
lldb/trunk/source/Expression/ExpressionSourceCode.cpp
lldb/trunk/source/Targ
This is needed in order to prevent MSVC from warning about this case. I
explicitly added these last week. Can I ask that you revert this change?
On Tue, Jan 19, 2016 at 2:03 PM Davide Italiano via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: davide
> Date: Tue Jan 19 15:59:12 20
zturner updated this revision to Diff 45302.
zturner added a comment.
Fix incorrect usage of `get_threads_stopped_at_breakpoint` by adding a new
function that returns the first thread stopped at a breakpoint.
http://reviews.llvm.org/D16247
Files:
packages/Python/lldbsuite/test/expression_com
zturner added a comment.
Fixed that issue. The other issue you pointed out about using
`get_stopped_thread` sometimes is because in those tests breakpoints were
created using `runCmd` so we don't have an `SBBreakpoint` handy like we do in
the other cases.
http://reviews.llvm.org/D16247
__
On Tue, Jan 19, 2016 at 2:05 PM, Zachary Turner wrote:
> This is needed in order to prevent MSVC from warning about this case. I
> explicitly added these last week. Can I ask that you revert this change?
>
Well, this broke the build with -Werror which is my default, that's
why I made the change
On Tue, Jan 19, 2016 at 2:08 PM, Davide Italiano wrote:
> On Tue, Jan 19, 2016 at 2:05 PM, Zachary Turner wrote:
>> This is needed in order to prevent MSVC from warning about this case. I
>> explicitly added these last week. Can I ask that you revert this change?
>>
In particular:
../tools/ll
What about this:
switch (m_private_state.GetValue())
{
case eStateConnected:
case eStateAttaching:
case eStateLaunching:
case eStateStopped:
case eStateRunning:
case eStateStepping:
case eStateCrashed:
case eStateSuspended:
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
That looks good. get_one_thread_stopped_at_breakpoint is convenient, but I'd
rather not sweep under the rug cases where you expected only one thread to hit
your breakpoint but mor
zturner added a comment.
Maybe I can give it an argument like `require_exactly_one_thread` which
defaults to True. That way at least you can still use the same function in the
case where you just want the first thread (which is how `get_stopped_thread`
works)
http://reviews.llvm.org/D16247
jingham added a comment.
That would be fine too. Just seems like this is asking to have a miswritten
test that accidentally stops at two hits of the breakpoint but you didn't
notice because MOST of the time, the right thread was first, which would lead
to an odd flakey test.
http://reviews.l
On Tue, Jan 19, 2016 at 2:11 PM, Zachary Turner wrote:
> What about this:
>
> switch (m_private_state.GetValue())
> {
> case eStateConnected:
> case eStateAttaching:
> case eStateLaunching:
> case eStateStopped:
> case eStateRunning:
> case e
Should be fine. I probably don't need to try out the patch, it looks good
as is (and I'm not in a state where I can try it for a while)
On Tue, Jan 19, 2016 at 2:22 PM Davide Italiano wrote:
> On Tue, Jan 19, 2016 at 2:11 PM, Zachary Turner
> wrote:
> > What about this:
> >
> > switch (m_p
Author: davide
Date: Tue Jan 19 16:47:51 2016
New Revision: 258212
URL: http://llvm.org/viewvc/llvm-project?rev=258212&view=rev
Log:
Placate MVSC after my last commit.
Zachary introduced the 'default' case explicitly to placate a warning in
the Microsoft compiler but that broke clang with -Werror
On Tue, Jan 19, 2016 at 2:24 PM, Zachary Turner wrote:
> Should be fine. I probably don't need to try out the patch, it looks good
> as is (and I'm not in a state where I can try it for a while)
>
Thanks. To close the loop, this is r258212.
> On Tue, Jan 19, 2016 at 2:22 PM Davide Italiano wro
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Apparently something changed with `thread step-over`, causing execution to move
outside the stack frame, and thus the local variables were no longer visible.
Since the step-over is unre
zturner added a comment.
I don't think something has changed within lldb though, because jsut updating
lldb without updating llvm and clang also don't trigger this problem. I think
we should try to figure out what really broke.
http://reviews.llvm.org/D16334
___
jingham added a subscriber: jingham.
jingham added a comment.
I agree with Zachary. Just because a test found a bug that wasn't essential to
the test doesn't mean we should "fix" the test by silencing the part of the
test that uncovered the bug.
This test puts a breakpoint on a 'puts("")' stat
zturner added a comment.
fwiw, `thread step-over` is *still* broken on Windows (because, well, fixing it
is kind of hard). So I'm not surprised that breaks (although I'm a little
surprised it worked in the first place). But at the same time this test
broken, about 15 other tests broke as well
amccarth abandoned this revision.
amccarth added a comment.
Interestingly, the test_step_over_dwarf test is now getting an UNEXPECTED
SUCCESS on Windows.
The TestUnsignedTypes.py test (from which this one was apparently copied--see
the class name) doesn't have the step-over.
http://reviews.ll
On Tue, Jan 19, 2016 at 10:11:48PM +, Zachary Turner via lldb-commits wrote:
> What about this:
>
> switch (m_private_state.GetValue())
> {
> case eStateConnected:
> case eStateAttaching:
> case eStateLaunching:
> case eStateStopped:
> case eStat
Author: jmolenda
Date: Tue Jan 19 23:17:13 2016
New Revision: 258289
URL: http://llvm.org/viewvc/llvm-project?rev=258289&view=rev
Log:
Some 32-bit arm corefiles on darwin may have their general purpose
register set indicated by ARM_THREAD_STATE32 (value 9) instead of
the old ARM_THREAD_STATE (valu
bhushan added a comment.
In http://reviews.llvm.org/D14111#330305, @spyffe wrote:
> That looks fine to me as far as it goes, but it doesn't cover other places
> where $ is used in function names, e.g. the name of the expression itself,
> and classes it's placed in. Could you have a look at
>
42 matches
Mail list logo
