This revision was automatically updated to reflect the committed changes.
Closed by commit rL255882: Add AccessModifierOffset to clang-format style
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D15562?vs=42988&id=43106#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: labath
Date: Thu Dec 17 03:19:36 2015
New Revision: 255882
URL: http://llvm.org/viewvc/llvm-project?rev=255882&view=rev
Log:
Add AccessModifierOffset to clang-format style
Summary:
As we override the indent option of the LLVM style, we need to override the
access modifier
offset as well.
Author: tberghammer
Date: Thu Dec 17 04:58:35 2015
New Revision: 255885
URL: http://llvm.org/viewvc/llvm-project?rev=255885&view=rev
Log:
XFAIL some tests failing for Windows -> Android
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/macros/TestMacros.py
lldb/trun
tberghammer accepted this revision.
tberghammer added a comment.
LGTM (next time please upload the diff with full context)
Repository:
rL LLVM
http://reviews.llvm.org/D15576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
Author: ewancrawford
Date: Thu Dec 17 05:59:47 2015
New Revision: 255887
URL: http://llvm.org/viewvc/llvm-project?rev=255887&view=rev
Log:
Inspect DW_AT_const_value global static const variables
This patch adds support for printing global static const variables which are
given a DW_AT_const_valu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255887: Inspect DW_AT_const_value global static const
variables (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D15576?vs=43017&id=43119#toc
Repository:
rL LLVM
http://r
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
clang-format your changes please (there are many deviations from the coding
style)
I'll check it on Linux and say if everything is OK.
Comment at: source/Command
ki.stfu added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-mi/symbol/symbol_list_lines_inline_test.h:20
@@ -19,3 +19,3 @@
{
-return a + b;
+return a + b; // FUNC_mfunc
}
and could you pick it up at 1 line above?
ADodds added a comment.
Its currently present in the official 2.7.10 windows x64 python distro from
python.org.
Its also present in some of the prebuilds I have been using from here:
http://p-nand-q.com/python/building-python-27-with-vs2010.html
I can only assume that perhaps it signifies that
Author: aidandodds
Date: Thu Dec 17 08:13:39 2015
New Revision: 255893
URL: http://llvm.org/viewvc/llvm-project?rev=255893&view=rev
Log:
Patch cmake to allow detection of python 2.7.9+
Some distributions of python have their version defined as follows in
patchlevel.h (note the '+'):
#define PY_V
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255893: Patch cmake to allow detection of python 2.7.9+
(authored by aidandodds).
Changed prior to commit:
http://reviews.llvm.org/D15566?vs=42994&id=43127#toc
Repository:
rL LLVM
http://reviews.llv
Author: ewancrawford
Date: Thu Dec 17 10:40:05 2015
New Revision: 255904
URL: http://llvm.org/viewvc/llvm-project?rev=255904&view=rev
Log:
[RenderScript] Support all RS allocation types
Currently we can just inspect the details of the most common allocation types.
This patch allows us to support
dawn marked 6 inline comments as done.
dawn added a comment.
> clang-format your changes please (there are many deviations from the coding
> style)
I've made some fixes even though the code is no longer consistent with the rest
of the file. Alas. I would love to run all of lldb through clang
dawn updated this revision to Diff 43152.
dawn marked an inline comment as done.
dawn added a comment.
Updated patch with suggestions from Ilia's review (thanks Ilia!).
Repository:
rL LLVM
http://reviews.llvm.org/D15593
Files:
packages/Python/lldbsuite/test/help/TestHelp.py
packages/Pyth
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Man those options are complex. I really would like to see something more simple:
"--raw" dumps the line entries as you have mentioned
"--no-inlines" would omit any inline entries
emaste accepted this revision.
emaste added a comment.
This revision is now accepted and ready to land.
LGTM
Or if you want show the set of arguments - e.g. ```expected frame-index, got 's
1'``` That might clarify the "too many arguments."
http://reviews.llvm.org/D15582
_
Author: tfiala
Date: Thu Dec 17 13:13:58 2015
New Revision: 255917
URL: http://llvm.org/viewvc/llvm-project?rev=255917&view=rev
Log:
ResultsFormatter: always lock on handle_event()
Some of the newer structures were not protected. Now that we have
a recursive lock, we just lock the whole handle_e
> On Dec 17, 2015, at 10:25 AM, Dawn Perchik wrote:
>
> dawn marked 6 inline comments as done.
> dawn added a comment.
>
>> clang-format your changes please (there are many deviations from the coding
>> style)
>
>
> I've made some fixes even though the code is no longer consistent with the
clayborg added a comment.
Ok, so I talked with Jim on this and this is what we came up with. I would like
to see no changes made to the "target modules dump line-table" command. It is
dumping complete line tables. This command is not for "find any line entries
that match this file anywhere incl
clayborg added a comment.
I do want to apologize to Dawn and Jim for not having chimed in earlier and
causing Dawn some extra work.
Repository:
rL LLVM
http://reviews.llvm.org/D15593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
ki.stfu added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:1536-1537
@@ -1508,1 +1535,4 @@
+bool has_path = (file_spec.GetDirectory().AsCString() != 0);
+int ncus = module->GetNumCompileUnits();
+for (size_t i = 0; i < nc
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:226
@@ -225,3 @@
-// Skip entries which don't match the desired source.
-if (strWantFile != strFile)
-continue;
Is strWantFile needed? Seems it's an
clayborg added a comment.
Dawn, if you don't understand what I asked you to do, let me know and I can go
and do the "source info" command for you, then you can modify this patch to
just use the command I added. But it should be simple to just revert and
changes to the original line table dumpin
clayborg added a comment.
Note that you won't need any of the options that you had added to the other
command becuase the "source info" command will do what you wanted in the first
place: find all line entries where a file and optional line is mentioned in any
line tables.
Repository:
rL LL
Author: tfiala
Date: Thu Dec 17 16:42:50 2015
New Revision: 255935
URL: http://llvm.org/viewvc/llvm-project?rev=255935&view=rev
Log:
Revert "Disable test reruns on arm unless explicitly marked with
--rerun-all-issues"
and
Revert "prevent rerun logic from kicking in on test runs including aarch64
Author: jmolenda
Date: Thu Dec 17 18:45:35 2015
New Revision: 255942
URL: http://llvm.org/viewvc/llvm-project?rev=255942&view=rev
Log:
The lldb side changes to go along with r255711 where a new
"thread-pcs" key is added to the T (questionmark) packet in
gdb-remote protocol so that lldb doesn't nee
Author: jingham
Date: Thu Dec 17 20:14:04 2015
New Revision: 255972
URL: http://llvm.org/viewvc/llvm-project?rev=255972&view=rev
Log:
Make the Language print the description of the Exception Breakpoint resolver.
Also
have the breakpoint description print the precondition description if one
exis
Author: jingham
Date: Thu Dec 17 20:15:25 2015
New Revision: 255973
URL: http://llvm.org/viewvc/llvm-project?rev=255973&view=rev
Log:
Fix formatting for last commit.
Modified:
lldb/trunk/source/Target/Language.cpp
Modified: lldb/trunk/source/Target/Language.cpp
URL:
http://llvm.org/viewvc/l
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
29 matches
Mail list logo
